dynamic / silverstripe-locator

src/Tasks/LocationToPageTask.php

<?php

namespace Dynamic\Locator\Tasks;

use Dynamic\Locator\Location;
use Dynamic\Locator\Page\LocationPage;
use Dynamic\Locator\Page\Locator;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\BuildTask;
use SilverStripe\Versioned\Versioned;

/**
 * Class LocationToPageTask
 * @package Dynamic\Locator\Tasks
 */
class LocationToPageTask extends BuildTask
{
    /**
     * @var string
     */
    protected $title = 'Locator - Location to Page Task';

    /**
     * @var string
     */
    private static $segment = 'locator-location-to-page-task';

The private property $segment is not used, and could be removed.

    /**
     * @var bool
     */
    private static $auto_publish_location = false;

The private property $auto_publish_location is not used, and could be removed.

    /**
     * @param \SilverStripe\Control\HTTPRequest $request
     */
    public function run($request)
    {
        $this->migrateLocations();
    }

    /**
     *
     */
    protected function migrateLocations()
    {
        if (!$parent = Locator::get()->first()) {
            $parent = Locator::create();
            $parent->Title = "Locator";
            $parent->writeToStage(Versioned::DRAFT);
        }

        /** @var Location $location */
        foreach ($this->getLocations() as $location) {
            if (!LocationPage::get()->filter('LegacyObjectID', $location->ID)->first()) {
                if ($location->hasMethod('isPublished')) {
                    $published = $location->isPublished();
                }

                /** @var LocationPage $newLocation */
                $newLocation = Injector::inst()->create(LocationPage::class, $location->toMap(), false);
                $newLocation->setClassName(LocationPage::class);
                $newLocation->ID = null;
                $newLocation->ParentID = $parent->ID;

The property ParentID does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                $newLocation->LegacyObjectID = $location->ID;

The property LegacyObjectID does not exist on Dynamic\Locator\Page\LocationPage. Since you implemented __set, consider adding a @property annotation.

                $this->extend('preLocationMigrationUpdate', $location, $newLocation);

                $newLocation->writeToStage(Versioned::DRAFT);

                if ((isset($published) && $published) || $this->config()->get('auto_publish_location')) {
                    $newLocation->publishSingle();
                }
            }
        }
    }

    /**
     * @return \Generator
     */
    protected function getLocations()
    {
        foreach (Location::get() as $location) {
            yield $location;
        }
    }
}