LocatorControllerTest::testGetLocations() - Code Metrics - Inspection of "Front end uses react and redux" - dynamic/silverstripe-locator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#173)

by Matthew

created 2017-10-27 13:47 UTC

LocatorControllerTest::testGetLocations() A

↳ Parent: LocatorControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	31
c	1
b	0
f	1
nc	1
nop	0
dl	0
loc	52
rs	9.4929

How to fix Long Method

<?php

namespace Dynamic\Locator\Tests;

use Dynamic\Locator\Location;
use Dynamic\Locator\LocationCategory;
use Dynamic\Locator\Locator;
use Dynamic\Locator\LocatorController;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataObject;

/**
 * Class LocatorControllerTest
 * @package Dynamic\Locator\Tests
 */
class LocatorControllerTest extends FunctionalTest
{

    protected static $fixture_file = '../fixtures.yml';

    protected static $use_draft_site = true;

    /**
     * Tests the json route
     */
    public function testJson()

    {
        $locator = $this->objFromFixture(Locator::class, 'locator1');

        $page = $this->get($locator->Link('json'));

        $this->assertEquals(200, $page->getStatusCode());
        $this->assertEquals('application/json', $page->getHeader('Content-Type'));

        $this->assertNotEquals(null, json_decode($page->getBody()));
    }

    /**
     * Tests the settings route
     */
    public function testSettings()

    {
        $locator = $this->objFromFixture(Locator::class, 'locator1');

        $page = $this->get($locator->Link('settings'));

        $this->assertEquals(200, $page->getStatusCode());
        $this->assertEquals('application/json', $page->getHeader('Content-Type'));

        $this->assertNotEquals(null, json_decode($page->getBody()));
    }

    /**
     * Tests specific parts of getLocations()
     */
    public function testGetLocations()
    {
        $category = $this->objFromFixture(LocationCategory::class, 'service');

        $loc1 = $this->objFromFixture(Location::class, 'dynamic');
        // generic Sheboygan WI coordinates
        $loc1->Lat = 43.7444081;
        $loc1->Lng = -87.8005188;
        $loc1->write();

        $loc2 = $this->objFromFixture(Location::class, 'silverstripe');
        // generic New Zealand coordinates
        $loc2->Lat = -39.3846249;
        $loc2->Lng = 157.3172296;
        $loc2->write();

        $locator = $this->objFromFixture(Locator::class, 'locator1');

        $controller = Injector::inst()->create(LocatorController::class);

        $request = new HTTPRequest(
            'GET',
            $locator->Link('json'),
            array(
                'address' => '1526+S+12th+St+Sheboygan+WI',
                'radius' => 25,
                'category' => $category->ID,
            )
        );

        $locations = $controller->getLocations($request);

        $this->assertInstanceOf(ArrayList::class, $locations);
        // because address isn't actually used to determine distance here,
        // everything defaults to -1
        $this->assertEquals(2, $locations->Count());

        // radius of -1, everything in the category should be in the list
        $request = new HTTPRequest(
            'GET',
            $locator->Link('json'),
            array(
                'address' => '1526+S+12th+St+Sheboygan+WI',
                'radius' => -1,
                'category' => $category->ID,
            )
        );

        $locations = $controller->getLocations($request);

        $this->assertInstanceOf(ArrayList::class, $locations);
        $this->assertEquals(2, $locations->Count());
    }
}


1		<?php
2
3		namespace Dynamic\Locator\Tests;
4
5		use Dynamic\Locator\Location;
6		use Dynamic\Locator\LocationCategory;
7		use Dynamic\Locator\Locator;
8		use Dynamic\Locator\LocatorController;
9		use SilverStripe\Control\HTTPRequest;
10		use SilverStripe\Core\Injector\Injector;
11		use SilverStripe\Dev\FunctionalTest;
12		use SilverStripe\ORM\ArrayList;
13		use SilverStripe\ORM\DataObject;
14
15		/**
16		* Class LocatorControllerTest
17		* @package Dynamic\Locator\Tests
18		*/
19		class LocatorControllerTest extends FunctionalTest
20		{
21
22		protected static $fixture_file = '../fixtures.yml';
23
24		protected static $use_draft_site = true;
25
26		/**
27		* Tests the json route
28		*/
29	View Code Duplication	public function testJson()
		0 ignored issues – show Duplication introduced 2017-10-27 14:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		$locator = $this->objFromFixture(Locator::class, 'locator1');
32
33		$page = $this->get($locator->Link('json'));
34
35		$this->assertEquals(200, $page->getStatusCode());
36		$this->assertEquals('application/json', $page->getHeader('Content-Type'));
37
38		$this->assertNotEquals(null, json_decode($page->getBody()));
39		}
40
41		/**
42		* Tests the settings route
43		*/
44	View Code Duplication	public function testSettings()
		0 ignored issues – show Duplication introduced 2017-10-27 14:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$locator = $this->objFromFixture(Locator::class, 'locator1');
47
48		$page = $this->get($locator->Link('settings'));
49
50		$this->assertEquals(200, $page->getStatusCode());
51		$this->assertEquals('application/json', $page->getHeader('Content-Type'));
52
53		$this->assertNotEquals(null, json_decode($page->getBody()));
54		}
55
56		/**
57		* Tests specific parts of getLocations()
58		*/
59		public function testGetLocations()
60		{
61		$category = $this->objFromFixture(LocationCategory::class, 'service');
62
63		$loc1 = $this->objFromFixture(Location::class, 'dynamic');
64		// generic Sheboygan WI coordinates
65		$loc1->Lat = 43.7444081;
66		$loc1->Lng = -87.8005188;
67		$loc1->write();
68
69		$loc2 = $this->objFromFixture(Location::class, 'silverstripe');
70		// generic New Zealand coordinates
71		$loc2->Lat = -39.3846249;
72		$loc2->Lng = 157.3172296;
73		$loc2->write();
74
75		$locator = $this->objFromFixture(Locator::class, 'locator1');
76
77		$controller = Injector::inst()->create(LocatorController::class);
78
79		$request = new HTTPRequest(
80		'GET',
81		$locator->Link('json'),
82		array(
83		'address' => '1526+S+12th+St+Sheboygan+WI',
84		'radius' => 25,
85		'category' => $category->ID,
86		)
87		);
88
89		$locations = $controller->getLocations($request);
90
91		$this->assertInstanceOf(ArrayList::class, $locations);
92		// because address isn't actually used to determine distance here,
93		// everything defaults to -1
94		$this->assertEquals(2, $locations->Count());
95
96		// radius of -1, everything in the category should be in the list
97		$request = new HTTPRequest(
98		'GET',
99		$locator->Link('json'),
100		array(
101		'address' => '1526+S+12th+St+Sheboygan+WI',
102		'radius' => -1,
103		'category' => $category->ID,
104		)
105		);
106
107		$locations = $controller->getLocations($request);
108
109		$this->assertInstanceOf(ArrayList::class, $locations);
110		$this->assertEquals(2, $locations->Count());
111		}
112		}
113

dynamic / silverstripe-locator

Pull Request — master (#173)

LocatorControllerTest::testGetLocations() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like