Locator_Controller::doSearch() - Code Metrics - Inspection of "PHP Location filtering" - dynamic/silverstripe-locator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#88)

by Jason

created 2016-04-08 21:25 UTC

Locator_Controller::doSearch() A

↳ Parent: Locator_Controller

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
ccs	0
cts	0
cp	0
rs	9.4285
cc	2
eloc	11
nc	2
nop	3
crap	6

<?php

class Locator extends Page
{
    private static $db = array(

        'AutoGeocode' => 'Boolean',
        'ModalWindow' => 'Boolean',
        'Unit' => 'Enum("m,km","m")',
    );

    private static $many_many = array(

        'Categories' => 'LocationCategory',
    );

    private static $defaults = array(

        'AutoGeocode' => true,
    );

    private static $singular_name = 'Locator';

    private static $plural_name = 'Locators';

    private static $description = 'Find locations on a map';


    public function getCMSFields()

    {
        $fields = parent::getCMSFields();

        // Settings
        $fields->addFieldsToTab('Root.Settings', array(
            HeaderField::create('DisplayOptions', 'Display Options', 3),
            OptionsetField::create('Unit', 'Unit of measure', array('m' => 'Miles', 'km' => 'Kilometers')),
            CheckboxField::create('AutoGeocode', 'Auto Geocode - Automatically filter map results based on user location')
                ->setDescription('Note: if any locations are set as featured, the auto geocode is automatically disabled.'),
            CheckboxField::create('ModalWindow', 'Modal Window - Show Map results in a modal window'),
        ));

        // Filter categories
        $config = GridFieldConfig_RelationEditor::create();
        if (class_exists('GridFieldAddExistingSearchButton')) {
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
        }
        $categories = $this->Categories();
        $categoriesField = GridField::create('Categories', 'Categories', $categories, $config)
            ->setDescription('only show locations from the selected category');

            // Filter
            $fields->addFieldsToTab('Root.Filter', array(
                HeaderField::create('CategoryOptionsHeader', 'Location Filtering', 3),
                $categoriesField,
            ));

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    public static function getLocations($filter = array(), $exclude = array(), $filterAny = array())

    {
        $filter['ShowInLocator'] = true;
        $exclude['Lat'] = 0;

        $Locations = Location::get()->exclude($exclude)->filter($filter)->filterAny($filterAny);

        return $Locations;
    }

    public function getAreLocations()

    {
        return self::getLocations();
    }

    public function getAllCategories()
    {
        return LocationCategory::get();
    }

    public static function getPageCategories($id = null)

    {
        if ($id) {
            if ($locator = self::get()->byID($id)) {
                return $locator->Categories();
            }

            return false;
        }

        return false;
    }

    public static function locations(
        $filter = array(),
        $filterAny = array(),
        $exclude = array(),
        $filterByCallback = null
    ) {

        $locationsList = ArrayList::create();

        $locations = Location::get()->filter($filter);

        if (!empty($filterAny)) {
            $locations = $locations->filterAny($filterAny);
        }
        if (!empty($exclude)) {
            $locations = $locations->exclude($exclude);
        }

        if ($filterByCallback !== null && is_callable($filterByCallback)) {
            $locations = $locations->filterByCallback($filterByCallback);
        }

        if ($locations->exists()) {
            $locationsList->merge($locations);
        }


        return $locationsList;
    }
}

class Locator_Controller extends Page_Controller

{
    // allowed actions
    private static $allowed_actions = array(

        'xml',
        'LocationSearch',
    );

    // Set Requirements based on input from CMS
    public function init()
    {
        parent::init();

        $themeDir = SSViewer::get_theme_folder();

        Requirements::javascript('framework/thirdparty/jquery/jquery.js');
        if (Locator::getLocations()) {
            Requirements::javascript('http://maps.google.com/maps/api/js?sensor=false');
            Requirements::javascript('locator/thirdparty/handlebars/handlebars-v1.3.0.js');
            Requirements::javascript('locator/thirdparty/jquery-store-locator/js/jquery.storelocator.js');
        }

        Requirements::css('locator/css/map.css');

        $featured = (Locator::getLocations(array('Featured' => 1))->count() > 0) ?
            'featuredLocations: true' :
            'featuredLocations: false';

        // map config based on user input in Settings tab
        // AutoGeocode or Full Map
        $load = ($this->data()->AutoGeocode) ?
            'autoGeocode: true, fullMapStart: false,' :
            'autoGeocode: false, fullMapStart: true, storeLimit: 1000, maxDistance: true,';

        $base = Director::baseFolder();
        $themePath = $base.'/'.$themeDir;

        $listTemplatePath = (file_exists($themePath.'/templates/location-list-description.html')) ?
            $themeDir.'/templates/location-list-description.html' :
            'locator/templates/location-list-description.html';
        $infowindowTemplatePath = (file_exists($themePath.'/templates/infowindow-description.html')) ?
            $themeDir.'/templates/infowindow-description.html' :
            'locator/templates/infowindow-description.html';

        // in page or modal
        $modal = ($this->data()->ModalWindow) ? 'modalWindow: true' : 'modalWindow: false';

        $kilometer = ($this->data()->Unit == 'km') ? 'lengthUnit: "km"' : 'lengthUnit: "m"';

        $vars = $this->request->getVars();
        unset($vars['url']);

        $url = '';
        if (count($vars)) {
            $url .= '?' . http_build_query($vars);
        }
        $link = $this->Link().'xml.xml'.$url;

        // init map
        if (Locator::getLocations()) {
            Requirements::customScript("
                $(function($) {
                    $('#map-container').storeLocator({
                        ".$load."
                        dataLocation: '".$link."',
                        listTemplatePath: '".$listTemplatePath."',
                        infowindowTemplatePath: '".$infowindowTemplatePath."',
                        originMarker: true,
                        ".$modal.',
                        '.$featured.",
                        slideMap: false,
                        zoomLevel: 0,
                        distanceAlert: 120,
                        noForm: true,
                        formID: 'Form_LocationSearch',
                        inputID: 'Form_LocationSearch_address',
                        categoryID: 'Form_LocationSearch_category',
                        distanceAlert: -1,
                        ".$kilometer.'
                    });
                });
            ');
        }
    }

    /**
     * @param SS_HTTPRequest $request
     * @return ViewableData_Customised
     */
    public function index(SS_HTTPRequest $request)
    {
        $locations = $this->Items($request);

        return $this->customise(array(
            'Locations' => $locations
        ));
    }



    /**
     * @param array $searchCriteria
     * @return mixed
     */
    public function Items($searchCriteria = array())
    {
        $request = ($this->request) ? $this->request : $this->parentController->getRequest();
        if(empty($searchCriteria)) $searchCriteria = $request->requestVars();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $filter = array();
        $filterAny = array();
        $exclude = array();

        $address = ($request->getVar('Address')) ? $request->getVar('Address') : false;
        if ($address) {
            $filterAny['Address:PartialMatch'] = $address;
            $filterAny['Suburb:PartialMatch'] = $address;
            $filterAny['State:PartialMatch'] = $address;
            $filterAny['Postcode:PartialMatch'] = $address;
            $filterAny['Country:PartialMatch'] = $address;
        }

        $category = ($request->getVar('CategoryID')) ? $request->getVar('CategoryID') : false;
        if ($category) {
            $filter['CategoryID'] = $category;
        }

        $locations = Locator::locations($filter, $filterAny, $exclude);

        return $locations;
    }

    /**
     * Find all locations for map.
     *
     * Will return a XML feed of all locations marked "show in locator".
     *
     * @return XML file
     *
     * @todo rename/refactor to allow for json/xml
     * @todo allow $filter to run off of getVars key/val pair
     */
    public function xml(SS_HTTPRequest $request)
    {
        $locations = $this->Items($request);

        return $this->customise(array(
            'Locations' => $locations,
        ))->renderWith('LocationXML');
    }

    /**
     * LocationSearch form.
     *
     * Search form for locations, updates map and results list via AJAX
     *
     * @return Form
     */
    public function LocationSearch()
    {
        $fields = FieldList::create(
            $address = TextField::create('Address', '')
                ->setAttribute('placeholder', 'address or zip code')
        );

        $locatorCategories = Locator::getPageCategories($this->ID);

        if (LocationCategory::get()->Count() > 0 && $locatorCategories && $locatorCategories->Count() != 1) {

            $ct = $locatorCategories->Count();

            if ($ct > 0) {
                $categories = $locatorCategories;
            } else {
                $categories = LocationCategory::get();
            }

            if ($categories->count() > 0) {
                $fields->push(
                    DropdownField::create(
                        'CategoryID',
                        '',
                        $categories->map()
                    )->setEmptyString('Select Category'));
            }
        }

        $actions = FieldList::create(
            FormAction::create('doSearch', 'Search')
        );

        return Form::create($this, 'LocationSearch', $fields, $actions)
            ->setFormMethod('GET')
            ->setFormAction($this->Link())
            ->disableSecurityToken()
            ->loadDataFrom($this->request->getVars())
        ;
    }

    // Results filtered by query
    function doSearch($data, $form, $request)

    {
        if (isset($data['location'])) {
            $location = $data['location'];
            $data['Address'] = $location;
            $data['Suburb'] = $location;
            $data['State'] = $location;
            $data['Postcode'] = $location;
            $data['Country'] = $location;
        }
        return $this->render(array(
            'Items' => $this->Items($data),
            'AdvSearchForm' => $form
        ));
    }
}


1		<?php
2
3		class Locator extends Page
4		{
5		private static $db = array(
		1 ignored issue – show Unused Code introduced 2016-03-15 20:52 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6		'AutoGeocode' => 'Boolean',
7		'ModalWindow' => 'Boolean',
8		'Unit' => 'Enum("m,km","m")',
9		);
10
11		private static $many_many = array(
		1 ignored issue – show Unused Code introduced 2016-03-16 01:12 UTC by Report Bug Copy Issue Report The property `$many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12		'Categories' => 'LocationCategory',
13		);
14
15		private static $defaults = array(
		1 ignored issue – show Unused Code introduced 2016-03-15 20:52 UTC by Report Bug Copy Issue Report The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16		'AutoGeocode' => true,
17		);
18
19	1	private static $singular_name = 'Locator';
		1 ignored issue – show Unused Code introduced 2016-03-15 21:20 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20		private static $plural_name = 'Locators';
		1 ignored issue – show Unused Code introduced 2016-03-15 21:20 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21	1	private static $description = 'Find locations on a map';
		1 ignored issue – show Unused Code introduced 2016-03-15 20:52 UTC by Report Bug Copy Issue Report The property `$description` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22
23		public function getCMSFields()
		0 ignored issues – show Documentation introduced 2016-04-07 19:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
24	1	{
25	1	$fields = parent::getCMSFields();
26	1
27		// Settings
28		$fields->addFieldsToTab('Root.Settings', array(
29	1	HeaderField::create('DisplayOptions', 'Display Options', 3),
30	1	OptionsetField::create('Unit', 'Unit of measure', array('m' => 'Miles', 'km' => 'Kilometers')),
31		CheckboxField::create('AutoGeocode', 'Auto Geocode - Automatically filter map results based on user location')
32		->setDescription('Note: if any locations are set as featured, the auto geocode is automatically disabled.'),
33	1	CheckboxField::create('ModalWindow', 'Modal Window - Show Map results in a modal window'),
34	1	));
35	1
36	1	// Filter categories
37	1	$config = GridFieldConfig_RelationEditor::create();
38	1	if (class_exists('GridFieldAddExistingSearchButton')) {
39	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
40		$config->addComponent(new GridFieldAddExistingSearchButton());
41	1	}
42		$categories = $this->Categories();
43	1	$categoriesField = GridField::create('Categories', 'Categories', $categories, $config)
44		->setDescription('only show locations from the selected category');
45
46	3	// Filter
47		$fields->addFieldsToTab('Root.Filter', array(
48	3	HeaderField::create('CategoryOptionsHeader', 'Location Filtering', 3),
49		$categoriesField,
50	3	));
51	3
52	3	$this->extend('updateCMSFields', $fields);
53	3
54		return $fields;
55		}
56	1
57		public static function getLocations($filter = array(), $exclude = array(), $filterAny = array())
		0 ignored issues – show Documentation introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
58	1	{
59		$filter['ShowInLocator'] = true;
60		$exclude['Lat'] = 0;
61	1
62		$Locations = Location::get()->exclude($exclude)->filter($filter)->filterAny($filterAny);
63	1
64		return $Locations;
65		}
66
67		public function getAreLocations()
		0 ignored issues – show Documentation introduced 2016-04-07 19:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
68		{
69		return self::getLocations();
70		}
71
72		public function getAllCategories()
73		{
74		return LocationCategory::get();
75		}
76
77		public static function getPageCategories($id = null)
		0 ignored issues – show Documentation introduced 2016-04-07 19:34 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
78		{
79		if ($id) {
80		if ($locator = self::get()->byID($id)) {
81		return $locator->Categories();
82		}
83
84		return false;
85		}
86
87		return false;
88		}
89
90		public static function locations(
91		$filter = array(),
92		$filterAny = array(),
93		$exclude = array(),
94		$filterByCallback = null
95		) {
96
97		$locationsList = ArrayList::create();
98
99		$locations = Location::get()->filter($filter);
100
101		if (!empty($filterAny)) {
102		$locations = $locations->filterAny($filterAny);
103		}
104		if (!empty($exclude)) {
105		$locations = $locations->exclude($exclude);
106		}
107
108		if ($filterByCallback !== null && is_callable($filterByCallback)) {
109		$locations = $locations->filterByCallback($filterByCallback);
110		}
111
112		if ($locations->exists()) {
113		$locationsList->merge($locations);
114		}
115
116
117		return $locationsList;
118		}
119		}
120
121		class Locator_Controller extends Page_Controller
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-15 20:52 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
122		{
123		// allowed actions
124		private static $allowed_actions = array(
		1 ignored issue – show Unused Code introduced 2016-03-15 20:52 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
125		'xml',
126		'LocationSearch',
127		);
128
129		// Set Requirements based on input from CMS
130		public function init()
131		{
132		parent::init();
133
134		$themeDir = SSViewer::get_theme_folder();
135
136		Requirements::javascript('framework/thirdparty/jquery/jquery.js');
137		if (Locator::getLocations()) {
138		Requirements::javascript('http://maps.google.com/maps/api/js?sensor=false');
139		Requirements::javascript('locator/thirdparty/handlebars/handlebars-v1.3.0.js');
140		Requirements::javascript('locator/thirdparty/jquery-store-locator/js/jquery.storelocator.js');
141		}
142
143		Requirements::css('locator/css/map.css');
144
145		$featured = (Locator::getLocations(array('Featured' => 1))->count() > 0) ?
146		'featuredLocations: true' :
147		'featuredLocations: false';
148
149		// map config based on user input in Settings tab
150		// AutoGeocode or Full Map
151		$load = ($this->data()->AutoGeocode) ?
152		'autoGeocode: true, fullMapStart: false,' :
153		'autoGeocode: false, fullMapStart: true, storeLimit: 1000, maxDistance: true,';
154
155		$base = Director::baseFolder();
156		$themePath = $base.'/'.$themeDir;
157
158		$listTemplatePath = (file_exists($themePath.'/templates/location-list-description.html')) ?
159		$themeDir.'/templates/location-list-description.html' :
160		'locator/templates/location-list-description.html';
161		$infowindowTemplatePath = (file_exists($themePath.'/templates/infowindow-description.html')) ?
162		$themeDir.'/templates/infowindow-description.html' :
163		'locator/templates/infowindow-description.html';
164
165		// in page or modal
166		$modal = ($this->data()->ModalWindow) ? 'modalWindow: true' : 'modalWindow: false';
167
168	1	$kilometer = ($this->data()->Unit == 'km') ? 'lengthUnit: "km"' : 'lengthUnit: "m"';
169
170	1	$vars = $this->request->getVars();
171	1	unset($vars['url']);
172	1
173	1	$url = '';
174		if (count($vars)) {
175	1	$url .= '?' . http_build_query($vars);
176	1	}
177	1	$link = $this->Link().'xml.xml'.$url;
178	1
179		// init map
180	1	if (Locator::getLocations()) {
181		Requirements::customScript("
182	1	$(function($) {
183		$('#map-container').storeLocator({
184	1	".$load."
185		dataLocation: '".$link."',
186		listTemplatePath: '".$listTemplatePath."',
187		infowindowTemplatePath: '".$infowindowTemplatePath."',
188		originMarker: true,
189		".$modal.',
190		'.$featured.",
191		slideMap: false,
192	1	zoomLevel: 0,
193		distanceAlert: 120,
194	1	noForm: true,
195	1	formID: 'Form_LocationSearch',
196	1	inputID: 'Form_LocationSearch_address',
197		categoryID: 'Form_LocationSearch_category',
198	1	distanceAlert: -1,
199		".$kilometer.'
200		});
201	1	});
202		');
203		}
204		}
205
206		/**
207		* @param SS_HTTPRequest $request
208		* @return ViewableData_Customised
209		*/
210		public function index(SS_HTTPRequest $request)
211		{
212		$locations = $this->Items($request);
213
214		return $this->customise(array(
215		'Locations' => $locations
216		));
217		}
218
219
220
221		/**
222		* @param array $searchCriteria
223		* @return mixed
224		*/
225		public function Items($searchCriteria = array())
226		{
227		$request = ($this->request) ? $this->request : $this->parentController->getRequest();
228		if(empty($searchCriteria)) $searchCriteria = $request->requestVars();
		0 ignored issues – show Unused Code introduced 2016-04-08 21:24 UTC by Report Bug Copy Issue Report `$searchCriteria` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
229
230		$filter = array();
231		$filterAny = array();
232		$exclude = array();
233
234		$address = ($request->getVar('Address')) ? $request->getVar('Address') : false;
235		if ($address) {
236		$filterAny['Address:PartialMatch'] = $address;
237		$filterAny['Suburb:PartialMatch'] = $address;
238		$filterAny['State:PartialMatch'] = $address;
239		$filterAny['Postcode:PartialMatch'] = $address;
240		$filterAny['Country:PartialMatch'] = $address;
241		}
242
243		$category = ($request->getVar('CategoryID')) ? $request->getVar('CategoryID') : false;
244		if ($category) {
245		$filter['CategoryID'] = $category;
246		}
247
248		$locations = Locator::locations($filter, $filterAny, $exclude);
249
250		return $locations;
251		}
252
253		/**
254		* Find all locations for map.
255		*
256		* Will return a XML feed of all locations marked "show in locator".
257		*
258		* @return XML file
259		*
260		* @todo rename/refactor to allow for json/xml
261		* @todo allow $filter to run off of getVars key/val pair
262		*/
263		public function xml(SS_HTTPRequest $request)
264		{
265		$locations = $this->Items($request);
266
267		return $this->customise(array(
268		'Locations' => $locations,
269		))->renderWith('LocationXML');
270		}
271
272		/**
273		* LocationSearch form.
274		*
275		* Search form for locations, updates map and results list via AJAX
276		*
277		* @return Form
278		*/
279		public function LocationSearch()
280		{
281		$fields = FieldList::create(
282		$address = TextField::create('Address', '')
283		->setAttribute('placeholder', 'address or zip code')
284		);
285
286		$locatorCategories = Locator::getPageCategories($this->ID);
287
288		if (LocationCategory::get()->Count() > 0 && $locatorCategories && $locatorCategories->Count() != 1) {
289
290		$ct = $locatorCategories->Count();
291
292		if ($ct > 0) {
293		$categories = $locatorCategories;
294		} else {
295		$categories = LocationCategory::get();
296		}
297
298		if ($categories->count() > 0) {
299		$fields->push(
300		DropdownField::create(
301		'CategoryID',
302		'',
303		$categories->map()
304		)->setEmptyString('Select Category'));
305		}
306		}
307
308		$actions = FieldList::create(
309		FormAction::create('doSearch', 'Search')
310		);
311
312		return Form::create($this, 'LocationSearch', $fields, $actions)
313		->setFormMethod('GET')
314		->setFormAction($this->Link())
315		->disableSecurityToken()
316		->loadDataFrom($this->request->getVars())
317		;
318		}
319
320		// Results filtered by query
321		function doSearch($data, $form, $request)
		0 ignored issues – show Documentation introduced 2016-04-08 20:08 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Best Practice introduced 2016-04-08 20:08 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
322		{
323		if (isset($data['location'])) {
324		$location = $data['location'];
325		$data['Address'] = $location;
326		$data['Suburb'] = $location;
327		$data['State'] = $location;
328		$data['Postcode'] = $location;
329		$data['Country'] = $location;
330		}
331		return $this->render(array(
332		'Items' => $this->Items($data),
333		'AdvSearchForm' => $form
334		));
335		}
336		}
337

dynamic / silverstripe-locator

Pull Request — master (#88)

Locator_Controller::doSearch() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like