dynamic / silverstripe-locator-frontend-react

src/Extensions/LocationExtension.php

<?php

namespace Dynamic\Locator\React\Extensions;

use Dynamic\Locator\Location;
use SilverStripe\AssetAdmin\Forms\UploadField;
use SilverStripe\Assets\Image;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldSortableHeader;
use SilverStripe\ORM\DataExtension;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;
use Symbiote\GridFieldExtensions\GridFieldTitleHeader;

/**
 * Class LocationExtension
 * @package Dynamic\Locator\React\Extensions
 *
 * @property int MarkerIconImageID
 * @method Image MarkerIconImage()
 *
 * @property-read Location|LocationExtension $owner
 */
class LocationExtension extends DataExtension
{

    /**
     * @var array
     */
    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'MarkerIconImage' => Image::class,
    ];

    /**
     * @var array
     */
    private static $owns = [

The private property $owns is not used, and could be removed.

        'MarkerIconImage',
    ];

    /**
     * @var array
     */
    private static $many_many_extraFields = [

The private property $many_many_extraFields is not used, and could be removed.

        'Categories' => [
            'Sort' => 'Int',
        ],
    ];

    /**
     * @param FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        parent::updateCMSFields($fields);

        if ($this->owner->ID) {

The property ID does not exist on Dynamic\Locator\React\Extensions\LocationExtension. Did you maybe forget to declare it?

            /** @var GridField $categoryField */
            $categoryField = $fields->dataFieldByName('Categories');
            $categoryField->getConfig()->removeComponentsByType([
                GridFieldSortableHeader::class,
            ])->addComponents([
                new GridFieldOrderableRows(),
                new GridFieldTitleHeader(),
            ]);
        }
    }

    /**
     * @return Image|string
     */
    public function getMarkerIcon()
    {
        if ($this->owner->MarkerIconImageID) {
            return $this->owner->MarkerIconImage()->getURL();
        }

        if ($this->owner->Categories()->count()) {

The method Categories() does not exist on Dynamic\Locator\React\Extensions\LocationExtension.

            $icon = $this->owner->Categories()->sort('Sort')->first()->MarkerIconImage();
            return $icon->getURL();
        }

        $imageURL = '';
        $this->owner->extend('updateMarkerIconURL', $imageURL);

The method extend() does not exist on Dynamic\Locator\React\Extensions\LocationExtension.

        return $imageURL;
    }

    /**
     * @return array
     */
    public function getCategoryData($json = true)
    {
        if ($this->owner->Categories()->count()) {
            $names = $this->owner->Categories()->map('ID', 'Name')->toArray();
            return $json ? json_encode($names) : $names;

The expression return $json ? json_encode($names) : $names also could return the type string which is incompatible with the documented return type array.

        }
        return $json ? json_encode([]) : [];

The expression return $json ? json_encode(array()) : array() also could return the type string which is incompatible with the documented return type array.

    }
}