dynamic / silverstripe-jobs

src/Controller/JobController.php

<?php

namespace Dynamic\Jobs\Page;

use Dynamic\Jobs\Model\JobSubmission;
use PageController;
use SilverStripe\Control\Controller;
use SilverStripe\Control\Email\Email;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FileField;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\HiddenField;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\Forms\RequiredFields;
use SilverStripe\View\ArrayData;
use SilverStripe\View\ViewableData_Customised;

/**
 * Class JobController
 * @package Dynamic\Jobs\Model
 */
class JobController extends PageController
{
    /**
     * @var array
     */
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'apply',
        'JobApp',
        'complete',
    ];

    /**
     * @return ViewableData_Customised
     */
    public function apply()
    {
        $Form = $this->JobApp();

        $Form->Fields()->insertBefore(
            ReadonlyField::create(
                'PositionName',
                'Position',
                $this->getTitle()

The method getTitle() does not exist on Dynamic\Jobs\Page\JobController. Since you implemented __call, consider adding a @method annotation.

            ),
            'FirstName'

'FirstName' of type string is incompatible with the type SilverStripe\Forms\FormField expected by parameter $item of SilverStripe\Forms\FieldList::insertBefore().

        );
        $Form->Fields()->push(HiddenField::create('JobID', 'JobID', $this->ID));

        $page = $this->customise([
            'Form' => $Form,
        ]);

        return $page;
    }

    /**
     * @return Form
     */
    public function JobApp()
    {
        $App = singleton(JobSubmission::class);

        $fields = $App->getFrontEndFields();

        $actions = FieldList::create(
            new FormAction('doApply', 'Apply')
        );

        $required = new RequiredFields([
            'FirstName',
            'LastName',
            'Email',
            'Phone',
        ]);


        return Form::create($this, "JobApp", $fields, $actions, $required);
    }

    /**
     * @param $data
     * @param $form
     */
    public function doApply(array $data, Form $form)

The parameter $data is not used and could be removed.

    {
        $entry = new JobSubmission();
        $form->saveInto($entry);

        $entry->JobID = $this->ID;

The property JobID does not exist on Dynamic\Jobs\Model\JobSubmission. Since you implemented __set, consider adding a @property annotation.

        // adds relation to uploaded file
        /** @var FileField $fileField */
        $fileField = $form->Fields()->fieldByName('Resume');

Are you sure the assignment to $fileField is correct as $form->Fields()->fieldByName('Resume') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        if ($fileField !== null) {
            $file = $fileField->getUpload()->getFile();
            if ($file !== null && $file->exists()) {
                $file->ShowInSearch = 0;

Accessing ShowInSearch on the interface SilverStripe\Assets\Storage\AssetContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

                $file->write();
                $entry->ResumeID = $file->ID;

Accessing ID on the interface SilverStripe\Assets\Storage\AssetContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

The property ResumeID does not exist on Dynamic\Jobs\Model\JobSubmission. Since you implemented __set, consider adding a @property annotation.

            }
        }

        if ($entry->write()) {
            $to = $this->parent()->EmailRecipient;

The method parent() does not exist on Dynamic\Jobs\Page\JobController. Since you implemented __call, consider adding a @method annotation.

            $from = $this->parent()->FromAddress;
            $subject = $this->parent()->EmailSubject;
            $body = $this->parent()->EmailMessage;

            $email = new Email($from, $to, $subject, $body);
            $email
                ->setHTMLTemplate('Dynamic\Jobs\Email\JobSubmission')
                ->setData(new ArrayData(array(
                    'Submission' => JobSubmission::get()->byID($entry->ID),
                    'Configuration' => $this->parent(),
                )));

            $email->send();

            $this->redirect(Controller::join_links($this->Link(), 'complete'));
        }
    }

    /**
     * @return ViewableData_Customised
     */
    public function complete()
    {
        return $this->customise([]);
    }
}