JobTest::testCanEdit() - Code Metrics - Inspection of "add lumberjack, update namespaces (#7)" - dynamic/silverstripe-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 05e846...9de07a )

by Jason

created 2019-02-10 02:20 UTC

JobTest::testCanEdit() A

↳ Parent: JobTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	0
dl	0
loc	16
rs	9.9
c	0
b	0
f	0

<?php

namespace Dynamic\Jobs\Test\Page;

use Dynamic\Jobs\Page\Job;
use Dynamic\Jobs\Page\JobCollection;
use SilverStripe\Assets\File;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\FieldList;
use SilverStripe\Security\Member;

/**
 * Class JobTest
 * @package Dynamic\Jobs\Tests
 */
class JobTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = '../fixtures.yml';

    /**
     * Tests populateDefaults()
     */
    public function testPopulateDefaults()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);
        $object->populateDefaults();
        $this->assertEquals(date('Y-m-d'), $object->PostDate);
    }

    /**
     * Tests getCMSFields()
     */
    public function testGetCMSFields()
    {
        /** @var Job $object */
        $object = $this->objFromFixture(Job::class, 'one');
        $fields = $object->getCMSFields();
        $this->assertInstanceOf(FieldList::class, $fields);
    }

    /**
     * Tests getApplyButton()
     */
    public function testGetApplyButton()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);
        $this->assertStringEndsWith('apply', $object->getApplyButton());
    }

    /**
     * Tests getApplicationLink()
     */
    public function testGetApplicationLink()
    {
        /** @var Job $object */
        $object = $this->objFromFixture(Job::class, 'one');
        /** @var JobCollection $parent */
        $parent = $this->objFromFixture(JobCollection::class, 'default');

        $object->ParentID = $parent->ID;

        $object->write();

        $this->assertFalse($object->getApplicationLink());

        // TODO - fix this part
        /** @var File $file */
        $file = $this->objFromFixture(File::class, 'File');

        $parent->ApplicationID = $file->ID;

        $parent->write();

        // print_r($file->ID);

        // print_r($object->parent()->Application()->ID);


        // $this->assertEquals($file->URL, $object->getApplicationLink());

    }

    /**
     * Tests providePermissions()
     */
    public function testProvidePermissions()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);
        $perms = [
            'Job_EDIT' => 'Edit a Job',
            'Job_DELETE' => 'Delete a Job',
            'Job_CREATE' => 'Create a Job',
        ];
        $this->assertEquals($perms, $object->providePermissions());
    }

    /**
     * Tests canCreate()
     */
    public function testCanCreate()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);

        $admin = $this->objFromFixture(Member::class, 'Admin');
        $create = $this->objFromFixture(Member::class, 'Create');
        $edit = $this->objFromFixture(Member::class, 'Edit');
        $delete = $this->objFromFixture(Member::class, 'Delete');
        $visitor = $this->objFromFixture(Member::class, 'Visitor');

        $this->assertTrue($object->canCreate($admin));
        $this->assertTrue($object->canCreate($create));
        $this->assertFalse($object->canCreate($edit));
        $this->assertFalse($object->canCreate($delete));
        $this->assertFalse($object->canCreate($visitor));
    }

    /**
     * Tests canEdit()
     */
    public function testCanEdit()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);

        $admin = $this->objFromFixture(Member::class, 'Admin');
        $create = $this->objFromFixture(Member::class, 'Create');
        $edit = $this->objFromFixture(Member::class, 'Edit');
        $delete = $this->objFromFixture(Member::class, 'Delete');
        $visitor = $this->objFromFixture(Member::class, 'Visitor');

        $this->assertTrue($object->canEdit($admin));
        $this->assertFalse($object->canEdit($create));
        $this->assertTrue($object->canEdit($edit));
        $this->assertFalse($object->canEdit($delete));
        $this->assertFalse($object->canEdit($visitor));
    }

    /**
     * Tests canDelete()
     */
    public function testCanDelete()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);

        $admin = $this->objFromFixture(Member::class, 'Admin');
        $create = $this->objFromFixture(Member::class, 'Create');
        $edit = $this->objFromFixture(Member::class, 'Edit');
        $delete = $this->objFromFixture(Member::class, 'Delete');
        $visitor = $this->objFromFixture(Member::class, 'Visitor');

        $this->assertTrue($object->canDelete($admin));
        $this->assertFalse($object->canDelete($create));
        $this->assertFalse($object->canDelete($edit));
        $this->assertTrue($object->canDelete($delete));
        $this->assertFalse($object->canDelete($visitor));
    }

    /**
     * Tests canView()
     */
    public function testCanView()
    {
        /** @var Job $object */
        $object = Injector::inst()->create(Job::class);
        $this->assertTrue($object->canView());
    }
}


1			<?php
2
3			namespace Dynamic\Jobs\Test\Page;
4
5			use Dynamic\Jobs\Page\Job;
6			use Dynamic\Jobs\Page\JobCollection;
7			use SilverStripe\Assets\File;
8			use SilverStripe\Core\Injector\Injector;
9			use SilverStripe\Dev\SapphireTest;
10			use SilverStripe\Forms\FieldList;
11			use SilverStripe\Security\Member;
12
13			/**
14			* Class JobTest
15			* @package Dynamic\Jobs\Tests
16			*/
17			class JobTest extends SapphireTest
18			{
19			/**
20			* @var string
21			*/
22			protected static $fixture_file = '../fixtures.yml';
23
24			/**
25			* Tests populateDefaults()
26			*/
27			public function testPopulateDefaults()
28			{
29			/** @var Job $object */
30			$object = Injector::inst()->create(Job::class);
31			$object->populateDefaults();
32			$this->assertEquals(date('Y-m-d'), $object->PostDate);
33			}
34
35			/**
36			* Tests getCMSFields()
37			*/
38			public function testGetCMSFields()
39			{
40			/** @var Job $object */
41			$object = $this->objFromFixture(Job::class, 'one');
42			$fields = $object->getCMSFields();
43			$this->assertInstanceOf(FieldList::class, $fields);
44			}
45
46			/**
47			* Tests getApplyButton()
48			*/
49			public function testGetApplyButton()
50			{
51			/** @var Job $object */
52			$object = Injector::inst()->create(Job::class);
53			$this->assertStringEndsWith('apply', $object->getApplyButton());
54			}
55
56			/**
57			* Tests getApplicationLink()
58			*/
59			public function testGetApplicationLink()
60			{
61			/** @var Job $object */
62			$object = $this->objFromFixture(Job::class, 'one');
63			/** @var JobCollection $parent */
64			$parent = $this->objFromFixture(JobCollection::class, 'default');
65
66			$object->ParentID = $parent->ID;
			0 ignored issues – show Bug Best Practice introduced 2018-02-08 21:24 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
67			$object->write();
68
69			$this->assertFalse($object->getApplicationLink());
70
71			// TODO - fix this part
72			/** @var File $file */
73			$file = $this->objFromFixture(File::class, 'File');
74
75			$parent->ApplicationID = $file->ID;
			0 ignored issues – show Bug Best Practice introduced 2019-02-10 02:13 UTC by Report Bug Copy Issue Report The property `ApplicationID` does not exist on `Dynamic\Jobs\Page\JobCollection`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
76			$parent->write();
77
78			// print_r($file->ID);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-14 20:45 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79			// print_r($object->parent()->Application()->ID);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-14 20:45 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
80
81			// $this->assertEquals($file->URL, $object->getApplicationLink());
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-14 20:45 UTC by Report Bug Copy Issue Report `71%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
82			}
83
84			/**
85			* Tests providePermissions()
86			*/
87			public function testProvidePermissions()
88			{
89			/** @var Job $object */
90			$object = Injector::inst()->create(Job::class);
91			$perms = [
92			'Job_EDIT' => 'Edit a Job',
93			'Job_DELETE' => 'Delete a Job',
94			'Job_CREATE' => 'Create a Job',
95			];
96			$this->assertEquals($perms, $object->providePermissions());
97			}
98
99			/**
100			* Tests canCreate()
101			*/
102			public function testCanCreate()
103			{
104			/** @var Job $object */
105			$object = Injector::inst()->create(Job::class);
106
107			$admin = $this->objFromFixture(Member::class, 'Admin');
108			$create = $this->objFromFixture(Member::class, 'Create');
109			$edit = $this->objFromFixture(Member::class, 'Edit');
110			$delete = $this->objFromFixture(Member::class, 'Delete');
111			$visitor = $this->objFromFixture(Member::class, 'Visitor');
112
113			$this->assertTrue($object->canCreate($admin));
114			$this->assertTrue($object->canCreate($create));
115			$this->assertFalse($object->canCreate($edit));
116			$this->assertFalse($object->canCreate($delete));
117			$this->assertFalse($object->canCreate($visitor));
118			}
119
120			/**
121			* Tests canEdit()
122			*/
123			public function testCanEdit()
124			{
125			/** @var Job $object */
126			$object = Injector::inst()->create(Job::class);
127
128			$admin = $this->objFromFixture(Member::class, 'Admin');
129			$create = $this->objFromFixture(Member::class, 'Create');
130			$edit = $this->objFromFixture(Member::class, 'Edit');
131			$delete = $this->objFromFixture(Member::class, 'Delete');
132			$visitor = $this->objFromFixture(Member::class, 'Visitor');
133
134			$this->assertTrue($object->canEdit($admin));
135			$this->assertFalse($object->canEdit($create));
136			$this->assertTrue($object->canEdit($edit));
137			$this->assertFalse($object->canEdit($delete));
138			$this->assertFalse($object->canEdit($visitor));
139			}
140
141			/**
142			* Tests canDelete()
143			*/
144			public function testCanDelete()
145			{
146			/** @var Job $object */
147			$object = Injector::inst()->create(Job::class);
148
149			$admin = $this->objFromFixture(Member::class, 'Admin');
150			$create = $this->objFromFixture(Member::class, 'Create');
151			$edit = $this->objFromFixture(Member::class, 'Edit');
152			$delete = $this->objFromFixture(Member::class, 'Delete');
153			$visitor = $this->objFromFixture(Member::class, 'Visitor');
154
155			$this->assertTrue($object->canDelete($admin));
156			$this->assertFalse($object->canDelete($create));
157			$this->assertFalse($object->canDelete($edit));
158			$this->assertTrue($object->canDelete($delete));
159			$this->assertFalse($object->canDelete($visitor));
160			}
161
162			/**
163			* Tests canView()
164			*/
165			public function testCanView()
166			{
167			/** @var Job $object */
168			$object = Injector::inst()->create(Job::class);
169			$this->assertTrue($object->canView());
170			}
171			}
172

dynamic / silverstripe-jobs

Push — master ( 05e846...9de07a )

JobTest::testCanEdit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like