ImageUploadFieldTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	test__construct()	0	5	1
A	testMaxUpload()	0	6	1
A	testExtendedField()	0	11	1

<?php

/**
 * Class ImageUploadFieldTest
 */
class ImageUploadFieldTest extends SapphireTest
{

    /**
     *
     */
    public function test__construct()

Method name "ImageUploadFieldTest::test__construct" is not in camel caps format

    {
        $field = new ImageUploadField('Image');
        $this->assertInstanceOf('UploadField', $field);

The method assertInstanceOf() does not seem to exist on object<ImageUploadFieldTest>.

    }

    /**
     *
     */
    public function testMaxUpload()
    {
        $this->assertEquals(Config::inst()->get('ImageUploadField', 'max_upload'), 1024000);

The method assertEquals() does not seem to exist on object<ImageUploadFieldTest>.

        Config::inst()->update('ImageUploadField', 'max_upload', 512000);
        $this->assertEquals(Config::inst()->get('ImageUploadField', 'max_upload'), 512000);

The method assertEquals() does not seem to exist on object<ImageUploadFieldTest>.

    }

    /**
     *
     */
    public function testExtendedField()
    {

        $imageField = new CustomImageUploadField('testImageField');
        $this->assertEquals($imageField->getValidator()->getAllowedMaxFileSize(), 512000);

The method assertEquals() does not seem to exist on object<ImageUploadFieldTest>.

        Config::inst()->update('CustomImageUploadField', 'max_upload', 256000);
        $imageField2 = new CustomImageUploadField('testImageField2');
        $this->assertEquals($imageField2->getValidator()->getAllowedMaxFileSize(), 256000);

The method assertEquals() does not seem to exist on object<ImageUploadFieldTest>.

    }

}

/**
 * Class CustomImageUploadField
 */
class CustomImageUploadField extends ImageUploadField implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

{

    /**
     * @var int
     */
    private static $max_upload = 512000;

The property $max_upload is not used and could be removed.

}