Total Complexity | 40 |
Total Lines | 359 |
Duplicated Lines | 0 % |
Changes | 5 | ||
Bugs | 0 | Features | 0 |
Complex classes like ProductOption often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ProductOption, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
38 | class ProductOption extends DataObject |
||
39 | { |
||
40 | /** |
||
41 | * @var array |
||
42 | */ |
||
43 | private static $db = [ |
||
44 | 'Title' => 'Varchar(255)', |
||
45 | ]; |
||
46 | |||
47 | /** |
||
48 | * @var string |
||
49 | */ |
||
50 | private static $table_name = 'ProductOption'; |
||
51 | |||
52 | /** |
||
53 | * @var string |
||
54 | */ |
||
55 | private static $singular_name = 'Option'; |
||
56 | |||
57 | /** |
||
58 | * @var string |
||
59 | */ |
||
60 | private static $plural_name = 'Options'; |
||
61 | |||
62 | /** |
||
63 | * @var array |
||
64 | */ |
||
65 | private static $defaults = [ |
||
66 | 'ManyMany[Available]' => true, |
||
67 | ]; |
||
68 | |||
69 | /** |
||
70 | * @var array |
||
71 | */ |
||
72 | private static $summary_fields = [ |
||
73 | 'Title' => 'Title', |
||
74 | 'IsAvailable' => 'Available', |
||
75 | 'OptionType' => 'Type', |
||
76 | ]; |
||
77 | |||
78 | /** |
||
79 | * @return FieldList |
||
80 | */ |
||
81 | public function getCMSFields() |
||
82 | { |
||
83 | $this->beforeUpdateCMSFields(function (FieldList $fields) { |
||
84 | if ($this->exists()) { |
||
85 | $fields->addFieldToTab( |
||
86 | 'Root.Main', |
||
87 | ReadonlyField::create('ManyMany[OptionModifierKey]') |
||
88 | ->setTitle(_t('OptionItem.ModifierKey', 'Modifier Key')) |
||
89 | ); |
||
90 | } |
||
91 | |||
92 | $fields->addFieldsToTab('Root.Main', [ |
||
93 | CheckboxField::create('ManyMany[Available]', 'Available for purchase'), |
||
94 | |||
95 | DropdownField::create('ManyMany[Type]', 'Option Type', OptionType::get()->map()) |
||
96 | ->setEmptyString(''), |
||
97 | |||
98 | // Weight Modifier Fields |
||
99 | HeaderField::create('WeightHD', _t('OptionItem.WeightHD', 'Modify Weight'), 4), |
||
100 | NumericField::create("ManyMany[WeightModifier]") |
||
101 | ->setTitle(_t('OptionItem.WeightModifier', 'Weight')) |
||
102 | ->setScale(3) |
||
103 | ->setDescription(_t( |
||
104 | 'OptionItem.WeightDescription', |
||
105 | 'Only supports up to 3 decimal places' |
||
106 | )), |
||
107 | DropdownField::create( |
||
108 | 'ManyMany[WeightModifierAction]', |
||
109 | _t('OptionItem.WeightModifierAction', 'Weight Modification'), |
||
110 | [ |
||
111 | 'Add' => _t( |
||
112 | 'OptionItem.WeightAdd', |
||
113 | 'Add to Base Weight', |
||
114 | 'Add to weight' |
||
115 | ), |
||
116 | 'Subtract' => _t( |
||
117 | 'OptionItem.WeightSubtract', |
||
118 | 'Subtract from Base Weight', |
||
119 | 'Subtract from weight' |
||
120 | ), |
||
121 | 'Set' => _t('OptionItem.WeightSet', 'Set as a new Weight'), |
||
122 | ] |
||
123 | ) |
||
124 | ->setEmptyString('') |
||
125 | ->setDescription(_t( |
||
126 | 'OptionItem.WeightDescription', |
||
127 | 'Does weight modify or replace base weight?' |
||
128 | )), |
||
129 | |||
130 | // Price Modifier Fields |
||
131 | HeaderField::create('PriceHD', _t('OptionItem.PriceHD', 'Modify Price'), 4), |
||
132 | CurrencyField::create('ManyMany[PriceModifier]') |
||
133 | ->setTitle(_t('OptionItem.PriceModifier', 'Price')), |
||
134 | DropdownField::create( |
||
135 | 'ManyMany[PriceModifierAction]', |
||
136 | _t('OptionItem.PriceModifierAction', 'Price Modification'), |
||
137 | [ |
||
138 | 'Add' => _t( |
||
139 | 'OptionItem.PriceAdd', |
||
140 | 'Add to Base Price', |
||
141 | 'Add to price' |
||
142 | ), |
||
143 | 'Subtract' => _t( |
||
144 | 'OptionItem.PriceSubtract', |
||
145 | 'Subtract from Base Price', |
||
146 | 'Subtract from price' |
||
147 | ), |
||
148 | 'Set' => _t('OptionItem.PriceSet', 'Set as a new Price'), |
||
149 | ] |
||
150 | ) |
||
151 | ->setEmptyString('') |
||
152 | ->setDescription(_t('OptionItem.PriceDescription', 'Does price modify or replace base price?')), |
||
153 | |||
154 | // Code Modifier Fields |
||
155 | HeaderField::create('CodeHD', _t('OptionItem.CodeHD', 'Modify Code'), 4), |
||
156 | TextField::create('ManyMany[CodeModifier]') |
||
157 | ->setTitle(_t('OptionItem.CodeModifier', 'Code')), |
||
158 | DropdownField::create( |
||
159 | 'ManyMany[CodeModifierAction]', |
||
160 | _t('OptionItem.CodeModifierAction', 'Code Modification'), |
||
161 | [ |
||
162 | 'Add' => _t( |
||
163 | 'OptionItem.CodeAdd', |
||
164 | 'Add to Base Code', |
||
165 | 'Add to code' |
||
166 | ), |
||
167 | 'Subtract' => _t( |
||
168 | 'OptionItem.CodeSubtract', |
||
169 | 'Subtract from Base Code', |
||
170 | 'Subtract from code' |
||
171 | ), |
||
172 | 'Set' => _t('OptionItem.CodeSet', 'Set as a new Code'), |
||
173 | ] |
||
174 | ) |
||
175 | ->setEmptyString('') |
||
176 | ->setDescription(_t('OptionItem.CodeDescription', 'Does code modify or replace base code?')), |
||
177 | ]); |
||
178 | }); |
||
179 | |||
180 | return parent::getCMSFields(); |
||
181 | } |
||
182 | |||
183 | /** |
||
184 | * |
||
185 | */ |
||
186 | public function onBeforeWrite() |
||
187 | { |
||
188 | parent::onBeforeWrite(); |
||
189 | |||
190 | $modifierKeyField = 'ManyMany[OptionModifierKey]'; |
||
191 | $this->{$modifierKeyField} = $this->getGeneratedValue(); |
||
192 | |||
193 | $codeModifierField = 'ManyMany[CodeModifier]'; |
||
194 | switch ($this->CodeModifierAction) { |
||
195 | case 'Subtract': |
||
196 | case 'Add': |
||
197 | if ($this->config()->get('trimAllWhitespace') == false) { |
||
198 | // trim the right of the code - some companies use spaces to denote options |
||
199 | $trimmed = rtrim($this->{$codeModifierField}); |
||
200 | // replace duplicate spaces |
||
201 | $this->{$codeModifierField} = preg_replace('/\s+/', ' ', $trimmed); |
||
202 | break; |
||
203 | } |
||
204 | /* falls through */ |
||
205 | case 'Set': |
||
206 | $trimmed = trim($this->{$codeModifierField}); |
||
207 | $this->{$codeModifierField} = preg_replace('/\s+/', ' ', $trimmed); |
||
208 | break; |
||
209 | } |
||
210 | } |
||
211 | |||
212 | /** |
||
213 | * @param $oma |
||
214 | * @param bool $returnWithOnlyPlusMinus |
||
215 | * |
||
216 | * @return string |
||
217 | */ |
||
218 | public static function getOptionModifierActionSymbol($oma, $returnWithOnlyPlusMinus = false) |
||
232 | } |
||
233 | |||
234 | /** |
||
235 | * @return string |
||
236 | */ |
||
237 | public function getWeightModifierWithSymbol() |
||
238 | { |
||
239 | return self::getOptionModifierActionSymbol($this->WeightModifierAction) . $this->WeightModifier; |
||
240 | } |
||
241 | |||
242 | /** |
||
243 | * @return string |
||
244 | */ |
||
245 | public function getPriceModifierWithSymbol() |
||
248 | } |
||
249 | |||
250 | /** |
||
251 | * @return string |
||
252 | */ |
||
253 | public function getCodeModifierWithSymbol() |
||
254 | { |
||
255 | return self::getOptionModifierActionSymbol($this->CodeModifierAction) . $this->CodeModifier; |
||
256 | } |
||
257 | |||
258 | /** |
||
259 | * @return string |
||
260 | */ |
||
261 | public function getGeneratedValue() |
||
262 | { |
||
263 | $modPrice = ($this->PriceModifier) ? (string)$this->PriceModifier : '0'; |
||
264 | $modPriceWithSymbol = self::getOptionModifierActionSymbol($this->PriceModifierAction) . $modPrice; |
||
265 | $modWeight = ($this->WeightModifier) ? (string)$this->WeightModifier : '0'; |
||
266 | $modWeight = self::getOptionModifierActionSymbol($this->WeightModifierAction) . $modWeight; |
||
267 | $modCode = self::getOptionModifierActionSymbol($this->CodeModifierAction) . $this->CodeModifier; |
||
268 | |||
269 | return $this->Title . '{p' . $modPriceWithSymbol . '|w' . $modWeight . '|c' . $modCode . '}'; |
||
270 | } |
||
271 | |||
272 | /** |
||
273 | * @return mixed|string |
||
274 | */ |
||
275 | public function getGeneratedTitle() |
||
276 | { |
||
277 | $modPrice = ($this->PriceModifier) ? (string)$this->PriceModifier : '0'; |
||
278 | $title = $this->Title; |
||
279 | $title .= ($this->PriceModifier != 0) ? |
||
280 | ': (' . self::getOptionModifierActionSymbol( |
||
281 | $this->PriceModifierAction, |
||
282 | $returnWithOnlyPlusMinus = true |
||
283 | ) . '$' . $modPrice . ')' : |
||
284 | ''; |
||
285 | |||
286 | return $title; |
||
287 | } |
||
288 | |||
289 | /** |
||
290 | * @return bool |
||
291 | */ |
||
292 | public function getAvailability() |
||
293 | { |
||
294 | $available = ($this->Available == 1) ? true : false; |
||
295 | $this->extend('updateOptionAvailability', $available); |
||
296 | |||
297 | return $available; |
||
298 | } |
||
299 | |||
300 | /** |
||
301 | * @return string |
||
302 | */ |
||
303 | public function getIsAvailable() |
||
304 | { |
||
305 | $available = DBBoolean::create(); |
||
306 | $available->setValue($this->getAvailability()); |
||
307 | |||
308 | return $available->Nice(); |
||
309 | } |
||
310 | |||
311 | /** |
||
312 | * @return string |
||
313 | */ |
||
314 | public function getOptionType() |
||
315 | { |
||
316 | if ($this->Type) { |
||
317 | $type = OptionType::get()->byID($this->Type); |
||
318 | if ($type) { |
||
|
|||
319 | return $type->Title; |
||
320 | } |
||
321 | } |
||
322 | } |
||
323 | |||
324 | /** |
||
325 | * @param $member |
||
326 | * @return bool|int|void |
||
327 | */ |
||
328 | public function canCreate($member = null, $context = []) |
||
335 | } |
||
336 | |||
337 | /** |
||
338 | * @param $member |
||
339 | * @return bool|int|void|null |
||
340 | */ |
||
341 | public function canEdit($member = null, $context = []) |
||
342 | { |
||
343 | if (!$member) { |
||
344 | $member = Security::getCurrentUser(); |
||
345 | } |
||
346 | |||
347 | return Permission::checkMember($member, 'MANAGE_FOXY_PRODUCTS'); |
||
348 | } |
||
349 | |||
350 | /** |
||
351 | * @param $member |
||
352 | * @return bool|int|void |
||
353 | */ |
||
354 | public function canDelete($member = null, $context = []) |
||
355 | { |
||
356 | if (!$member) { |
||
357 | $member = Security::getCurrentUser(); |
||
358 | } |
||
359 | |||
360 | return Permission::checkMember($member, 'MANAGE_FOXY_PRODUCTS'); |
||
361 | } |
||
362 | |||
363 | /** |
||
364 | * @param Purchasable $product |
||
365 | * @return mixed |
||
366 | */ |
||
367 | public function getPrice($product) |
||
379 | } |
||
380 | |||
381 | /** |
||
382 | * @param Purchasable $product |
||
383 | * @return string |
||
384 | */ |
||
385 | public function getCode($product) |
||
397 | } |
||
398 | } |
||
399 |