FoxyLinkGeneratorController::getURLSegment() - Code Metrics - Inspection of "REFACTOR remove VCS for Groupable Gridfield (#105)" - dynamic/silverstripe-foxy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 71a588...6672d2 )

by Nic

created 2020-07-18 19:55 UTC

FoxyLinkGeneratorController::getURLSegment() A

↳ Parent: FoxyLinkGeneratorController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php

namespace Dynamic\Foxy\Controller;

use Dynamic\Foxy\Form\AddToCartForm;
use Dynamic\Foxy\Model\FoxyHelper;
use SilverStripe\Control\Controller;
use SilverStripe\ORM\ValidationException;

/**
 * Class FoxyLinkGeneratorController
 */
class FoxyLinkGeneratorController extends Controller
{
    /**
     *
     */
    const URLSEGMENT = 'foxylinkgenerator'; // phpcs:ignore PSR12.Properties.ConstantVisibility.NotFound

    /**
     * @var array
     */
    private static $allowed_actions = [

        'index',
    ];

    /**
     * @return string
     */
    public function getURLSegment()
    {
        return self::URLSEGMENT;
    }

    /**
     * @return string
     * @throws ValidationException
     */
    public function index()
    {
        $request = $this->getRequest();

        if (!$request->getVar('code')) {
            return 'Code is required';
        }

        if (!$request->getVar('price') && $request->getVar('price') != 0) {

            return 'Price is required';
        }

        if (!$request->getVar('name')) {
            return 'Name is required';
        }

        $code = $request->getVar('code');
        $props = [];
        foreach ($request->getVars() as $var => $val) {
            $props[$var] = AddToCartForm::getGeneratedValue($code, $var, $val, 'value');
        }

        $post_url = '';
        foreach ($props as $key => $value) {
            $post_url .= $key . '=' . $value . '&';
        }
        $post_url = rtrim($post_url, '&');

        echo FoxyHelper::StoreURL() . '/cart?' . $post_url;
    }
}


1			<?php
2
3			namespace Dynamic\Foxy\Controller;
4
5			use Dynamic\Foxy\Form\AddToCartForm;
6			use Dynamic\Foxy\Model\FoxyHelper;
7			use SilverStripe\Control\Controller;
8			use SilverStripe\ORM\ValidationException;
9
10			/**
11			* Class FoxyLinkGeneratorController
12			*/
13			class FoxyLinkGeneratorController extends Controller
14			{
15			/**
16			*
17			*/
18			const URLSEGMENT = 'foxylinkgenerator'; // phpcs:ignore PSR12.Properties.ConstantVisibility.NotFound
19
20			/**
21			* @var array
22			*/
23			private static $allowed_actions = [
			0 ignored issues – show introduced 2020-07-18 20:05 UTC by Report Bug Copy Issue Report The private property `$allowed_actions` is not used, and could be removed. Loading history...
24			'index',
25			];
26
27			/**
28			* @return string
29			*/
30			public function getURLSegment()
31			{
32			return self::URLSEGMENT;
33			}
34
35			/**
36			* @return string
37			* @throws ValidationException
38			*/
39			public function index()
40			{
41			$request = $this->getRequest();
42
43			if (!$request->getVar('code')) {
44			return 'Code is required';
45			}
46
47			if (!$request->getVar('price') && $request->getVar('price') != 0) {
			0 ignored issues – show Bug Best Practice introduced 2020-07-18 20:05 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$request->getVar('price')` of type `mixed\|null` to `0`; this is ambiguous as not only `0 == 0` is true, but `null == 0` is true, too. Consider using a strict comparison `===`. Loading history...
48			return 'Price is required';
49			}
50
51			if (!$request->getVar('name')) {
52			return 'Name is required';
53			}
54
55			$code = $request->getVar('code');
56			$props = [];
57			foreach ($request->getVars() as $var => $val) {
58			$props[$var] = AddToCartForm::getGeneratedValue($code, $var, $val, 'value');
59			}
60
61			$post_url = '';
62			foreach ($props as $key => $value) {
63			$post_url .= $key . '=' . $value . '&';
64			}
65			$post_url = rtrim($post_url, '&');
66
67			echo FoxyHelper::StoreURL() . '/cart?' . $post_url;
68			}
69			}
70

dynamic / silverstripe-foxy

Push — master ( 71a588...6672d2 )

FoxyLinkGeneratorController::getURLSegment() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like