OrderHistoryController::OrderPaginatedList() - Code Metrics - Inspection of "FEATURE OrderHistory - page type to display user’s..." - dynamic/silverstripe-foxy-orders - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#28)

by Jason

created 2019-07-25 02:01 UTC

OrderHistoryController::OrderPaginatedList() A

↳ Parent: OrderHistoryController

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	9
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	15
rs	9.9666

<?php

namespace Dynamic\Foxy\Orders\Page;

use SilverStripe\Control\HTTPRequest;
use SilverStripe\ORM\PaginatedList;
use SilverStripe\Security\Security;

class OrderHistoryController extends \PageController
{
    /**
     * @var array
     */
    private static $allowed_actions = array(

        'index',
    );

    /**
     * @return bool|\SilverStripe\Control\HTTPResponse
     */
    public function checkMember()
    {
        if (Security::getCurrentUser()) {
            return true;
        } else {
            return Security::permissionFailure($this, _t(
                'AccountPage.CANNOTCONFIRMLOGGEDIN',
                'Please login to view this page.'
            ));
        }
    }

    /**
     * @return array
     */
    public function index()
    {
        $this->checkMember();
        return array();
    }

    /**
     * @param HTTPRequest|null $request
     * @return PaginatedList
     */
    public function OrderPaginatedList(HTTPRequest $request = null)
    {
        if (!$request instanceof HTTPRequest) {
            $request = $this->getRequest();
        }
        $orders = $this->data()->getOrderList();
        $start = ($request->getVar('start')) ? (int)$request->getVar('start') : 0;
        $records = PaginatedList::create($orders, $request);
        $records->setPageStart($start);
        $records->setPageLength($this->data()->PerPage);

        // allow $records to be updated via extension
        $this->extend('updateOrderPaginatedList', $records);

        return $records;
    }
}


1			<?php
2
3			namespace Dynamic\Foxy\Orders\Page;
4
5			use SilverStripe\Control\HTTPRequest;
6			use SilverStripe\ORM\PaginatedList;
7			use SilverStripe\Security\Security;
8
9			class OrderHistoryController extends \PageController
10			{
11			/**
12			* @var array
13			*/
14			private static $allowed_actions = array(
			0 ignored issues – show introduced 2019-07-25 01:58 UTC by Report Bug Copy Issue Report The private property `$allowed_actions` is not used, and could be removed. Loading history...
15			'index',
16			);
17
18			/**
19			* @return bool\|\SilverStripe\Control\HTTPResponse
20			*/
21			public function checkMember()
22			{
23			if (Security::getCurrentUser()) {
24			return true;
25			} else {
26			return Security::permissionFailure($this, _t(
27			'AccountPage.CANNOTCONFIRMLOGGEDIN',
28			'Please login to view this page.'
29			));
30			}
31			}
32
33			/**
34			* @return array
35			*/
36			public function index()
37			{
38			$this->checkMember();
39			return array();
40			}
41
42			/**
43			* @param HTTPRequest\|null $request
44			* @return PaginatedList
45			*/
46			public function OrderPaginatedList(HTTPRequest $request = null)
47			{
48			if (!$request instanceof HTTPRequest) {
49			$request = $this->getRequest();
50			}
51			$orders = $this->data()->getOrderList();
52			$start = ($request->getVar('start')) ? (int)$request->getVar('start') : 0;
53			$records = PaginatedList::create($orders, $request);
54			$records->setPageStart($start);
55			$records->setPageLength($this->data()->PerPage);
56
57			// allow $records to be updated via extension
58			$this->extend('updateOrderPaginatedList', $records);
59
60			return $records;
61			}
62			}
63

dynamic / silverstripe-foxy-orders

Pull Request — master (#28)

OrderHistoryController::OrderPaginatedList() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like