Dynamic\Foxy\Inventory\Extension\ProductVariationInventoryManager::getOrders()

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getOrders()
    {
        if ($this->owner->ID) {
            $orderVariations = OrderVariation::get()->filter('VariationID', $this->owner->ID);
            if ($orderVariations) {

$orderVariations is of type SilverStripe\ORM\DataList, thus it always evaluated to true.

                $orders = ArrayList::create();
                foreach ($orderVariations as $orderVariation) {
                    $orderDetail = OrderDetail::get()->byID($orderVariation->OrderDetailID);
                    $orders->push($orderDetail);
                }
            }

            return $orders;

The variable $orders does not seem to be defined for all execution paths leading up to this point.

        }
        return false;

The expression return false returns the type false which is incompatible with the documented return type SilverStripe\ORM\DataList.

    }