Dynamic\Foxy\Inventory\Extension\ProductVariationInventoryManager

Complexity

Total Complexity

9

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getNumberPurchasedUpdate()	0	9	3
A	getOrders()	0	16	4
A	updateGetIsAvailable()	0	4	2

<?php

namespace Dynamic\Foxy\Inventory\Extension;

use Dynamic\Foxy\Orders\Model\OrderDetail;
use Dynamic\Foxy\Orders\Model\OrderVariation;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataList;

class ProductVariationInventoryManager extends ProductInventoryManager
{
    /**
     * @param $available
     */
    public function updateGetIsAvailable(&$available)
    {
        if ($this->getHasInventory()) {
            $available = $this->getIsProductAvailable();
        }
    }

    /**
     * @return int
     */
    public function getNumberPurchasedUpdate()
    {
        $ct = 0;
        if ($this->getOrders()) {
            foreach ($this->getOrders() as $order) {
                $ct += $order->Quantity;
            }
        }
        return $ct;
    }

    /**
     * @return DataList
     */
    public function getOrders()
    {
        if ($this->owner->ID) {
            $orderVariations = OrderVariation::get()->filter('VariationID', $this->owner->ID);
            if ($orderVariations) {

$orderVariations is of type SilverStripe\ORM\DataList, thus it always evaluated to true.

                $orders = ArrayList::create();
                foreach ($orderVariations as $orderVariation) {
                    $orderDetail = OrderDetail::get()->byID($orderVariation->OrderDetailID);
                    $orders->push($orderDetail);
                }
            }

            return $orders;

The variable $orders does not seem to be defined for all execution paths leading up to this point.

        }
        return false;

The expression return false returns the type false which is incompatible with the documented return type SilverStripe\ORM\DataList.

    }
}