Dynamic\Foxy\Discounts\Model\DiscountTier

Complexity

Total Complexity

6

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	35	3
A	getDiscountLabel()	0	7	3

<?php

namespace Dynamic\Foxy\Discounts\Model;

use SilverStripe\Forms\FieldList;
use SilverStripe\ORM\DataObject;

/**
 * Class DiscountTier
 * @package Dynamic\Foxy\Discounts\Model
 */
class DiscountTier extends DataObject
{
    /**
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'Quantity' => 'Int',
        'Percentage' => 'Int',
        'Amount' => 'Currency',
    ];

    /**
     * @var array
     */
    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Discount' => Discount::class,
    ];

    /**
     * @var array
     */
    private static $defaults = [

The private property $defaults is not used, and could be removed.

        'Quantity' => 1,
    ];

    /**
     * @var array
     */
    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'DiscountLabel' => [
            'title' => 'Discount',
        ],
        'Quantity',
    ];

    /**
     * @var string
     */
    private static $table_name = 'FoxyDiscountTier';

The private property $table_name is not used, and could be removed.

    /**
     * @var array
     */
    private static $default_sort = array(

The private property $default_sort is not used, and could be removed.

        'Quantity'
    );

    /**
     * @return FieldList|void
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->removeByName([
                'DiscountID',
            ]);

            $quantity = $fields->dataFieldByName('Quantity');
            $quantity->setTitle('Quantity to trigger discount');

            $type = $this->Discount()->Type;

The method Discount() does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __call, consider adding a @method annotation.

            $percentage = $fields->dataFieldByName('Percentage')
                ->setTitle('Percent discount');
            $amount = $fields->dataFieldByName('Amount')
                ->setTitle('Amount to discount');

            $fields->removeByName([
                'Percentage',
                'Amount',
            ]);

            if ($type == 'Percent') {
                $fields->addFieldToTab(
                    'Root.Main',
                    $percentage
                );
            } elseif ($type == 'Amount') {
                $fields->addFieldToTab(
                    'Root.Main',
                    $amount
                );
            }
        });

        return parent::getCMSFields();
    }

    /**
     * @return string
     */
    public function getDiscountLabel()
    {
        $type = $this->Discount()->Type;
        if ($type == 'Percent') {
            return "{$this->Percentage}%";

The property Percentage does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __get, consider adding a @property annotation.

        } elseif ($type == 'Amount') {
            return $this->dbObject('Amount')->Nice();
        }
    }
}