Dynamic\Foxy\Discounts\Extension\ProductDataExtension

Complexity

Total Complexity

8

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getActiveDiscount()	0	22	6
A	getDiscountPrice()	0	7	2

<?php

namespace Dynamic\Foxy\Discounts\Extension;

use Dynamic\Foxy\Discounts\Model\Discount;
use SilverStripe\ORM\DataExtension;

class ProductDataExtension extends DataExtension
{
    /**
     * @var array
     */
    private static $belongs_many_many = [

The private property $belongs_many_many is not used, and could be removed.

        'Discounts' => Discount::class,
    ];

    /**
     * @return bool|float|int|mixed
     */
    public function getDiscountPrice()
    {
        if ($discount = $this->getActiveDiscount()) {

The assignment to $discount is dead and can be removed.

            $price = $this->owner->Price - ($this->owner->Price * ($this->getActiveDiscount()->Percentage/100));
            return $price;
        }
        return false;
    }

    /**
     * @return mixed
     */
    public function getActiveDiscount()
    {
        $filter = [
            'StartTime:LessThanOrEqual' => date("Y-m-d H:i:s", strtotime('now')),
            'EndTime:GreaterThanOrEqual' => date("Y-m-d H:i:s", strtotime('now')),
        ];

        if ($this->owner->Discounts()->filter($filter)->count() > 0) {
            foreach ($this->owner->Discounts()->filter($filter)->sort('Percentage DESC') as $discount) {
                if ($discount->getIsActive()) {
                    return $discount;
                }
            }
        }

        foreach (Discount::get()->filter($filter)->sort('Percentage DESC') as $discount) {
            if ($discount->getIsGlobal()) {
                return $discount;
            }
        }

        return false;
    }
}