MemberExtension::updateCMSFields() - Code Metrics - Inspection of "ENHANCEMENT Member level discount" - dynamic/silverstripe-foxy-discounts - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#50)

by Nic

created 2020-09-21 19:50 UTC

MemberExtension::updateCMSFields() A

↳ Parent: MemberExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	8
c	0
b	0
f	0
dl	0
loc	14
rs	10
cc	2
nc	2
nop	1

<?php

namespace Dynamic\Foxy\Discounts\Extension;

use Dynamic\Foxy\Discounts\Model\Discount;
use SilverShop\HasOneField\HasOneButtonField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
use SilverStripe\ORM\DataExtension;

/**
 * Class MemberExtension
 * @package Dynamic\Foxy\Discounts\Extension
 */
class MemberExtension extends DataExtension
{
    /**
     * @var string[]
     */
    private static $has_one = [

        'Discount' => Discount::class,
    ];

    /**
     * @param FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        $fields->removeByName([
            'DiscountID',
        ]);

        if ($this->owner->exists()) {
            $fields->addFieldToTab(
                'Root.Main',
                $discountButton = HasOneButtonField::create($this->owner, 'Discount'),
                'FirstName'
            );

            $discountButton->getConfig()->removeComponentsByType(GridFieldAddExistingAutocompleter::class);
        }
    }
}


1			<?php
2
3			namespace Dynamic\Foxy\Discounts\Extension;
4
5			use Dynamic\Foxy\Discounts\Model\Discount;
6			use SilverShop\HasOneField\HasOneButtonField;
7			use SilverStripe\Forms\FieldList;
8			use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
9			use SilverStripe\ORM\DataExtension;
10
11			/**
12			* Class MemberExtension
13			* @package Dynamic\Foxy\Discounts\Extension
14			*/
15			class MemberExtension extends DataExtension
16			{
17			/**
18			* @var string[]
19			*/
20			private static $has_one = [
			0 ignored issues – show introduced 2020-09-21 19:52 UTC by Report Bug Copy Issue Report The private property `$has_one` is not used, and could be removed. Loading history...
21			'Discount' => Discount::class,
22			];
23
24			/**
25			* @param FieldList $fields
26			*/
27			public function updateCMSFields(FieldList $fields)
28			{
29			$fields->removeByName([
30			'DiscountID',
31			]);
32
33			if ($this->owner->exists()) {
34			$fields->addFieldToTab(
35			'Root.Main',
36			$discountButton = HasOneButtonField::create($this->owner, 'Discount'),
37			'FirstName'
38			);
39
40			$discountButton->getConfig()->removeComponentsByType(GridFieldAddExistingAutocompleter::class);
41			}
42			}
43			}
44

dynamic / silverstripe-foxy-discounts

Pull Request — master (#50)

MemberExtension::updateCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like