PageControllerExtension::fetchprice() - Code Metrics - Inspection of "ENHANCEMENT FE discount price update" - dynamic/silverstripe-foxy-discounts - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#16)

by Nic

created 2019-09-18 06:13 UTC

PageControllerExtension::fetchprice() C

↳ Parent: PageControllerExtension

Complexity

Conditions	12
Paths	37

Size

Total Lines	47
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	12
eloc	28
c	1
b	0
f	0
nc	37
nop	1
dl	0
loc	47
rs	6.9666

How to fix Complexity

<?php

namespace Dynamic\Foxy\Discounts\Extension;

use Dynamic\Foxy\Discounts\Model\DiscountTier;
use Dynamic\Foxy\Form\AddToCartForm;
use Dynamic\Products\Page\Product;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Extension;
use SilverStripe\Forms\HiddenField;
use SilverStripe\View\Requirements;

/**
 * Class PageControllerExtension
 * @package Dynamic\Foxy\Discounts\Extension
 */
class PageControllerExtension extends Extension
{
    /**
     * @var array
     */
    private static $allowed_actions = [

        'fetchprice',
    ];

    /**
     * @var array
     */
    private static $exempt_fields = [

        'price',
        'x:visibleQuantity',
        'h:product_id',
        'isAjax',
    ];

    /**
     * @param $form
     */
    public function updateAddToCartForm(&$form)
    {
        $class = $this->owner->data()->ClassName;
        if ($class::singleton()->hasMethod('getActiveDiscount')) {
            if ($discount = $this->owner->data()->getActiveDiscount()) {
                Requirements::javascript('dynamic/silverstripe-foxy-discounts: client/dist/javascript/discount.js');
                $code = $this->owner->data()->Code;
                $fields = $form->Fields();
                $fields->push(
                    HiddenField::create(AddToCartForm::getGeneratedValue(
                        $code,
                        $discount->getDiscountType(),
                        $this->getDiscountFieldValue()
                    ))->setValue($this->getDiscountFieldValue())
                        ->addExtraClass('product-discount')
                );
            }
        }
    }

    /**
     * @return string
     */
    public function getDiscountFieldValue()
    {
        if ($discount = $this->owner->data()->getActiveDiscount()) {
            $tiers = $discount->DiscountTiers();
            $bulkString = '';
            foreach ($tiers as $tier) {
                if ($discount->Type == 'Percent') {
                    $bulkString .= "|{$tier->Quantity}-{$tier->Percentage}";
                    $method = 'allunits';
                } elseif ($discount->Type == 'Amount') {
                    $bulkString .= "|{$tier->Quantity}-{$tier->Amount}";
                    $method = 'allunits';
                }
            }

            return "{$discount->Title}{{$method}{$bulkString}}";

        }

        return false;

    }

    public function fetchprice(HTTPRequest $request)
    {
        if (!$id = $request->getVar('h:product_id')) {
            return;
        }

        if (!$product = Product::get()->byID(explode('||', $id)[0])) {
            return;
        }

        $quantity = (int)$request->getVar('x:visibleQuantity');

        $cost = $product->Price * $quantity;

        $optionsQuery = $this->getOptionsQuery($request->getVars());

        $options = $product->Options()->filter($optionsQuery);

        foreach ($options as $option) {
            switch ($option->PriceModifierAction) {
                case 'Add':
                    $cost += ($option->PriceModifier * $quantity);
                    break;
                case 'Subtract':
                    $cost -= ($option->PriceModifier * $quantity);
                    break;
                case 'Set':
                    $cost = ($option->PriceModifier * $quantity);
                    break;
            }
        }

        $discount = $this->getDiscount($quantity);

        if ($discount instanceof DiscountTier && $discount->exists()) {
            if ($discount->Discount()->Type == 'Percent') {
            if ($discount->/** @scrutinizer ignore-call */ Discount()->Type == 'Percent') {
                $discountAmount = $cost * ($discount->Percentage / 100);

            } elseif ($discount->Discount()->Type == 'Amount') {
                $discountAmount = $discount->Amount;

            }

            if (isset($discountAmount)) {
                $cost = $cost - $discountAmount;
            }
        }

        return $cost;
    }

    /**
     * @param $quantity
     * @return mixed
     */
    protected function getDiscount($quantity)
    {
        $best = $this->owner->data()->getActiveDiscount();

        $tier = $best->DiscountTiers()->filter('Quantity:LessThanOrEqual', $quantity)->sort('Quantity DESC')->first();

        return $tier;
    }

    /**
     * @param $vars
     * @return array
     */
    protected function getOptionsQuery($vars)
    {
        $exempt = $this->owner->config()->get('exempt_fields');
        $filter = ['PriceModifierAction:not' => null];

        foreach ($vars as $key => $val) {
            if (!in_array($key, $exempt)) {
                $filter['OptionModifierKey'][] = explode('||', $val)[0];
            }
        }

        return $filter;
    }
}


dynamic / silverstripe-foxy-discounts

Pull Request — master (#16)

PageControllerExtension::fetchprice() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like