Dynamic\Foxy\Discounts\Model\DiscountTier::validate()

Complexity

Conditions	5
Paths	10

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function validate()
    {
        $response = parent::validate();

        if ($this->exists()) {
            $exclude['ID'] = $this->ID;

$exclude was never initialized. Although not strictly required by PHP, it is generally a good practice to add $exclude = array(); before regardless.

        }

        /** @var Discount $discount */
        if ($discount = Discount::get()->byID($this->DiscountID)) {

The property DiscountID does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __get, consider adding a @property annotation.

            $existing = $discount->DiscountTiers()->filter('Quantity', $this->Quantity);

The property Quantity does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __get, consider adding a @property annotation.

The method DiscountTiers() does not exist on Dynamic\Foxy\Discounts\Model\Discount. Since you implemented __call, consider adding a @method annotation.

            if (isset($exclude)) {
                $existing = $existing->exclude($exclude);
            }

            if ($existing->count() > 0) {
                $response->addError("A discount tier already has the quantity {$this->Quantity} set");
            }
        }

        return $response;
    }