Dynamic\Foxy\Discounts\Extension\PageControllerExtension

Complexity

Total Complexity

32

Size/Duplication

Total Lines	174
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getDiscountFieldValue()	0	20	5
A	updateAddToCartForm()	0	16	3
C	fetchprice()	0	61	17
A	getOptionsQuery()	0	12	3
A	getIsDiscountable()	0	5	3
A	getDiscount()	0	10	1

<?php

namespace Dynamic\Foxy\Discounts\Extension;

use Dynamic\Foxy\Discounts\DiscountHelper;
use Dynamic\Foxy\Discounts\Model\Discount;
use Dynamic\Foxy\Discounts\Model\DiscountTier;
use Dynamic\Foxy\Form\AddToCartForm;
use Dynamic\Products\Page\Product;

The type Dynamic\Products\Page\Product was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Extension;
use SilverStripe\Dev\Debug;
use SilverStripe\Forms\HiddenField;
use SilverStripe\View\Requirements;

/**
 * Class PageControllerExtension
 * @package Dynamic\Foxy\Discounts\Extension
 */
class PageControllerExtension extends Extension
{
    /**
     * @var array
     */
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'fetchprice',
    ];

    /**
     * @var array
     */
    private static $exempt_fields = [

The private property $exempt_fields is not used, and could be removed.

        'price',
        'quantity',
        'h:product_id',
        'isAjax',
    ];

    /**
     * @param $form
     */
    public function updateAddToCartForm(&$form)
    {
        $page = $this->owner->data();
        if ($this->getIsDiscountable($page)) {
            /** @var DiscountHelper $discount */
            if ($discount = $page->getBestDiscount()) {
                Requirements::javascript('dynamic/silverstripe-foxy-discounts: client/dist/javascript/discount.js');
                $code = $page->Code;
                $fields = $form->Fields();
                $fields->push(
                    HiddenField::create(AddToCartForm::getGeneratedValue(
                        $code,
                        $discount->getDiscount()->getDiscountType(),
                        $this->getDiscountFieldValue()
                    ))->setValue($this->getDiscountFieldValue())
                        ->addExtraClass('product-discount')
                );
            }
        }
    }

    /**
     * @return string
     */
    public function getDiscountFieldValue()
    {
        /** @var Discount $discount */
        if ($discount = $this->owner->data()->getBestDiscount()->getDiscount()) {
            $tiers = $discount->DiscountTiers();

The method DiscountTiers() does not exist on Dynamic\Foxy\Discounts\Model\Discount. Since you implemented __call, consider adding a @method annotation.

            $bulkString = '';
            foreach ($tiers as $tier) {
                if ($discount->Type == 'Percent') {

The property Type does not exist on Dynamic\Foxy\Discounts\Model\Discount. Since you implemented __get, consider adding a @property annotation.

                    $bulkString .= "|{$tier->Quantity}-{$tier->Percentage}";
                    $method = 'allunits';
                } elseif ($discount->Type == 'Amount') {
                    $bulkString .= "|{$tier->Quantity}-{$tier->Amount}";
                    $method = 'allunits';
                }
            }

            return "{$discount->Title}{{$method}{$bulkString}}";

The variable $method seems to be defined by a foreach iteration on line 72. Are you sure the iterator is never empty, otherwise this variable is not defined?

        }

        return false;

The expression return false returns the type false which is incompatible with the documented return type string.

    }

    public function fetchprice(HTTPRequest $request)
    {
        if (!$id = $request->getVar('h:product_id')) {
            return;
        }

        if (!$product = Product::get()->byID(explode('||', $id)[0])) {
            return;
        }

        if (!$this->getIsDiscountable($product)) {
            return;
        }

        $totalPrice = Discount::config()->get('calculate_total');
        $quantity = (int)$request->getVar('quantity');
        $cost = ($totalPrice) ? $product->Price * $quantity : $product->Price;
        $optionsQuery = $this->getOptionsQuery($request->getVars());
        $options = $product->Options()->filter($optionsQuery);

        foreach ($options as $option) {
            switch ($option->PriceModifierAction) {
                case 'Add':
                    if ($totalPrice) {
                        $cost += ($option->PriceModifier * $quantity);
                    } else {
                        $cost += $option->PriceModifier;
                    }
                    break;
                case 'Subtract':
                    if ($totalPrice) {
                        $cost -= ($option->PriceModifier * $quantity);
                    } else {
                        $cost -= $option->ProceModifier;
                    }
                    break;
                case 'Set':
                    if ($totalPrice) {
                        $cost = ($option->PriceModifier * $quantity);
                    } else {
                        $cost = $option->PriceModifier;
                    }
                    break;
            }
        }

        $discount = $this->getDiscount($quantity);

        if ($discount instanceof DiscountTier && $discount->exists()) {
            if ($discount->Discount()->Type == 'Percent') {

The method Discount() does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __call, consider adding a @method annotation.

                $discountAmount = $cost * ($discount->Percentage / 100);

The property Percentage does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __get, consider adding a @property annotation.

            } elseif ($discount->Discount()->Type == 'Amount') {
                $discountAmount = $discount->Amount;

The property Amount does not exist on Dynamic\Foxy\Discounts\Model\DiscountTier. Since you implemented __get, consider adding a @property annotation.

            }

            if (isset($discountAmount)) {
                $cost = $cost - $discountAmount;
            }
        }

        return $cost;
    }

    /**
     * @param $quantity
     * @return mixed
     */
    protected function getDiscount($quantity)
    {
        /** @var DiscountHelper $best */
        $best = $this->owner->data()->getBestDiscount();

        $best->setDiscountTier($quantity);

        $tier = $best->getDiscountTier();

        return $tier;
    }

    /**
     * @param $vars
     * @return array
     */
    protected function getOptionsQuery($vars)
    {
        $exempt = $this->owner->config()->get('exempt_fields');
        $filter['PriceModifierAction:not'] = null;

$filter was never initialized. Although not strictly required by PHP, it is generally a good practice to add $filter = array(); before regardless.

        foreach ($vars as $key => $val) {
            if (!in_array($key, $exempt)) {
                $filter['OptionModifierKey'][] = explode('||', $val)[0];
            }
        }

        return $filter;
    }

    /**
     * @param $product
     * @return bool
     */
    public function getIsDiscountable($product)
    {
        return $product->hasMethod('getHasDiscount')
            && $product->hasMethod('getBestDiscount')
            && $product->getHasDiscount();
    }
}