Passed
Pull Request — master (#198)
by Nic
02:28
created
src/ORM/FlexSlider.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -124,63 +124,63 @@  discard block
 block discarded – undo
124 124
 
125 125
             $SlidesField = GridField::create(
126 126
                 'Slides',
127
-                _t(__CLASS__ . '.SLIDES', 'Slides'),
127
+                _t(__CLASS__.'.SLIDES', 'Slides'),
128 128
                 $this->owner->Slides()->sort('SortOrder'),
129 129
                 $config
130 130
             );
131 131
 
132
-            $slideTitle = $this->owner->stat('slide_tab_title') ?: _t(__CLASS__ . '.SLIDES', 'Slides');
132
+            $slideTitle = $this->owner->stat('slide_tab_title') ?: _t(__CLASS__.'.SLIDES', 'Slides');
133 133
 
134 134
             $animations = [];
135 135
             $animationOptions = $this->owner->dbObject('Animation')->getEnum();
136 136
             foreach ($animationOptions as $value) {
137
-                $animations[$value] = _t(__CLASS__ . ".$value", $value);
137
+                $animations[$value] = _t(__CLASS__.".$value", $value);
138 138
             }
139 139
 
140 140
             $fields->addFieldsToTab("Root.{$slideTitle}", [
141 141
                 $SlidesField,
142
-                ToggleCompositeField::create('ConfigHD', _t(__CLASS__ . '.SettingsLabel', 'Slider Settings'), [
142
+                ToggleCompositeField::create('ConfigHD', _t(__CLASS__.'.SettingsLabel', 'Slider Settings'), [
143 143
                     DropdownField::create(
144 144
                         'Animation',
145
-                        _t(__CLASS__ . '.ANIMATION_OPTION', 'Animation option'),
145
+                        _t(__CLASS__.'.ANIMATION_OPTION', 'Animation option'),
146 146
                         $animations
147 147
                     ),
148 148
                     CheckboxField::create(
149 149
                         'Animate',
150
-                        _t(__CLASS__ . '.ANIMATE', 'Animate automatically')
150
+                        _t(__CLASS__.'.ANIMATE', 'Animate automatically')
151 151
                     ),
152 152
                     CheckboxField::create(
153 153
                         'Loop',
154
-                        _t(__CLASS__ . '.LOOP', 'Loop the carousel')
154
+                        _t(__CLASS__.'.LOOP', 'Loop the carousel')
155 155
                     ),
156 156
                     CheckboxField::create(
157 157
                         'SliderControlNav',
158
-                        _t(__CLASS__ . '.CONTROL_NAV', 'Show ControlNav')
158
+                        _t(__CLASS__.'.CONTROL_NAV', 'Show ControlNav')
159 159
                     ),
160 160
                     CheckboxField::create(
161 161
                         'SliderDirectionNav',
162
-                        _t(__CLASS__ . '.DIRECTION_NAV', 'Show DirectionNav')
162
+                        _t(__CLASS__.'.DIRECTION_NAV', 'Show DirectionNav')
163 163
                     ),
164 164
                     CheckboxField::create(
165 165
                         'ThumbnailNav',
166
-                        _t(__CLASS__ . '.THUMBNAIL_NAV', 'Thumbnail Navigation')
166
+                        _t(__CLASS__.'.THUMBNAIL_NAV', 'Thumbnail Navigation')
167 167
                     ),
168 168
                     //DisplayLogicWrapper::create(
169 169
                     CheckboxField::create(
170 170
                         'CarouselControlNav',
171
-                        _t(__CLASS__ . '.CAROUSEL_CONTROL_NAV', 'Show Carousel ControlNav')
171
+                        _t(__CLASS__.'.CAROUSEL_CONTROL_NAV', 'Show Carousel ControlNav')
172 172
                     ),
173 173
                     CheckboxField::create(
174 174
                         'CarouselDirectionNav',
175
-                        _t(__CLASS__ . '.CAROUSEL_DIRECTION_NAV', 'Show Carousel DirectionNav')
175
+                        _t(__CLASS__.'.CAROUSEL_DIRECTION_NAV', 'Show Carousel DirectionNav')
176 176
                     ),
177 177
                     NumericField::create(
178 178
                         'CarouselThumbnailCt',
179
-                        _t(__CLASS__ . '.CAROUSEL_THUMBNAIL_COUNT', 'Number of thumbnails')
179
+                        _t(__CLASS__.'.CAROUSEL_THUMBNAIL_COUNT', 'Number of thumbnails')
180 180
                     ),
181 181
                     NumericField::create(
182 182
                         'FlexSliderSpeed',
183
-                        _t(__CLASS__ . '.SLIDER_SPEED', 'Slider Speed')
183
+                        _t(__CLASS__.'.SLIDER_SPEED', 'Slider Speed')
184 184
                     )
185 185
                         ->setDescription('In Seconds')
186 186
                         ->setScale(2),
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
     public function getCustomScript()
223 223
     {
224 224
         // Flexslider options
225
-        $sync = ($this->owner->ThumbnailNav == true) ? "sync: '.fs-carousel:eq('+index+')'," : '';
225
+        $sync = ($this->owner->ThumbnailNav==true) ? "sync: '.fs-carousel:eq('+index+')'," : '';
226 226
 
227 227
         $before = $this->owner->hasMethod('flexSliderBeforeAction')
228 228
             ? $this->owner->flexSliderBeforeAction()
@@ -241,18 +241,18 @@  discard block
 block discarded – undo
241 241
 
242 242
                          if(jQuery('.fs-carousel').eq(index).length) {
243 243
                              jQuery('.fs-carousel').eq(index).flexslider({
244
-                                slideshow: " . $this->owner->obj('Animate')->NiceAsBoolean() . ",
244
+                                slideshow: " . $this->owner->obj('Animate')->NiceAsBoolean().",
245 245
                                 animation: 'slide',
246
-                                animationLoop: " . $this->owner->obj('Loop')->NiceAsBoolean() . ",
247
-                                controlNav: " . $this->owner->obj('CarouselControlNav')->NiceAsBoolean() . ",
248
-                                directionNav: " . $this->owner->obj('CarouselDirectionNav')->NiceAsBoolean() . ",
246
+                                animationLoop: " . $this->owner->obj('Loop')->NiceAsBoolean().",
247
+                                controlNav: " . $this->owner->obj('CarouselControlNav')->NiceAsBoolean().",
248
+                                directionNav: " . $this->owner->obj('CarouselDirectionNav')->NiceAsBoolean().",
249 249
                                 prevText: '',
250 250
                                 nextText: '',
251 251
                                 pausePlay: false,
252 252
                                 asNavFor: '.flexslider:eq('+index+')',
253
-                                minItems: " . $this->owner->obj('CarouselThumbnailCt') . ",
254
-                                maxItems: " . $this->owner->obj('CarouselThumbnailCt') . ",
255
-                                move: " . $this->owner->obj('CarouselThumbnailCt') . ",
253
+                                minItems: " . $this->owner->obj('CarouselThumbnailCt').",
254
+                                maxItems: " . $this->owner->obj('CarouselThumbnailCt').",
255
+                                move: " . $this->owner->obj('CarouselThumbnailCt').",
256 256
                                 itemWidth: 100,
257 257
                                 itemMargin: 10
258 258
                               });
@@ -260,22 +260,22 @@  discard block
 block discarded – undo
260 260
 
261 261
                         if(jQuery('.flexslider').eq(index).length){
262 262
                             jQuery('.flexslider').eq(index).flexslider({
263
-                                slideshow: " . $this->owner->obj('Animate')->NiceAsBoolean() . ",
264
-                                animation: '" . $this->owner->Animation . "',
265
-                                animationLoop: " . $this->owner->obj('Loop')->NiceAsBoolean() . ",
266
-                                controlNav: " . $this->owner->obj('SliderControlNav')->NiceAsBoolean() . ",
267
-                                directionNav: " . $this->owner->obj('SliderDirectionNav')->NiceAsBoolean() . ",
263
+                                slideshow: " . $this->owner->obj('Animate')->NiceAsBoolean().",
264
+                                animation: '" . $this->owner->Animation."',
265
+                                animationLoop: " . $this->owner->obj('Loop')->NiceAsBoolean().",
266
+                                controlNav: " . $this->owner->obj('SliderControlNav')->NiceAsBoolean().",
267
+                                directionNav: " . $this->owner->obj('SliderDirectionNav')->NiceAsBoolean().",
268 268
                                 prevText: '',
269 269
                                 nextText: '',
270 270
                                 pauseOnAction: true,
271 271
                                 pauseOnHover: true,
272
-                                " . $sync . "
272
+                                " . $sync."
273 273
                                 start: function(slider){
274 274
                                   $('body').removeClass('loading');
275 275
                                 },
276
-                                before: " . $before . ',
277
-                                after: ' . $after . ',
278
-                                slideshowSpeed: ' . $speed . '
276
+                                before: " . $before.',
277
+                                after: ' . $after.',
278
+                                slideshowSpeed: ' . $speed.'
279 279
                             });
280 280
                         }
281 281
                     })
Please login to merge, or discard this patch.
src/Model/VideoEmbedSlide.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
      */
42 42
     public function getCMSFields()
43 43
     {
44
-        $this->beforeUpdateCMSFields(function (FieldList $fields) {
44
+        $this->beforeUpdateCMSFields(function(FieldList $fields) {
45 45
             $fields->removeByName(['VideoID']);
46 46
             $fields->addFieldToTab(
47 47
                 'Root.Main',
Please login to merge, or discard this patch.
src/Model/VideoSlide.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
      */
47 47
     public function getCMSFields()
48 48
     {
49
-        $this->beforeUpdateCMSFields(function (FieldList $fields) {
49
+        $this->beforeUpdateCMSFields(function(FieldList $fields) {
50 50
             $fields->addFieldToTab(
51 51
                 'Root.Main',
52 52
                 UploadField::create('Video')
Please login to merge, or discard this patch.
src/Model/Slide.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      */
125 125
     public function getCMSFields()
126 126
     {
127
-        $this->beforeUpdateCMSFields(function (FieldList $fields) {
127
+        $this->beforeUpdateCMSFields(function(FieldList $fields) {
128 128
             $viewInherit = $fields->dataFieldByName('CanViewType');
129 129
             $editInherit = $fields->dataFieldByName('CanEditType');
130 130
 
@@ -162,27 +162,27 @@  discard block
 block discarded – undo
162 162
     {
163 163
         return [
164 164
             static::SLIDE_CREATE => [
165
-                'name' => _t(__CLASS__ . '.PERMISSION_CREATE_DESCRIPTION', 'Create Slides'),
166
-                'help' => _t(__CLASS__ . '.PERMISSION_CREATE_HELP', 'Allow creating slides'),
167
-                'category' => _t(__CLASS__ . '.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
165
+                'name' => _t(__CLASS__.'.PERMISSION_CREATE_DESCRIPTION', 'Create Slides'),
166
+                'help' => _t(__CLASS__.'.PERMISSION_CREATE_HELP', 'Allow creating slides'),
167
+                'category' => _t(__CLASS__.'.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
168 168
                 'sort' => 100,
169 169
             ],
170 170
             static::SLIDE_PUBLISH => [
171
-                'name' => _t(__CLASS__ . '.PERMISSION_PUBLISH_DESCRIPTION', 'Publish Slides'),
172
-                'help' => _t(__CLASS__ . '.PERMISSION_PUBLISH_HELP', 'Allow publishing slides'),
173
-                'category' => _t(__CLASS__ . '.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
171
+                'name' => _t(__CLASS__.'.PERMISSION_PUBLISH_DESCRIPTION', 'Publish Slides'),
172
+                'help' => _t(__CLASS__.'.PERMISSION_PUBLISH_HELP', 'Allow publishing slides'),
173
+                'category' => _t(__CLASS__.'.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
174 174
                 'sort' => 100,
175 175
             ],
176 176
             static::SLIDE_EDIT => [
177
-                'name' => _t(__CLASS__ . '.PERMISSION_EDIT_DESCRIPTION', 'Edit Slides'),
178
-                'help' => _t(__CLASS__ . '.PERMISSION_EDIT_HELP', 'Allow editing slides'),
179
-                'category' => _t(__CLASS__ . '.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
177
+                'name' => _t(__CLASS__.'.PERMISSION_EDIT_DESCRIPTION', 'Edit Slides'),
178
+                'help' => _t(__CLASS__.'.PERMISSION_EDIT_HELP', 'Allow editing slides'),
179
+                'category' => _t(__CLASS__.'.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
180 180
                 'sort' => 100,
181 181
             ],
182 182
             static::SLIDE_DELETE => [
183
-                'name' => _t(__CLASS__ . '.PERMISSION_DELETE_DESCRIPTION', 'Delete Slides'),
184
-                'help' => _t(__CLASS__ . '.PERMISSION_DELETE_HELP', 'Allow deleting slides'),
185
-                'category' => _t(__CLASS__ . '.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
183
+                'name' => _t(__CLASS__.'.PERMISSION_DELETE_DESCRIPTION', 'Delete Slides'),
184
+                'help' => _t(__CLASS__.'.PERMISSION_DELETE_HELP', 'Allow deleting slides'),
185
+                'category' => _t(__CLASS__.'.PERMISSIONS_CATEGORY', 'FlexSlider Permissions'),
186 186
                 'sort' => 100,
187 187
             ],
188 188
         ];
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 
202 202
         // Standard mechanism for accepting permission changes from extensions
203 203
         $extended = $this->extendedCan(__FUNCTION__, $member, $context);
204
-        if ($extended !== null) {
204
+        if ($extended!==null) {
205 205
             return $extended;
206 206
         }
207 207
 
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 
228 228
         // Check extension
229 229
         $extended = $this->extendedCan('canPublish', $member);
230
-        if ($extended !== null) {
230
+        if ($extended!==null) {
231 231
             return $extended;
232 232
         }
233 233
 
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 
251 251
         // Standard mechanism for accepting permission changes from extensions
252 252
         $extended = $this->extendedCan('canEdit', $member);
253
-        if ($extended !== null) {
253
+        if ($extended!==null) {
254 254
             return $extended;
255 255
         }
256 256
 
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 
276 276
         // Standard mechanism for accepting permission changes from extensions
277 277
         $extended = $this->extendedCan('canView', $member);
278
-        if ($extended !== null) {
278
+        if ($extended!==null) {
279 279
             return $extended;
280 280
         }
281 281
 
@@ -288,22 +288,22 @@  discard block
 block discarded – undo
288 288
         // to allow parent canView extensions to influence subpage canView()
289 289
 
290 290
         // check for empty spec
291
-        if (!$this->CanViewType || $this->CanViewType === InheritedPermissions::ANYONE) {
291
+        if (!$this->CanViewType || $this->CanViewType===InheritedPermissions::ANYONE) {
292 292
             return true;
293 293
         }
294 294
 
295 295
         // check for inherit
296
-        if ($this->CanViewType === InheritedPermissions::INHERIT) {
296
+        if ($this->CanViewType===InheritedPermissions::INHERIT) {
297 297
             return $this->getSiteConfig()->canViewPages($member);
298 298
         }
299 299
 
300 300
         // check for any logged-in users
301
-        if ($this->CanViewType === InheritedPermissions::LOGGED_IN_USERS && $member && $member->ID) {
301
+        if ($this->CanViewType===InheritedPermissions::LOGGED_IN_USERS && $member && $member->ID) {
302 302
             return true;
303 303
         }
304 304
 
305 305
         // check for specific groups
306
-        if ($this->CanViewType === InheritedPermissions::ONLY_THESE_USERS
306
+        if ($this->CanViewType===InheritedPermissions::ONLY_THESE_USERS
307 307
             && $member
308 308
             && $member->inGroups($this->ViewerGroups())
309 309
         ) {
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
         // Standard mechanism for accepting permission changes from extensions
327 327
         $extended = $this->extendedCan('canDelete', $member);
328
-        if ($extended !== null) {
328
+        if ($extended!==null) {
329 329
             return $extended;
330 330
         }
331 331
 
Please login to merge, or discard this patch.
src/Model/ImageSlide.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      */
48 48
     public function getCMSFields()
49 49
     {
50
-        $this->beforeUpdateCMSFields(function (FieldList $fields) {
50
+        $this->beforeUpdateCMSFields(function(FieldList $fields) {
51 51
             $fields->addFieldToTab(
52 52
                 'Root.Main',
53 53
                 ImageUploadField::create('Image')
Please login to merge, or discard this patch.