FlexSlider::updateCMSFields() - Code Metrics - Inspection of "TESTS: Increase Codecov score" - dynamic/silverstripe-flexslider - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#52)

by Jason

created 2016-04-12 04:37 UTC

FlexSlider::updateCMSFields() B

↳ Parent: FlexSlider

Complexity

Conditions	3
Paths	3

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	3.0077

Importance

Changes	16
Bugs	1	Features	1

Metric	Value
c	16
b	1
f	1
dl	0
loc	25
ccs	19
cts	21
cp	0.9048
rs	8.8571
cc	3
eloc	16
nc	3
nop	1
crap	3.0077

<?php

class FlexSlider extends DataExtension
{
    public static $db = array(
        'Animation' => "Enum('slide, fade', 'slide')",
        'Loop' => 'Boolean',
        'Animate' => 'Boolean',
        'ThumbnailNav' => 'Boolean',
    );

    public static $has_many = array(
        'Slides' => 'SlideImage',
    );

    public static $defaults = array(
        'Loop' => '1',
        'Animate' => '1',
    );

    public function populateDefaults()
    {
        parent::populateDefaults();
        $this->Loop = 1;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->Animate = 1;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function updateCMSFields(FieldList $fields)
    {
        // Slides
        if ($this->owner->ID) {
            $config = GridFieldConfig_RecordEditor::create();
            if (class_exists('GridFieldSortableRows')) {
                $config->addComponent(new GridFieldSortableRows('SortOrder'));
            }
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->removeComponentsByType('GridFieldDeleteAction');
            $config->addComponent(new GridFieldDeleteAction(false));
            $SlidesField = GridField::create('Slides', 'Slides', $this->owner->Slides()->sort('SortOrder'), $config);

            $fields->addFieldsToTab('Root.Slides', array(
                HeaderField::create('SliderHD', 'Slides', 3),
                $SlidesField,
                ToggleCompositeField::create('ConfigHD', 'Slider Settings', array(
                    CheckboxField::create('Animate', 'Animate automatically'),
                    DropdownField::create('Animation', 'Animation option', $this->owner->dbObject('Animation')->enumValues()),
                    CheckboxField::create('Loop', 'Loop the carousel'),
                    //CheckboxField::create('ThumbnailNav', 'Thumbnail Navigation'),

                )),
            ));
        }
    }

    public function SlideShow()

    {
        return $this->owner->Slides()->filter(array('ShowSlide' => 1))->sort('SortOrder');
    }
}


1		<?php
2
3		class FlexSlider extends DataExtension
4		{
5		public static $db = array(
6		'Animation' => "Enum('slide, fade', 'slide')",
7		'Loop' => 'Boolean',
8		'Animate' => 'Boolean',
9		'ThumbnailNav' => 'Boolean',
10		);
11
12		public static $has_many = array(
13		'Slides' => 'SlideImage',
14		);
15
16		public static $defaults = array(
17		'Loop' => '1',
18		'Animate' => '1',
19		);
20
21	2	public function populateDefaults()
22		{
23	2	parent::populateDefaults();
24	2	$this->Loop = 1;
		0 ignored issues – show Bug introduced 2016-04-11 21:06 UTC by Report Bug Copy Issue Report The property `Loop` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25	2	$this->Animate = 1;
		0 ignored issues – show Bug introduced 2016-04-11 21:06 UTC by Report Bug Copy Issue Report The property `Animate` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26	2	}
27
28	1	public function updateCMSFields(FieldList $fields)
29		{
30		// Slides
31	1	if ($this->owner->ID) {
32	1	$config = GridFieldConfig_RecordEditor::create();
33	1	if (class_exists('GridFieldSortableRows')) {
34		$config->addComponent(new GridFieldSortableRows('SortOrder'));
35		}
36	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
37	1	$config->removeComponentsByType('GridFieldDeleteAction');
38	1	$config->addComponent(new GridFieldDeleteAction(false));
39	1	$SlidesField = GridField::create('Slides', 'Slides', $this->owner->Slides()->sort('SortOrder'), $config);
40
41	1	$fields->addFieldsToTab('Root.Slides', array(
42	1	HeaderField::create('SliderHD', 'Slides', 3),
43	1	$SlidesField,
44	1	ToggleCompositeField::create('ConfigHD', 'Slider Settings', array(
45	1	CheckboxField::create('Animate', 'Animate automatically'),
46	1	DropdownField::create('Animation', 'Animation option', $this->owner->dbObject('Animation')->enumValues()),
47	1	CheckboxField::create('Loop', 'Loop the carousel'),
48		//CheckboxField::create('ThumbnailNav', 'Thumbnail Navigation'),
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-12 03:09 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
49	1	)),
50	1	));
51	1	}
52	1	}
53
54		public function SlideShow()
		0 ignored issues – show Documentation introduced 2016-04-11 21:19 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
55		{
56		return $this->owner->Slides()->filter(array('ShowSlide' => 1))->sort('SortOrder');
57		}
58		}
59

dynamic / silverstripe-flexslider

Pull Request — master (#52)

FlexSlider::updateCMSFields() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like