Dynamic\Elements\Promos\Model\PromoObject

Complexity

Total Complexity

4

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Test Coverage

Coverage

70%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	21	1
A	getPage()	0	11	3

<?php

namespace Dynamic\Elements\Promos\Model;

use Dynamic\BaseObject\Model\BaseElementObject;
use Dynamic\Elements\Promos\Elements\ElementPromos;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldConfig_RecordViewer;

/**
 * Class PromoObject.
 */
class PromoObject extends BaseElementObject
{
    /**
     * @return string
     */
    private static $singular_name = 'Promo';

The private property $singular_name is not used, and could be removed.

    /**
     * @return string
     */
    private static $plural_name = 'Promos';

The private property $plural_name is not used, and could be removed.

    /**
     * @var array
     */
    private static $belongs_many_many = array(

The private property $belongs_many_many is not used, and could be removed.

        'ElementPromos' => ElementPromos::class,
    );

    /**
     * @var string
     */
    private static $table_name = 'PromoObject';

The private property $table_name is not used, and could be removed.

    /**
     * @return FieldList
     *
     * @throws \Exception
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->removeByName('ElementPromos');

            $config = GridFieldConfig_RecordViewer::create();
            $fields->addFieldToTab(
                'Root.Elements',
                GridField::create(
                    'ElementPromos',
                    'Elements',
                    $this->ElementPromos(),

The method ElementPromos() does not exist on Dynamic\Elements\Promos\Model\PromoObject. Since you implemented __call, consider adding a @method annotation.

                    $config
                )
            );

            $fields->dataFieldByName('Image')
                ->setFolderName('Uploads/Elements/Promos');
        });

        return parent::getCMSFields();
    }

    /**
     * @return null
     */
    public function getPage()
    {
        $page = null;

        if ($this->ElementPromos()) {
            if ($this->ElementPromos()->hasMethod('getPage')) {
                $page = $this->PhotoGallery()->getPage();

The method PhotoGallery() does not exist on Dynamic\Elements\Promos\Model\PromoObject. Since you implemented __call, consider adding a @method annotation.

            }
        }

        return $page;
    }
}