dynamic / foxystripe

src/Model/OrderDetail.php

<?php

namespace Dynamic\FoxyStripe\Model;

use Dynamic\FoxyStripe\Page\ProductPage;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldConfig_RecordViewer;
use SilverStripe\ORM\DataObject;
use SilverStripe\Security\Permission;

/**
 * Class OrderDetail
 * @package Dynamic\FoxyStripe\Model
 *
 * @property \SilverStripe\ORM\FieldType\DBInt Quantity
 * @property \SilverStripe\ORM\FieldType\DBCurrency Price
 * @property \SilverStripe\ORM\FieldType\DBVarchar ProductName
 * @property \SilverStripe\ORM\FieldType\DBVarchar ProductCode
 * @property \SilverStripe\ORM\FieldType\DBText ProductImage
 * @property \SilverStripe\ORM\FieldType\DBVarchar ProductCategory
 *
 * @property int ProductID
 * @method ProductPage Product()
 * @property int OrderID
 * @method Order Order()
 *
 * @method \SilverStripe\ORM\HasManyList OrderOptions()
 * @method \SilverStripe\ORM\ManyManyList OptionItems()
 */
class OrderDetail extends DataObject
{
    /**
     * @var string
     */
    private static $singular_name = 'Order Detail';

The private property $singular_name is not used, and could be removed.

    /**
     * @var string
     */
    private static $plural_name = 'Order Details';

The private property $plural_name is not used, and could be removed.

    /**
     * @var string
     */
    private static $description = '';

The private property $description is not used, and could be removed.

    /**
     * @var array
     */
    private static $db = array(

The private property $db is not used, and could be removed.

        'Quantity' => 'Int',
        'Price' => 'Currency',
        'ProductName' => 'Varchar(255)',
        'ProductCode' => 'Varchar(100)',
        'ProductImage' => 'Text',
        'ProductCategory' => 'Varchar(100)',
    );

    /**
     * @var array
     */
    private static $has_one = array(

The private property $has_one is not used, and could be removed.

        'Product' => ProductPage::class,
        'Order' => Order::class,
    );

    /**
     * @var array
     */
    private static $has_many = array(

The private property $has_many is not used, and could be removed.

        'OrderOptions' => OrderOption::class,
    );

    /**
     * @var array
     */
    private static $many_many = [

The private property $many_many is not used, and could be removed.

        'OptionItems' => OptionItem::class,
    ];

    /**
     * @var array
     */
    private static $summary_fields = array(

The private property $summary_fields is not used, and could be removed.

        'Product.Title',
        'Quantity',
        'Price.Nice',
    );

    /**
     * @var string
     */
    private static $table_name = 'OrderDetail';

The private property $table_name is not used, and could be removed.

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        if ($this->ID) {
            $fields->addFieldsToTab('Root.Options', array(
                GridField::create(
                    'Options',
                    'Product Options',
                    $this->OrderOptions(),
                    GridFieldConfig_RecordViewer::create()
                ),
            ));
        }

        return $fields;
    }

    /**
     * @param bool $member
     *
     * @return bool|int
     */
    public function canView($member = null)
    {
        return Permission::check('Product_ORDERS', 'any', $member);

It seems like $member can also be of type boolean; however, parameter $member of SilverStripe\Security\Permission::check() does only seem to accept SilverStripe\Security\Member|integer, maybe add an additional type check?

    }

    /**
     * @param null $member

Are you sure the doc-type for parameter $member is correct as it would always require null to be passed?

     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * @param null $member

Are you sure the doc-type for parameter $member is correct as it would always require null to be passed?

     * @param array $context
     *
     * @return bool
     */
    public function canCreate($member = null, $context = [])
    {
        return false;
        //return Permission::check('Product_ORDERS');
    }

    public function canDelete($member = null)
    {
        return Permission::check('Product_ORDERS', 'any', $member);
    }
}