dynamic / foxystripe

src/Admin/FoxyStripeAdmin.php

<?php

namespace Dynamic\FoxyStripe\Admin;

use Dynamic\FoxyStripe\Model\FoxyStripeSetting;
use SilverStripe\Admin\LeftAndMain;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Control\Director;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\HiddenField;
use SilverStripe\Forms\LiteralField;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\ValidationException;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\View\ArrayData;
use SilverStripe\View\Requirements;

class FoxyStripeAdmin extends LeftAndMain
{
    /**
     * @var string
     */
    private static $url_segment = 'foxystripe';

The private property $url_segment is not used, and could be removed.

    /**
     * @var string
     */
    private static $url_rule = '/$Action/$ID/$OtherID';

The private property $url_rule is not used, and could be removed.

    /**
     * @var int
     */
    private static $menu_priority = 4;

The private property $menu_priority is not used, and could be removed.

    /**
     * @var string
     */
    private static $menu_title = 'FoxyStripe';

The private property $menu_title is not used, and could be removed.

    /**
     * @var string
     */
    private static $menu_icon_class = 'font-icon-cog';

The private property $menu_icon_class is not used, and could be removed.

    /**
     * @var string
     */
    private static $tree_class = FoxyStripeSetting::class;

The private property $tree_class is not used, and could be removed.

    /**
     * @var array
     */
    private static $required_permission_codes = ['EDIT_GLOBAL_PERMISSION'];

The private property $required_permission_codes is not used, and could be removed.

    /**
     * Initialises the {@link FoxyStripeSetting} controller.
     */
    public function init()
    {
        parent::init();

        Requirements::javascript('silverstripe/cms: client/dist/js/bundle.js');
    }

    /**
     * @param null $id

Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?

     * @param null $fields

Are you sure the doc-type for parameter $fields is correct as it would always require null to be passed?

     *
     * @return $this|Form
     */
    public function getEditForm($id = null, $fields = null)
    {
        $config = FoxyStripeSetting::current_foxystripe_setting();
        $fields = $config->getCMSFields();

        // Tell the CMS what URL the preview should show
        $home = Director::absoluteBaseURL();
        $fields->push(new HiddenField('PreviewURL', 'Preview URL', $home));

        // Added in-line to the form, but plucked into different view by LeftAndMain.Preview.js upon load
        $fields->push($navField = new LiteralField(
            'SilverStripeNavigator',
            $this->getSilverStripeNavigator()
        ));
        $navField->setAllowHTML(true);

        // Retrieve validator, if one has been setup (e.g. via data extensions).
        if ($config->hasMethod('getCMSValidator')) {
            $validator = $config->getCMSValidator();

The method getCMSValidator() does not exist on Dynamic\FoxyStripe\Model\FoxyStripeSetting. Since you implemented __call, consider adding a @method annotation.

        } else {
            $validator = null;
        }

        $actions = $config->getCMSActions();
        $negotiator = $this->getResponseNegotiator();
        $form = Form::create(
            $this,
            'EditForm',
            $fields,
            $actions,
            $validator
        )->setHTMLID('Form_EditForm');
        $form->setValidationResponseCallback(function (ValidationResult $errors) use ($negotiator, $form) {

The parameter $errors is not used and could be removed.

            $request = $this->getRequest();
            if ($request->isAjax() && $negotiator) {
                $result = $form->forTemplate();

                return $negotiator->respond($request, array(
                    'CurrentForm' => function () use ($result) {
                        return $result;
                    },
                ));
            }
            return null;
        });
        $form->addExtraClass('flexbox-area-grow fill-height cms-content cms-edit-form');
        $form->setAttribute('data-pjax-fragment', 'CurrentForm');

        if ($form->Fields()->hasTabSet()) {
            $form->Fields()->findOrMakeTab('Root')->setTemplate('SilverStripe\\Forms\\CMSTabSet');
        }
        $form->setHTMLID('Form_EditForm');
        $form->loadDataFrom($config);
        $form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));

        // Use <button> to allow full jQuery UI styling
        $actions = $actions->dataFields();
        if ($actions) {

The expression $actions of type SilverStripe\Forms\FormField[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            /** @var FormAction $action */
            foreach ($actions as $action) {
                $action->setUseButtonTag(true);
            }
        }

        $this->extend('updateEditForm', $form);

        return $form;
    }

    /**
     * Save the current sites {@link FoxyStripeSetting} into the database.
     *
     * @param $data
     * @param $form
     *
     * @return \SilverStripe\Control\HTTPResponse
     * @throws \SilverStripe\Control\HTTPResponse_Exception
     */
    public function save_foxystripe_setting($data, $form)

The parameter $data is not used and could be removed.

    {
        $config = FoxyStripeSetting::current_foxystripe_setting();
        $form->saveInto($config);
        try {
            $config->write();
        } catch (ValidationException $ex) {
            $form->sessionMessage($ex->getResult()->message(), 'bad');

The method message() does not exist on SilverStripe\ORM\ValidationResult.

            return $this->getResponseNegotiator()->respond($this->request);
        }
        $this->response->addHeader('X-Status', rawurlencode(_t('SilverStripe\\Admin\\LeftAndMain.SAVEDUP', 'Saved.')));

        return $form->forTemplate();
    }

    /**
     * @param bool $unlinked
     *
     * @return ArrayList
     */
    public function Breadcrumbs($unlinked = false)
    {
        return new ArrayList(array(
            new ArrayData(array(
                'Title' => static::menu_title(),
                'Link' => $this->Link(),
            )),
        ));
    }
}