QuantityField::newvalue() - Code Metrics - Inspection of "ENHANCEMENT QuantityField" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#358)

by Nic

created 2018-11-14 16:43 UTC

QuantityField::newvalue() A

↳ Parent: QuantityField

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	11
ccs	0
cts	6
cp	0
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	12

<?php

namespace Dynamic\FoxyStripe\Form;

use Dynamic\FoxyStripe\Model\FoxyStripeSetting;
use Dynamic\FoxyStripe\Page\ProductPage;
use SilverStripe\Control\Controller;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Forms\NumericField;
use SilverStripe\View\Requirements;

/**
 * Class QuantityField
 * @package Dynamic\FoxyStripe\Form
 */
class QuantityField extends NumericField
{
    /**
     * @var array
     */
    private static $allowed_actions = [

        'newvalue',
    ];

    /**
     * @param array $properties
     * @return string
     */
    public function Field($properties = [])
    {
        //Requirements::javascript('dynamic/foxystripe: javascript/quantity.js');

        //Requirements::css('dynamic/foxystripe: client/dist/css/quantityfield.css');



        $this->setAttribute('data-link', $this->Link('newvalue'));
        $this->setAttribute('data-code', $this->getForm()->getProduct()->Code);
        $this->setAttribute('data-id', $this->getForm()->getProduct()->ID);

        return parent::Field($properties);
    }

    /**
     * @param SS_HTTPRequest $request
filter:
    dependency_paths: ["lib/*"]
     * @return bool|string
     */
    public function newvalue(HTTPRequest $request)
    {
        if (!$value = $request->getVar('value')) {
            return '';
        }

        if (!$code = $request->getVar('code')) {
            return '';
        }

        return ProductPage::getGeneratedValue($code, 'quantity', $value, 'value');
    }
}


1			<?php
2
3			namespace Dynamic\FoxyStripe\Form;
4
5			use Dynamic\FoxyStripe\Model\FoxyStripeSetting;
6			use Dynamic\FoxyStripe\Page\ProductPage;
7			use SilverStripe\Control\Controller;
8			use SilverStripe\Control\HTTPRequest;
9			use SilverStripe\Forms\NumericField;
10			use SilverStripe\View\Requirements;
11
12			/**
13			* Class QuantityField
14			* @package Dynamic\FoxyStripe\Form
15			*/
16			class QuantityField extends NumericField
17			{
18			/**
19			* @var array
20			*/
21			private static $allowed_actions = [
			0 ignored issues – show introduced 2018-11-14 04:07 UTC by Report Bug Copy Issue Report The private property `$allowed_actions` is not used, and could be removed. Loading history...
22			'newvalue',
23			];
24
25			/**
26			* @param array $properties
27			* @return string
28			*/
29			public function Field($properties = [])
30			{
31			//Requirements::javascript('dynamic/foxystripe: javascript/quantity.js');
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-11-14 04:07 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32			//Requirements::css('dynamic/foxystripe: client/dist/css/quantityfield.css');
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-11-14 06:45 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33
34
35			$this->setAttribute('data-link', $this->Link('newvalue'));
36			$this->setAttribute('data-code', $this->getForm()->getProduct()->Code);
37			$this->setAttribute('data-id', $this->getForm()->getProduct()->ID);
38
39			return parent::Field($properties);
40			}
41
42			/**
43			* @param SS_HTTPRequest $request
			0 ignored issues – show Bug introduced 2018-11-14 04:07 UTC by Report Bug Copy Issue Report The type `Dynamic\FoxyStripe\Form\SS_HTTPRequest` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
44			* @return bool\|string
45			*/
46			public function newvalue(HTTPRequest $request)
47			{
48			if (!$value = $request->getVar('value')) {
49			return '';
50			}
51
52			if (!$code = $request->getVar('code')) {
53			return '';
54			}
55
56			return ProductPage::getGeneratedValue($code, 'quantity', $value, 'value');
57			}
58			}
59

dynamic / foxystripe

Pull Request — master (#358)

QuantityField::newvalue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like