FoxyStripePurchaseForm::getProductFields() - Code Metrics - Inspection of "REFACTOR product model" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#287)

by Nic
created 2016-10-06 20:15 UTC
FoxyStripePurchaseForm::getProductFields() B

↳ Parent: FoxyStripePurchaseForm
Complexity

Conditions	8
Paths	18
Size

Total Lines	58
Code Lines	40
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	58
rs	7.1977
c	0
b	0
f	0
cc	8
eloc	40
nc	18
nop	1
How to fix Long Method

<?php

/**
 * Class FoxyStripePurchaseForm
 *
 * @property SiteConfig $site_config
 * @property FoxyStripeProduct $product
 *
 */
class FoxyStripePurchaseForm extends Form
{

    /**
     * @var
     */
    protected $site_config;
    /**
     * @var
     */
    private $product;

    /**
     * @param $siteConfig
     * @return $this
     */
    public function setSiteConfig($siteConfig)
    {
        $siteConfig = $siteConfig === null ? SiteConfig::current_site_config() : $siteConfig;
        if ($siteConfig instanceof SiteConfig) {
            $this->site_config = $siteConfig;
            return $this;
        }
        throw new InvalidArgumentException('$siteConfig needs to be an instance of SiteConfig.');
    }

    /**
     * @return SiteConfig
     */
    public function getSiteConfig()
    {
        if (!$this->site_config) {
            $this->setSiteConfig(SiteConfig::current_site_config());
        }
        return $this->site_config;
    }

    /**
     * @param $product
     * @return $this
     */
    public function setProduct($product)
    {
        if ($product instanceof FoxyStripeProduct) {
            $this->product = $product;
            return $this;
        }
        throw new InvalidArgumentException('$product needs to be an instance of FoxyStripeProduct.');
    }

    /**
     * @return FoxyStripeProduct
     */
    public function getProduct()
    {
        return $this->product;
    }

    /**
     * FoxyStripePurchaseForm constructor.
     * @param Controller $controller
     * @param string $name
     * @param FieldList|null $fields
     * @param FieldList|null $actions
     * @param null $validator
     * @param null $product
     * @param null $siteConfig
     */
    public function __construct(
        $controller,
        $name,
        FieldList $fields = null,
        FieldList $actions = null,
        $validator = null,
        $product = null,
        $siteConfig = null
    )
    {
        $this->setProduct($product);
        $this->setSiteConfig($siteConfig);

        $fields = ($fields != null && $fields->exists()) ? $this->getProductFields($fields) : $this->getProductFields(FieldList::create());

        $actions = ($actions != null && $actions->exists()) ? $this->getProductActions($actions) : $this->getProductActions(FieldList::create());
        $validator = (!empty($validator) || $validator != null) ? $validator : RequiredFields::create();

        Requirements::javascript("framework/thirdparty/jquery/jquery.js");
        if ($product->Available && $product->ProductOptions()->exists()) {
            Requirements::javascript("foxystripe/javascript/outOfStock.min.js");
            Requirements::javascript("foxystripe/javascript/ProductOptions.min.js");
        }

        Requirements::customScript(<<<JS
		var productID = {$product->ID};
JS
        );

        parent::__construct($controller, $name, $fields, $actions, $validator);

        //have to call after parent::__construct()
        $this->setAttribute('action', FoxyCart::FormActionURL());
        $this->disableSecurityToken();

    }

    /**
     * @param FieldList $fields
     * @return FieldList
     */
    protected function getProductFields(FieldList $fields)
    {
        $hiddenTitle = ($this->product->ReceiptTitle) ? htmlspecialchars($this->product->ReceiptTitle) : htmlspecialchars($this->product->Title);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $code = $this->product->Code;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->product->Available) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'name',
                $hiddenTitle))->setValue($hiddenTitle));
            $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'category',
                $this->product->Category()->Code))->setValue($this->product->Category()->Code));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'code',
                $this->product->Code))->setValue($this->product->Code));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'product_id',
                $this->product->ID))->setValue($this->product->ID));
            $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'price',
                $this->product->Price))->setValue($this->product->Price));//can't override id
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'weight',
                $this->product->Weight))->setValue($this->product->Weight));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($this->DiscountTitle && $this->ProductDiscountTiers()->exists()) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $fields->push(HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'discount_quantity_percentage',
                    $this->product->getDiscountFieldValue()))->setValue($this->product->getDiscountFieldValue()));
            }


            if ($this->product->PreviewImage()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $fields->push(
                    HiddenField::create(FoxyStripeProduct::getGeneratedValue($code, 'image',
                        $this->product->PreviewImage()->PaddedImage(80, 80)->absoluteURL))
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        ->setValue($this->product->PreviewImage()->PaddedImage(80, 80)->absoluteURL)
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                );
            }

            $optionsSet = $this->getProductOptionSet();
            $fields->push($optionsSet);

            $quantityMax = ($this->site_config->MaxQuantity) ? $this->site_config->MaxQuantity : 10;
            $count = 1;
            $quantity = array();
            while ($count <= $quantityMax) {
                $countVal = FoxyStripeProduct::getGeneratedValue($this->product->Code, 'quantity', $count, 'value');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $quantity[$countVal] = $count;
                $count++;
            }

            $fields->push(DropdownField::create('quantity', 'Quantity', $quantity));

            $fields->push(HeaderField::create('submitPrice', '$' . $this->product->Price, 4));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}


            $this->extend('updatePurchaseFormFields', $fields);
        } else {
            $fields->push(HeaderField::create('submitPrice', 'Currently Out of Stock'), 4);

        }

        $this->extend('updateFoxyStripePurchaseFormFields', $fields);

        return $fields;
    }

    /**
     * @param FieldList $actions
     * @return FieldList
     */
    protected function getProductActions(FieldList $actions)
    {

        $actions->push($submit = FormAction::create(
            '',
            _t('ProductForm.AddToCart', 'Add to Cart')
        ));
        $submit->setAttribute('name',
            FoxyStripeProduct::getGeneratedValue($this->product->Code, 'Submit', _t('ProductForm.AddToCart', 'Add to Cart')));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (!$this->site_config->StoreName || $this->site_config->StoreName == '' || !isset($this->site_config->StoreName) || !$this->product->Available) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $submit->setAttribute('Disabled', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $this->extend('updateFoxyStripePurchaseFormActions', $fields);

        return $actions;
    }

    /**
     * @return CompositeField
     */
    protected function getProductOptionSet()
    {

        $assignAvailable = function ($self) {
            $this->extend('updateFoxyStripePurchaseForm', $form);
            $self->Available = ($self->getAvailability()) ? true : false;
        };

        $options = $this->product->ProductOptions();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $groupedOptions = new GroupedList($options);
        $groupedBy = $groupedOptions->groupBy('ProductOptionGroupID');

        $optionsSet = CompositeField::create();

        foreach ($groupedBy as $id => $set) {
            $group = OptionGroup::get()->byID($id);
            $title = $group->Title;
            $name = preg_replace('/\s/', '_', $title);
            $set->each($assignAvailable);
            $disabled = array();
            $fullOptions = array();
            foreach ($set as $item) {
                $fullOptions[FoxyStripeProduct::getGeneratedValue($this->product->Code, $group->Title,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    $item->getGeneratedValue(),
                    'value')] = $item->getGeneratedTitle();
                if (!$item->Availability) {
                    array_push($disabled,
                        FoxyStripeProduct::getGeneratedValue($this->product->Code, $group->Title, $item->getGeneratedValue(),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            'value'));
                }
            }
            $optionsSet->push(
                $dropdown = DropdownField::create($name, $title, $fullOptions)->setTitle($title)
            );
            $dropdown->setDisabledItems($disabled);
        }

        $optionsSet->addExtraClass('foxycartOptionsContainer');

        return $optionsSet;
    }

}
dynamic / foxystripe

Pull Request — master (#287)

FoxyStripePurchaseForm::getProductFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
