| @@ -43,6 +43,9 @@ | ||
| 43 | 43 | self::setSecret(FoxyCart::getStoreKey()); | 
| 44 | 44 | } | 
| 45 | 45 | |
| 46 | + /** | |
| 47 | + * @return string | |
| 48 | + */ | |
| 46 | 49 |  	public static function getSecret(){ | 
| 47 | 50 | return FoxyCart::getStoreKey(); | 
| 48 | 51 | } | 
| @@ -269,7 +269,9 @@ | ||
| 269 | 269 | self::$log[] = '<strong>Options:</strong> <pre>'.htmlspecialchars(print_r($options, true)).'</pre>'; | 
| 270 | 270 | unset( $form_part_signed ); | 
| 271 | 271 |  					foreach ($options as $option) { | 
| 272 | - if( !isset($form_part_signed) ) $form_part_signed = $list[0]; | |
| 272 | +						if( !isset($form_part_signed) ) { | |
| 273 | + $form_part_signed = $list[0]; | |
| 274 | + } | |
| 273 | 275 | $option_signed = preg_replace( | 
| 274 | 276 | '%'.preg_quote($option[1]).preg_quote($option[2]).preg_quote($option[1]).'%', | 
| 275 | 277 | $option[1].self::fc_hash_value($code, $list[2], $option[2], 'value', FALSE).$option[1], | 
| @@ -34,6 +34,9 @@ discard block | ||
| 34 | 34 | } | 
| 35 | 35 | } | 
| 36 | 36 | |
| 37 | + /** | |
| 38 | + * @param string $encrypted | |
| 39 | + */ | |
| 37 | 40 |      public function handleDataFeed($encrypted, $decrypted){ | 
| 38 | 41 | //handle encrypted & decrypted data | 
| 39 | 42 | $orders = new SimpleXMLElement($decrypted); | 
| @@ -79,6 +82,10 @@ discard block | ||
| 79 | 82 | } | 
| 80 | 83 | } | 
| 81 | 84 | |
| 85 | + /** | |
| 86 | + * @param SimpleXMLElement $orders | |
| 87 | + * @param DataObject $transaction | |
| 88 | + */ | |
| 82 | 89 |      public function parseOrderInfo($orders, $transaction) { | 
| 83 | 90 | |
| 84 | 91 |          foreach ($orders->transactions->transaction as $order) { | 
| @@ -95,6 +102,10 @@ discard block | ||
| 95 | 102 | } | 
| 96 | 103 | } | 
| 97 | 104 | |
| 105 | + /** | |
| 106 | + * @param SimpleXMLElement $orders | |
| 107 | + * @param DataObject $transaction | |
| 108 | + */ | |
| 98 | 109 |      public function parseOrderCustomer($orders, $transaction) { | 
| 99 | 110 | |
| 100 | 111 |          foreach ($orders->transactions->transaction as $order) { | 
| @@ -133,6 +144,10 @@ discard block | ||
| 133 | 144 | } | 
| 134 | 145 | } | 
| 135 | 146 | |
| 147 | + /** | |
| 148 | + * @param SimpleXMLElement $orders | |
| 149 | + * @param DataObject $transaction | |
| 150 | + */ | |
| 136 | 151 |      public function parseOrderDetails($orders, $transaction) { | 
| 137 | 152 | |
| 138 | 153 | // remove previous OrderDetails so we don't end up with duplicates | 
| @@ -20,7 +20,7 @@ | ||
| 20 | 20 | private $product; | 
| 21 | 21 | |
| 22 | 22 | /** | 
| 23 | - * @param $siteConfig | |
| 23 | + * @param SiteConfig|null $siteConfig | |
| 24 | 24 | * @return $this | 
| 25 | 25 | */ | 
| 26 | 26 | public function setSiteConfig($siteConfig) | 
| @@ -81,13 +81,17 @@ discard block | ||
| 81 | 81 |      public static function getCustomer($Member = null) { | 
| 82 | 82 | |
| 83 | 83 | // throw error if no $Member Object | 
| 84 | -        if (!isset($Member)) trigger_error('No Member set', E_USER_ERROR); | |
| 84 | +        if (!isset($Member)) { | |
| 85 | +            trigger_error('No Member set', E_USER_ERROR); | |
| 86 | + } | |
| 85 | 87 | |
| 86 | 88 | // grab customer record from API | 
| 87 | 89 | |
| 88 | 90 | $foxyData = array(); | 
| 89 | 91 | $foxyData["api_action"] = "customer_get"; | 
| 90 | - if ($Member->Customer_ID) $foxyData["customer_id"] = $Member->Customer_ID; | |
| 92 | +        if ($Member->Customer_ID) { | |
| 93 | + $foxyData["customer_id"] = $Member->Customer_ID; | |
| 94 | + } | |
| 91 | 95 | $foxyData["customer_email"] = $Member->Email; | 
| 92 | 96 | |
| 93 | 97 | return self::getAPIRequest($foxyData); | 
| @@ -102,7 +106,9 @@ discard block | ||
| 102 | 106 | $foxyData = array(); | 
| 103 | 107 | $foxyData["api_action"] = "customer_save"; | 
| 104 | 108 | // customer_id will be 0 if created in SilverStripe. | 
| 105 | - if ($Member->Customer_ID) $foxyData["customer_id"] = $Member->Customer_ID; | |
| 109 | +        if ($Member->Customer_ID) { | |
| 110 | + $foxyData["customer_id"] = $Member->Customer_ID; | |
| 111 | + } | |
| 106 | 112 | $foxyData["customer_email"] = $Member->Email; | 
| 107 | 113 | $foxyData["customer_password_hash"] = $Member->Password; | 
| 108 | 114 | $foxyData["customer_password_salt"] = $Member->Salt; | 
| @@ -41,14 +41,18 @@ | ||
| 41 | 41 | |
| 42 | 42 |  		$versions = DB::query('Select * FROM "ProductPage_versions" WHERE "RecordID" = '. $productID); | 
| 43 | 43 | $versionsPostPublish = array(); | 
| 44 | - foreach($versions as $versionRow) $versionsPostPublish[] = $versionRow; | |
| 44 | +		foreach($versions as $versionRow) { | |
| 45 | + $versionsPostPublish[] = $versionRow; | |
| 46 | + } | |
| 45 | 47 | |
| 46 | 48 | $product2->delete(); | 
| 47 | 49 | $this->assertTrue(!$product2->isPublished()); | 
| 48 | 50 | |
| 49 | 51 |  		$versions = DB::query('Select * FROM "ProductPage_versions" WHERE "RecordID" = '. $productID); | 
| 50 | 52 | $versionsPostDelete = array(); | 
| 51 | - foreach($versions as $versionRow) $versionsPostDelete[] = $versionRow; | |
| 53 | +		foreach($versions as $versionRow) { | |
| 54 | + $versionsPostDelete[] = $versionRow; | |
| 55 | + } | |
| 52 | 56 | |
| 53 | 57 | $this->assertTrue($versionsPostPublish == $versionsPostDelete); | 
| 54 | 58 | |
| @@ -123,7 +123,7 @@ | ||
| 123 | 123 | * Products function. | 
| 124 | 124 | * | 
| 125 | 125 | * @access public | 
| 126 | - * @return array | |
| 126 | + * @return PaginatedList | |
| 127 | 127 | */ | 
| 128 | 128 | public function ProductList($limit = 10) | 
| 129 | 129 |      { | 
| @@ -285,7 +285,7 @@ | ||
| 285 | 285 | } | 
| 286 | 286 | |
| 287 | 287 | /** | 
| 288 | - * @return mixed|string | |
| 288 | + * @return string | |
| 289 | 289 | */ | 
| 290 | 290 | public function getGeneratedTitle() | 
| 291 | 291 |      { |