FoxyStripeProductTest::testProductCreation() - Code Metrics - Inspection of "REFACTOR product model" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#287)

by Nic

created 2016-10-01 21:10 UTC

FoxyStripeProductTest::testProductCreation() A

↳ Parent: FoxyStripeProductTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php

/**
 * Class FoxyStripeProductTest
 */
class FoxyStripeProductTest extends SapphireTest
{

    /**
     * @var string
     */
    protected static $fixture_file = 'foxystripe/tests/FoxyStripeTest.yml';

    /**
     *
     */
    function setUp()

    {
        parent::setUp();

        $groupForItem = OptionGroup::create();
        $groupForItem->Title = 'Sample-Group';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $groupForItem->write();

        $productHolder = ProductHolder::create();
        $productHolder->Title = 'Product Holder';
        $productHolder->write();
    }

    /**
     *
     */
    function testProductCreation()

    {

        //$this->logInWithPermission('Product_CANCRUD');

        $default = $this->objFromFixture('FoxyCartProductCategory', 'default');
        $default->write();

    }

    /**
     *
     */
    function testProductDeletion()

    {

        //$this->logInWithPermission('Product_CANCRUD');

        $product2 = $this->objFromFixture('ShippableProduct', 'product2');
        $product2->ParentID = ProductHolder::get()->first()->ID;
        $productID = $product2->ID;

        $product2->doPublish();
        $this->assertTrue($product2->isPublished());


        $versions = DB::query('Select * FROM "ShippableProduct_versions" WHERE "RecordID" = ' . $productID);
        $versionsPostPublish = array();
        foreach ($versions as $versionRow) $versionsPostPublish[] = $versionRow;

        $product2->delete();
        $this->assertTrue(!$product2->isPublished());


        $versions = DB::query('Select * FROM "ShippableProduct_versions" WHERE "RecordID" = ' . $productID);
        $versionsPostDelete = array();
        foreach ($versions as $versionRow) $versionsPostDelete[] = $versionRow;

        $this->assertEquals($versionsPostPublish, $versionsPostDelete);


    }

    /**
     *
     */
    function testProductTitleLeadingWhiteSpace()

    {

        //$this->logInWithPermission('ADMIN');

        $product = $this->objFromFixture('ShippableProduct', 'product1');
        $product->Title = " Test with leading space";
        $product->ParentID = ProductHolder::get()->first()->ID;
        $product->write();

        $this->assertEquals($product->Title, 'Test with leading space');


    }

    /**
     *
     */
    function testProductTitleTrailingWhiteSpace()

    {

        //$this->logInWithPermission('ADMIN');

        $product = $this->objFromFixture('ShippableProduct', 'product1');
        $product->Title = "Test with trailing space ";
        $product->ParentID = ProductHolder::get()->first()->ID;
        $product->write();

        $this->assertEquals($product->Title, 'Test with trailing space');


    }

    /**
     *
     */
    function testFoxyCartProductCategoryCreation()

    {

        //$this->logInWithPermission('Product_CANCRUD');

        $category = $this->objFromFixture('FoxyCartProductCategory', 'apparel');
        $category->write();
        $categoryID = $category->ID;

        $FoxyCartProductCategory = FoxyCartProductCategory::get()->filter(array('Code' => 'APPAREL'))->first();

        $this->assertEquals($categoryID, $FoxyCartProductCategory->ID);


    }

    /**
     *
     */
    function testFoxyCartProductCategoryDeletion()

    {

        //$this->logInWithPermission('Product_CANCRUD');

        $category = $this->objFromFixture('FoxyCartProductCategory', 'default');
        $category->write();

        $this->assertFalse($category->canDelete());


        $category2 = $this->objFromFixture('FoxyCartProductCategory', 'apparel');
        $category2->write();
        $category2ID = $category2->ID;

        $this->assertTrue($category2->canDelete());


        //$this->logOut();


        //$this->logInWithPermission('ADMIN');


        $this->assertFalse($category->canDelete());

        $this->assertTrue($category2->canDelete());


        //$this->logOut();

        //$this->logInWithPermission('Product_CANCRUD');


        $category2->delete();

        $this->assertFalse(in_array($category2ID, FoxyCartProductCategory::get()->column('ID')));


    }

    /**
     *
     */
    function testOptionGroupCreation()

    {

        //$this->logInWithPermission('Product_CANCRUD');

        $group = $this->objFromFixture('OptionGroup', 'size');
        $group->write();

        $this->assertNotNull(OptionGroup::get()->first());


    }

    /**
     *
     */
    function testOptionGroupDeletion()

    {

        //$this->logInWithPermission('ADMIN');

        $group = $this->objFromFixture('OptionGroup', 'color');
        $group->write();
        $groupID = $group->ID;

        $this->assertTrue($group->canDelete());


        //$this->logOut();

        //$this->logInWithPermission('Product_CANCRUD');


        $this->assertTrue($group->canDelete());

        $group->delete();

        $this->assertFalse(in_array($groupID, OptionGroup::get()->column('ID')));


    }

    /**
     *
     */
    function testOptionItemCreation()

    {

        //$this->logInWithPermission('Product_CANCRUD');

        $optionGroup = OptionGroup::get()->filter(array('Title' => 'Sample-Group'))->first();
        $option = $this->objFromFixture('OptionItem', 'large');
        $option->ProductOptionGroupID = $optionGroup->ID;
        $option->write();
        $optionID = $option->ID;

        $optionItem = OptionItem::get()->filter(array('ProductOptionGroupID' => $optionGroup->ID))->first();

        $this->assertEquals($optionID, $optionItem->ID);


    }

    /**
     *
     */
    function testOptionItemDeletion()

    {

        //$this->logInWithPermission('ADMIN');

        $optionGroup = (OptionGroup::get()->first())
            ? OptionGroup::get()->first()
            : OptionGroup::create();
        if ($optionGroup->ID == 0) {
            $optionGroup->Title = 'Size';
            $optionGroup->write();
        }
        $option = $this->objFromFixture('OptionItem', 'small');
        $option->ProductOptionGroupID = $optionGroup->ID;
        $option->write();
        $optionID = $option->ID;

        $this->assertTrue($option->canDelete());


        //$this->logOut();

        //$this->logInWithPermission('Product_CANCRUD');


        $this->assertTrue($option->canDelete());

        $option->delete();

        $this->assertFalse(in_array($optionID, OptionItem::get()->column('ID')));


    }

}


1		<?php
2
3		/**
4		* Class FoxyStripeProductTest
5		*/
6		class FoxyStripeProductTest extends SapphireTest
7		{
8
9		/**
10		* @var string
11		*/
12		protected static $fixture_file = 'foxystripe/tests/FoxyStripeTest.yml';
13
14		/**
15		*
16		*/
17	View Code Duplication	function setUp()
		0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2016-10-01 20:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		parent::setUp();
20
21		$groupForItem = OptionGroup::create();
22		$groupForItem->Title = 'Sample-Group';
		0 ignored issues – show Documentation introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<OptionGroup>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23		$groupForItem->write();
24
25		$productHolder = ProductHolder::create();
26		$productHolder->Title = 'Product Holder';
27		$productHolder->write();
28		}
29
30		/**
31		*
32		*/
33		function testProductCreation()
		0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
34		{
35
36		//$this->logInWithPermission('Product_CANCRUD');
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-01 20:25 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...

dynamic / foxystripe

Pull Request — master (#287)

FoxyStripeProductTest::testProductCreation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like