ProductHolder

Complexity

Total Complexity

16

Size/Duplication

Total Lines	155
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

9.84%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	27	4
A	Products()	0	4	1
A	loadDescendantProductGroupIDListInto()	0	15	5
A	ProductGroupIDs()	0	6	1
A	ProductList()	0	35	5

<?php
/**
 *
 * @package FoxyStripe
 *
 */

class ProductHolder extends Page
{
    /**
     * @var string
     */
    private static $singular_name = 'Product Group';

    /**
     * @var string
     */
    private static $plural_name = 'Product Groups';

    /**
     * @var string
     */
    private static $description = 'Display a list of related products';

    /**
     * @var array
     */
    private static $many_many = array(
        'Products' => 'ProductPage'
    );

    /**
     * @var array
     */
    private static $many_many_extraFields = array(
        'Products' => array(
            'SortOrder' => 'Int'
        )
    );

    /**
     * @var array
     */
    private static $allowed_children = array('ProductHolder', 'ProductPage');

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        if (SiteConfig::current_site_config()->MultiGroup) {
            $config = GridFieldConfig_RelationEditor::create();
            if (class_exists('GridFieldSortableRows')) {
                $config->addComponent(new GridFieldSortableRows('SortOrder'));
            }
            if (class_exists('GridFieldAddExistingSearchButton')) {
                $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
                $config->addComponent(new GridFieldAddExistingSearchButton());
            }
            $config->removeComponentsByType('GridFieldAddNewButton');
            $fields->addFieldToTab(
                'Root.Products',
                GridField::create(
                    'Products',
                    _t('ProductHolder.Products', 'Products'),
                    $this->Products(),
                    $config
                )
            );
        }

        return $fields;
    }

    /**
     * @return DataList
     */
    public function Products()
    {
        return $this->getManyManyComponents('Products')->sort('SortOrder');
    }

    /**
     * loadDescendantProductGroupIDListInto function.
     * 
     * @access public
     * @param mixed &$idList
     * @return void
     */
    public function loadDescendantProductGroupIDListInto(&$idList)
    {
        if ($children = $this->AllChildren()) {
            foreach ($children as $child) {
                if (in_array($child->ID, $idList)) {
                    continue;
                }
                
                if ($child instanceof ProductHolder) {
                    $idList[] = $child->ID;
                    $child->loadDescendantProductGroupIDListInto($idList);
                }
            }
        }
    }
    
    /**
     * ProductGroupIDs function.
     * 
     * @access public
     * @return array
     */
    public function ProductGroupIDs()
    {
        $holderIDs = array();
        $this->loadDescendantProductGroupIDListInto($holderIDs);
        return $holderIDs;
    }
    
    /**
     * Products function.
     * 
     * @access public
     * @return array
     */
    public function ProductList($limit = 10)
    {
        $config = SiteConfig::current_site_config();

        if ($config->ProductLimit>0) {
            $limit = $config->ProductLimit;
        }

        if ($config->MultiGroup) {
            $entries = $this->Products()->sort('SortOrder');
        } else {
            $filter = '"ParentID" = ' . $this->ID;

            // Build a list of all IDs for ProductGroups that are children
            $holderIDs = $this->ProductGroupIDs();

            // If no ProductHolders, no ProductPages. So return false
            if ($holderIDs) {

The expression $holderIDs of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                // Otherwise, do the actual query
                if ($filter) {
                    $filter .= ' OR ';
                }
                $filter .= '"ParentID" IN (' . implode(',', $holderIDs) . ")";
            }

            $order = '"SiteTree"."Title" ASC';

$order is not used, you could remove the assignment.

            $entries = ProductPage::get()->where($filter);
        }


        $list = new PaginatedList($entries, Controller::curr()->request);

\Controller::curr()->request is of type object<SS_HTTPRequest>, but the function expects a array.

        $list->setPageLength($limit);
        return $list;
    }
}

class ProductHolder_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
}