FoxyStripeProductTest - Code Metrics - Inspection of "REFACTOR product model" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#287)

by Nic

created 2016-10-01 19:12 UTC

FoxyStripeProductTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	192
Duplicated Lines	11.46 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
wmc	15
lcom	1
cbo	7
dl	22
loc	192
rs	10
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	10	1
A	testProductCreation()	0	12	1
B	testProductDeletion()	0	24	3
A	testProductTitleLeadingWhiteSpace()	11	11	1
A	testProductTitleTrailingWhiteSpace()	11	11	1
A	testProductCategoryCreation()	0	12	1
B	testProductCategoryDeletion()	0	29	1
A	testOptionGroupCreation()	0	9	1
A	testOptionGroupDeletion()	0	18	1
A	testOptionItemCreation()	0	14	1
B	testOptionItemDeletion()	0	26	3

How to fix Duplicated Code

<?php

class FoxyStripeProductTest extends FunctionalTest {

	protected static $use_draft_site = true;

	function setUp(){


		$groupForItem = OptionGroup::create();
		$groupForItem->Title = 'Sample-Group';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$groupForItem->write();

		$productHolder = ProductHolder::create();
		$productHolder->Title = 'Product Holder';
		$productHolder->write();
	}

	function testProductCreation(){


		$this->logInWithPermission('Product_CANCRUD');
		$default = $this->objFromFixture('ProductCategory', 'default');
		$default->write();
		$product1 = $this->objFromFixture('FoxyStripeProduct', 'product1');
		$product1->ParentID = ProductHolder::get()->first()->ID;

		$product1->doPublish();
		$this->assertTrue($product1->isPublished());


	}

	function testProductDeletion(){


		$this->logInWithPermission('Product_CANCRUD');
		$product2 = $this->objFromFixture('FoxyStripeProduct', 'product2');
		$product2->ParentID = ProductHolder::get()->first()->ID;
		$productID = $product2->ID;

		$product2->doPublish();
		$this->assertTrue($product2->isPublished());


		$versions = DB::query('Select * FROM "FoxyStripeProduct_versions" WHERE "RecordID" = '. $productID);
		$versionsPostPublish = array();
		foreach($versions as $versionRow) $versionsPostPublish[] = $versionRow;

		$product2->delete();
		$this->assertTrue(!$product2->isPublished());


		$versions = DB::query('Select * FROM "FoxyStripeProduct_versions" WHERE "RecordID" = '. $productID);
		$versionsPostDelete = array();
		foreach($versions as $versionRow) $versionsPostDelete[] = $versionRow;

		$this->assertTrue($versionsPostPublish == $versionsPostDelete);


	}

	function testProductTitleLeadingWhiteSpace(){


		$this->logInWithPermission('ADMIN');
		$product = $this->objFromFixture('FoxyStripeProduct', 'product1');
		$product->Title = " Test with leading space";
		$product->ParentID = ProductHolder::get()->first()->ID;
		$product->doPublish();

		$this->assertTrue($product->Title == 'Test with leading space');


	}

	function testProductTitleTrailingWhiteSpace(){


		$this->logInWithPermission('ADMIN');
		$product = $this->objFromFixture('FoxyStripeProduct', 'product1');
		$product->Title = "Test with trailing space ";
		$product->ParentID = ProductHolder::get()->first()->ID;
		$product->doPublish();

		$this->assertTrue($product->Title == 'Test with trailing space');


	}

	function testProductCategoryCreation(){


		$this->logInWithPermission('Product_CANCRUD');
		$category = $this->objFromFixture('ProductCategory', 'apparel');
		$category->write();
		$categoryID = $category->ID;

		$productCategory = ProductCategory::get()->filter(array('Code'=>'APPAREL'))->first();

		$this->assertTrue($categoryID == $productCategory->ID);


	}

	function testProductCategoryDeletion(){


		$this->logInWithPermission('Product_CANCRUD');
		$category = $this->objFromFixture('ProductCategory', 'default');
		$category->write();

		$this->assertFalse($category->canDelete());


		$category2 = $this->objFromFixture('ProductCategory', 'apparel');
		$category2->write();
		$category2ID = $category2->ID;

		$this->assertTrue($category2->canDelete());


		$this->logOut();


		$this->logInWithPermission('ADMIN');

		$this->assertFalse($category->canDelete());

		$this->assertTrue($category2->canDelete());


		$this->logOut();

		$this->logInWithPermission('Product_CANCRUD');

		$category2->delete();

		$this->assertFalse(in_array($category2ID,FoxyCartProductCategory::get()->column('ID')));


	}

	function testOptionGroupCreation(){


		$this->logInWithPermission('Product_CANCRUD');
		$group = $this->objFromFixture('OptionGroup', 'size');
		$group->write();

		$this->assertNotNull(OptionGroup::get()->first());


	}

	function testOptionGroupDeletion(){


		$this->logInWithPermission('ADMIN');
		$group = $this->objFromFixture('OptionGroup', 'color');
		$group->write();
		$groupID = $group->ID;

		$this->assertTrue($group->canDelete());


		$this->logOut();

		$this->logInWithPermission('Product_CANCRUD');

		$this->assertTrue($group->canDelete());

		$group->delete();

		$this->assertFalse(in_array($groupID, OptionGroup::get()->column('ID')));


	}

	function testOptionItemCreation(){


		$this->logInWithPermission('Product_CANCRUD');
		$optionGroup = OptionGroup::get()->filter(array('Title' => 'Sample-Group'))->first();
		$option = $this->objFromFixture('OptionItem', 'large');
		$option->ProductOptionGroupID = $optionGroup->ID;
		$option->write();
		$optionID = $option->ID;

		$optionItem = OptionItem::get()->filter(array('ProductOptionGroupID' => $optionGroup->ID))->first();

		$this->assertEquals($optionID, $optionItem->ID);


	}

	function testOptionItemDeletion(){


		$this->logInWithPermission('ADMIN');
		$optionGroup = (OptionGroup::get()->first())
			? OptionGroup::get()->first()
			: OptionGroup::create();
		if($optionGroup->ID == 0){
			$optionGroup->Title = 'Size';
			$optionGroup->write();
		}
		$option = $this->objFromFixture('OptionItem', 'small');
		$option->ProductOptionGroupID = $optionGroup->ID;
		$option->write();
		$optionID = $option->ID;

		$this->assertTrue($option->canDelete());


		$this->logOut();

		$this->logInWithPermission('Product_CANCRUD');

		$this->assertTrue($option->canDelete());

		$option->delete();

		$this->assertFalse(in_array($optionID, OptionItem::get()->column('ID')));


	}

}


1			<?php
2
3			class FoxyStripeProductTest extends FunctionalTest {
4
5			protected static $use_draft_site = true;
6
7			function setUp(){
			0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
8
9			$groupForItem = OptionGroup::create();
10			$groupForItem->Title = 'Sample-Group';
			0 ignored issues – show Documentation introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<OptionGroup>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
11			$groupForItem->write();
12
13			$productHolder = ProductHolder::create();
14			$productHolder->Title = 'Product Holder';
15			$productHolder->write();
16			}
17
18			function testProductCreation(){
			0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
19
20			$this->logInWithPermission('Product_CANCRUD');
21			$default = $this->objFromFixture('ProductCategory', 'default');
22			$default->write();
23			$product1 = $this->objFromFixture('FoxyStripeProduct', 'product1');
24			$product1->ParentID = ProductHolder::get()->first()->ID;
25
26			$product1->doPublish();
27			$this->assertTrue($product1->isPublished());
			0 ignored issues – show Bug introduced 2016-10-01 19:16 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<FoxyStripeProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
28
29			}
30
31			function testProductDeletion(){
			0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
32
33			$this->logInWithPermission('Product_CANCRUD');
34			$product2 = $this->objFromFixture('FoxyStripeProduct', 'product2');
35			$product2->ParentID = ProductHolder::get()->first()->ID;

dynamic / foxystripe

Pull Request — master (#287)

FoxyStripeProductTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like