CustomerExtension::onBeforeWrite() - Code Metrics - Inspection of "Refactor/ss4" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#309)

by Jason

created 2018-03-03 21:36 UTC

CustomerExtension::onBeforeWrite() A

↳ Parent: CustomerExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	0

<?php

namespace Dynamic\FoxyStripe\ORM;

use Dynamic\FoxyStripe\Model\FoxyCart;
use Dynamic\FoxyStripe\Model\Order;
use SilverStripe\ORM\DataExtension;

class CustomerExtension extends DataExtension
{
    /**
     * @var array 
     */
    private static $db = array(

        'Customer_ID' => 'Int'
    );

    /**
     * @var array
     */
    private static $has_many = array(

        'Orders' => Order::class,
    );

    /**
     * @var array
     */
    private static $indexes = array(

        'Customer_ID' => true // make unique
    );

    /**
     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        // if Member data was imported from FoxyCart, PasswordEncryption will be set to 'none'.
        // Change to sh1_v2.4 to ensure SilverStripe is using the same hash as FoxyCart API 1.1
        $this->owner->PasswordEncryption = 'sha1_v2.4';

        // Send updated customer data to Foxy Cart via API
        $response = FoxyCart::putCustomer($this->owner);

        // Grab customer_id record from FoxyCart response, store in Member
        if ($response) {
            $foxyResponse = new \SimpleXMLElement($response);
            $this->owner->Customer_ID = (int) $foxyResponse->customer_id;
        }
    }
}


1			<?php
2
3			namespace Dynamic\FoxyStripe\ORM;
4
5			use Dynamic\FoxyStripe\Model\FoxyCart;
6			use Dynamic\FoxyStripe\Model\Order;
7			use SilverStripe\ORM\DataExtension;
8
9			class CustomerExtension extends DataExtension
10			{
11			/**
12			* @var array
13			*/
14			private static $db = array(
			0 ignored issues – show introduced 2018-03-03 21:50 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
15			'Customer_ID' => 'Int'
16			);
17
18			/**
19			* @var array
20			*/
21			private static $has_many = array(
			0 ignored issues – show introduced 2018-03-03 21:50 UTC by Report Bug Copy Issue Report The private property `$has_many` is not used, and could be removed. Loading history...
22			'Orders' => Order::class,
23			);
24
25			/**
26			* @var array
27			*/
28			private static $indexes = array(
			0 ignored issues – show introduced 2018-03-03 21:50 UTC by Report Bug Copy Issue Report The private property `$indexes` is not used, and could be removed. Loading history...
29			'Customer_ID' => true // make unique
30			);
31
32			/**
33			* @throws \Psr\Container\NotFoundExceptionInterface
34			*/
35			public function onBeforeWrite()
36			{
37			parent::onBeforeWrite();
38
39			// if Member data was imported from FoxyCart, PasswordEncryption will be set to 'none'.
40			// Change to sh1_v2.4 to ensure SilverStripe is using the same hash as FoxyCart API 1.1
41			$this->owner->PasswordEncryption = 'sha1_v2.4';
42
43			// Send updated customer data to Foxy Cart via API
44			$response = FoxyCart::putCustomer($this->owner);
45
46			// Grab customer_id record from FoxyCart response, store in Member
47			if ($response) {
48			$foxyResponse = new \SimpleXMLElement($response);
49			$this->owner->Customer_ID = (int) $foxyResponse->customer_id;
50			}
51			}
52			}
53

dynamic / foxystripe

Pull Request — master (#309)

CustomerExtension::onBeforeWrite() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like