Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 3 | namespace Dynamic\FoxyStripe\Test; |
||
| 4 | |||
| 5 | use Dynamic\FoxyStripe\Model\OrderDetail; |
||
| 6 | use SilverStripe\Dev\SapphireTest; |
||
| 7 | use SilverStripe\Forms\FieldList; |
||
| 8 | use SilverStripe\Security\Member; |
||
| 9 | |||
| 10 | class OrderDetailTest extends SapphireTest |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @var string |
||
| 14 | */ |
||
| 15 | protected static $fixture_file = 'fixtures.yml'; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * |
||
| 19 | */ |
||
| 20 | public function testGetCMSFields() |
||
| 21 | { |
||
| 22 | $object = singleton(OrderDetail::class); |
||
| 23 | $fields = $object->getCMSFields(); |
||
| 24 | $this->assertInstanceOf(FieldList::class, $fields); |
||
| 25 | $this->assertNull($fields->dataFieldByName('Options')); |
||
| 26 | |||
| 27 | $object = $this->objFromFixture(OrderDetail::class, 'one'); |
||
| 28 | $fields = $object->getCMSFields(); |
||
| 29 | $this->assertInstanceOf(FieldList::class, $fields); |
||
| 30 | $this->assertNotNull($fields->dataFieldByName('Options')); |
||
| 31 | } |
||
| 32 | |||
| 33 | /** |
||
| 34 | * |
||
| 35 | */ |
||
| 36 | public function testCanView() |
||
| 37 | { |
||
| 38 | $object = $this->objFromFixture(OrderDetail::class, 'one'); |
||
| 39 | $admin = $this->objFromFixture(Member::class, 'admin'); |
||
| 40 | $this->assertTrue($object->canView($admin)); |
||
| 41 | $member = $this->objFromFixture(Member::class, 'customer'); |
||
| 42 | $this->assertFalse($object->canView($member)); |
||
| 43 | } |
||
| 44 | |||
| 45 | /** |
||
| 46 | * |
||
| 47 | */ |
||
| 48 | public function testCanEdit() |
||
| 55 | } |
||
| 56 | |||
| 57 | /** |
||
| 58 | * |
||
| 59 | */ |
||
| 60 | public function testCanDelete() |
||
| 67 | } |
||
| 68 | |||
| 69 | /** |
||
| 70 | * |
||
| 71 | */ |
||
| 72 | public function testCanCreate() |
||
| 73 | { |
||
| 74 | $object = $this->objFromFixture(OrderDetail::class, 'one'); |
||
| 81 |