ProductPageTest::testProductTitleTrailingWhiteSpace() - Code Metrics - Inspection of "Merge branch '1.2'" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3228c3...282357 )

by Jason

created 2017-02-28 22:29 UTC

testProductTitleTrailingWhiteSpace() A

↳ Parent: ProductPageTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
dl	14
loc	14
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0

<?php

class ProductPageTest extends FS_Test{

	protected static $use_draft_site = true;

	function setUp(){

		parent::setUp();

		$groupForItem = OptionGroup::create();
		$groupForItem->Title = 'Sample-Group';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$groupForItem->write();

		/*$productHolder = ProductHolder::create();

		$productHolder->Title = 'Product Holder';
		$productHolder->write();*/
	}

	function testProductCreation(){


		$this->logInWithPermission('Product_CANCRUD');
		$default = $this->objFromFixture('ProductCategory', 'default');
		$default->write();
		$holder = $this->objFromFixture('ProductHolder', 'holder');
		$holder->doPublish();
		$product1 = $this->objFromFixture('ProductPage', 'product1');
		//$product1->ParentID = ProductHolder::get()->first()->ID;


		$product1->doPublish();
		$this->assertTrue($product1->isPublished());


	}

	function testProductDeletion(){


		$this->logInWithPermission('Product_CANCRUD');
		$holder = $this->objFromFixture('ProductHolder', 'holder');
		$holder->doPublish();
		$product2 = $this->objFromFixture('ProductPage', 'product2');
		$productID = $product2->ID;

		$product2->doPublish();
		$this->assertTrue($product2->isPublished());


		$versions = DB::query('Select * FROM "ProductPage_versions" WHERE "RecordID" = '. $productID);
		$versionsPostPublish = array();
		foreach($versions as $versionRow) $versionsPostPublish[] = $versionRow;

		$product2->delete();
		$this->assertTrue(!$product2->isPublished());


		$versions = DB::query('Select * FROM "ProductPage_versions" WHERE "RecordID" = '. $productID);
		$versionsPostDelete = array();
		foreach($versions as $versionRow) $versionsPostDelete[] = $versionRow;

		$this->assertTrue($versionsPostPublish == $versionsPostDelete);


	}

	function testProductTitleLeadingWhiteSpace(){


		$this->logInWithPermission('ADMIN');

		$holder = $this->objFromFixture('ProductHolder', 'holder');
		$holder->doPublish();

		$product = $this->objFromFixture('ProductPage', 'product1');
		$product->Title = " Test with leading space";
		$product->doPublish();

		$this->assertTrue($product->Title == 'Test with leading space');


	}

	function testProductTitleTrailingWhiteSpace(){


		$this->logInWithPermission('ADMIN');

		$holder = $this->objFromFixture('ProductHolder', 'holder');
		$holder->doPublish();

		$product = $this->objFromFixture('ProductPage', 'product1');
		$product->Title = "Test with trailing space ";
		$product->doPublish();

		$this->assertTrue($product->Title == 'Test with trailing space');


	}

	function testProductCategoryCreation(){


		$this->logInWithPermission('Product_CANCRUD');
		$category = $this->objFromFixture('ProductCategory', 'apparel');
		$category->write();
		$categoryID = $category->ID;

		$productCategory = ProductCategory::get()->filter(array('Code'=>'APPAREL'))->first();

		$this->assertTrue($categoryID == $productCategory->ID);


	}

	function testProductCategoryDeletion(){


		$this->logInWithPermission('Product_CANCRUD');

		$category = $this->objFromFixture('ProductCategory', 'default');
		$category->write();

		$this->assertFalse($category->canDelete());


		$category2 = $this->objFromFixture('ProductCategory', 'apparel');
		$category2->write();
		$category2ID = $category2->ID;

		$this->assertTrue($category2->canDelete());


		$this->logOut();

		$this->logInWithPermission('ADMIN');

		$this->assertFalse($category->canDelete());

		$this->assertTrue($category2->canDelete());


		$this->logOut();
		$this->logInWithPermission('Product_CANCRUD');

		$category2->delete();

		$this->assertFalse(in_array($category2ID,ProductCategory::get()->column('ID')));


	}

	function testOptionGroupCreation(){


		$this->logInWithPermission('Product_CANCRUD');

		$group = $this->objFromFixture('OptionGroup', 'size');
		$group->write();

		$this->assertNotNull(OptionGroup::get()->first());


	}

	function testOptionGroupDeletion(){


		$this->logInWithPermission('ADMIN');
		$group = $this->objFromFixture('OptionGroup', 'color');
		$group->write();
		$groupID = $group->ID;

		$this->assertTrue($group->canDelete());


		$this->logOut();
		$this->logInWithPermission('Product_CANCRUD');

		$this->assertTrue($group->canDelete());

		$group->delete();

		$this->assertFalse(in_array($groupID, OptionGroup::get()->column('ID')));


	}

	function testOptionItemCreation(){


		$this->logInWithPermission('Product_CANCRUD');

		$optionGroup = OptionGroup::get()->filter(array('Title' => 'Sample-Group'))->first();

		$option = $this->objFromFixture('OptionItem', 'large');
		$option->ProductOptionGroupID = $optionGroup->ID;
		$option->write();

		$optionID = $option->ID;

		$optionItem = OptionItem::get()->filter(array('ProductOptionGroupID' => $optionGroup->ID))->first();

		$this->assertEquals($optionID, $optionItem->ID);


	}

	function testOptionItemDeletion(){


		$this->logInWithPermission('ADMIN');

		$optionGroup = $this->objFromFixture('OptionGroup', 'size');
		$optionGroup->write();

		$option = $this->objFromFixture('OptionItem', 'small');
		$option->write();

		$optionID = $option->ID;

		$this->assertTrue($option->canDelete());


		$this->logOut();
		$this->logInWithPermission('Product_CANCRUD');

		$this->assertTrue($option->canDelete());

		$option->delete();

		$this->assertFalse(in_array($optionID, OptionItem::get()->column('ID')));


	}

	public function testProductDraftOptionDeletion(){

		self::$use_draft_site = false;//make sure we can publish

		$this->logInWithPermission('ADMIN');

		$holder = $this->objFromFixture('ProductHolder', 'holder');//build holder page, ProductPage can't be on root level
		$holder->doPublish();

		$product = $this->objFromFixture('ProductPage', 'product1');//build product page
		$product->doPublish();

		$productID = $product->ID;


		$optionGroup = $this->objFromFixture('OptionGroup', 'size');//build the group for the options
		$optionGroup->write();
		$option = $this->objFromFixture('OptionItem', 'small');//build first option
		$option->write();
		$option2 = $this->objFromFixture('OptionItem', 'large');//build second option
		$option2->write();

		$this->assertTrue($product->isPublished());//check that product is published


		$product->deleteFromStage('Stage');//remove product from draft site

		$this->assertTrue($product->isPublished());//check product is still published


		$testOption = OptionItem::get()->filter(array('Title' => 'Large', 'ProductID' => $productID))->first();

		$this->assertThat($testOption->ID, $this->logicalNot($this->equalTo(0)));//make sure the first option still exists


		$product->doRestoreToStage();//restore page to draft site
		$product->doUnpublish();//unpublish page
		$product->deleteFromStage('Stage');//remove product from draft site

		$checkDeleted = OptionItem::get()->filter(array('Title' => 'Large', 'ProductID' => $productID))->first();//query same option as above

		$this->assertEquals($checkDeleted->ID, 0);//check that the ID is 0 (empty object/non-existent)


	}

}


1			<?php
2
3			class ProductPageTest extends FS_Test{
4
5			protected static $use_draft_site = true;
6
7			function setUp(){
			0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
8			parent::setUp();
9
10			$groupForItem = OptionGroup::create();
11			$groupForItem->Title = 'Sample-Group';
			0 ignored issues – show Documentation introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<OptionGroup>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
12			$groupForItem->write();
13
14			/*$productHolder = ProductHolder::create();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-28 22:43 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
15			$productHolder->Title = 'Product Holder';
16			$productHolder->write();*/
17			}
18
19			function testProductCreation(){
			0 ignored issues – show Best Practice introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
20
21			$this->logInWithPermission('Product_CANCRUD');
22			$default = $this->objFromFixture('ProductCategory', 'default');
23			$default->write();
24			$holder = $this->objFromFixture('ProductHolder', 'holder');
25			$holder->doPublish();
26			$product1 = $this->objFromFixture('ProductPage', 'product1');
27			//$product1->ParentID = ProductHolder::get()->first()->ID;
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-28 22:43 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28
29			$product1->doPublish();
30			$this->assertTrue($product1->isPublished());
			0 ignored issues – show Bug introduced 2016-10-01 18:57 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<ProductPageTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31
32			}
33
34			function testProductDeletion(){

dynamic / foxystripe

Push — master ( 3228c3...282357 )

testProductTitleTrailingWhiteSpace() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like