OrderDetail - Code Metrics - Inspection of "OrderDetail - test coverage" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

by Jason

created 2016-10-01 21:13 UTC

OrderDetail A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	5
dl	0
loc	101
ccs	0
cts	18
cp	0
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getCMSFields()	12	2
A	canView()	4	1
A	canEdit()	4	1
A	canDelete()	4	1
A	canCreate()	4	1

<?php

class OrderDetail extends DataObject
{
    /**
     * @var string
     */
    private static $singular_name = 'Order Detail';

    /**
     * @var string
     */
    private static $plural_name = 'Order Details';

    /**
     * @var string
     */
    private static $description = '';

    /**
     * @var array
     */
    private static $db = array(
        'Quantity' => 'Int',
        'Price' => 'Currency'
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Product' => 'ProductPage',
        'Order' => 'Order'
    );

    /**
     * @var array
     */
    private static $many_many = array(
        'Options' => 'OptionItem'
    );

    /**
     * @var array
     */
    private static $summary_fields = array(
        'Product.Title',
        'Quantity',
        'Price.Nice'
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        if ($this->ID) {
            $fields->addFieldsToTab('Root.Options', array(
                GridField::create('Options', 'Product Options', $this->Options(), GridFieldConfig_RecordViewer::create())
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ));
        }

        return $fields;
    }

    /**
     * @param bool $member
     * @return bool|int
     */
    public function canView($member = false)
    {
        return Permission::check('Product_ORDERS');
    }

    /**
     * @param null $member
     * @return bool
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * @param null $member
     * @return bool|int
     */
    public function canDelete($member = null)
    {
        return Permission::check('Product_ORDERS');
    }

    /**
     * @param null $member
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }
}


1			<?php
2
3			class OrderDetail extends DataObject
4			{
5			/**
6			* @var string
7			*/
8			private static $singular_name = 'Order Detail';
9
10			/**
11			* @var string
12			*/
13			private static $plural_name = 'Order Details';
14
15			/**
16			* @var string
17			*/
18			private static $description = '';
19
20			/**
21			* @var array
22			*/
23			private static $db = array(
24			'Quantity' => 'Int',
25			'Price' => 'Currency'
26			);
27
28			/**
29			* @var array
30			*/
31			private static $has_one = array(
32			'Product' => 'ProductPage',
33			'Order' => 'Order'
34			);
35
36			/**
37			* @var array
38			*/
39			private static $many_many = array(
40			'Options' => 'OptionItem'
41			);
42
43			/**
44			* @var array
45			*/
46			private static $summary_fields = array(
47			'Product.Title',
48			'Quantity',
49			'Price.Nice'
50			);
51
52			/**
53			* @return FieldList
54			*/
55			public function getCMSFields()
56			{
57			$fields = parent::getCMSFields();
58
59			if ($this->ID) {
60			$fields->addFieldsToTab('Root.Options', array(
61			GridField::create('Options', 'Product Options', $this->Options(), GridFieldConfig_RecordViewer::create())
			0 ignored issues – show Documentation Bug introduced 2016-10-01 18:12 UTC by Report Bug Copy Issue Report The method `Options` does not exist on `object<OrderDetail>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
62			));
63			}
64
65			return $fields;
66			}
67
68			/**
69			* @param bool $member
70			* @return bool\|int
71			*/
72			public function canView($member = false)
73			{
74			return Permission::check('Product_ORDERS');
75			}
76
77			/**
78			* @param null $member
79			* @return bool
80			*/
81			public function canEdit($member = null)
82			{
83			return false;
84			}
85
86			/**
87			* @param null $member
88			* @return bool\|int
89			*/
90			public function canDelete($member = null)
91			{
92			return Permission::check('Product_ORDERS');
93			}
94
95			/**
96			* @param null $member
97			* @return bool
98			*/
99			public function canCreate($member = null)
100			{
101			return false;
102			}
103			}
104

dynamic / foxystripe

Pull Request — master (#290)

OrderDetail A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like