DonationProduct_Controller::PurchaseForm() - Code Metrics - Inspection of "DonationProduct" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#293)

by Nic

created 2017-01-05 19:17 UTC

DonationProduct_Controller::PurchaseForm() B

↳ Parent: DonationProduct_Controller

Complexity

Conditions	2
Paths	2

Size

Total Lines	45
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	45
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	22
nc	2
nop	0

<?php

class DonationProduct extends ProductPage
{
    /**
     * @var string
     */
    private static $singular_name = 'Donation';

    /**
     * @var string
     */
    private static $plural_name = 'Donations';

    /**
     * @var array
     */
    private static $allowed_children = [];


    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName([
            'Weight',
            'Price',
        ]);

        return $fields;
    }
}

class DonationProduct_Controller extends ProductPage_Controller

{

    /**
     * @var array
     */
    private static $allowed_actions = [
        'PurchaseForm',
        'updatevalue',
    ];

    /**
     *
     */
    public function init()
    {
        parent::init();
        Requirements::javascript("framework/thirdparty/jquery/jquery.js");
    }

    /**
     * @return FoxyStripePurchaseForm
     */
    public function PurchaseForm()
    {
        $form = parent::PurchaseForm();

        $fields = $form->Fields();

        $fields->replaceField(ProductPage::getGeneratedValue($this->Code, 'price',
            $this->Price), $currencyField = CurrencyField::create('price', 'Amount'));

        /*$fields->replaceField(ProductPage::getGeneratedValue($this->Code, 'code',

            $this->Code), $code = HiddenField::create(ProductPage::getGeneratedValue($this->Code, 'code',
            $this->Code))->setValue($this->Code));
        $fields->replaceField(ProductPage::getGeneratedValue($this->Code, 'product_id',
            $this->ID), $id = HiddenField::create(ProductPage::getGeneratedValue($this->Code, 'product_id',
            $this->ID))->setValue($this->ID));*/

        $id = $fields->dataFieldByName(ProductPage::getGeneratedValue($this->Code, 'product_id',
            $this->ID));



        $code = $fields->dataFieldByName(ProductPage::getGeneratedValue($this->Code, 'code',
            $this->Code));

        $codeName = $code->getName();
        $code->setName("h:{$codeName}");

        $idName = $id->getName();
        $id->setName("h:{$idName}");

        $fields->removeByName(array(
            'quantity',
            ProductPage::getGeneratedValue($this->Code, 'weight', $this->Weight),
        ));

        if (SiteConfig::current_site_config()->CartValidation) {
            Requirements::javascript("framework/thirdparty/jquery-validate/jquery.validate.js");
            Requirements::javascriptTemplate("foxystripe/javascript/donationProduct.js", [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'Trigger'   => (string)$currencyField->getAttribute('id'),
                'UpdateURL' => Director::absoluteURL($this->Link('updatevalue')),
            ]);
        }

        return $form;
    }

    /**
     * create new encrypted price value based on user input
     *
     * @param $request
     *
     * @return string|SS_HTTPResponse
     */
    public function updatevalue(SS_HTTPRequest $request)
    {
        if ($request->getVar('Price') && SiteConfig::current_site_config()->CartValidation) {
            $vars        = $request->getVars();
            $signedPrice = FoxyCart_Helper::fc_hash_value($this->Code, 'price', $vars['Price'], 'name', false);
            $json        = json_encode(['Price' => $signedPrice]);
            $response    = new SS_HTTPResponse($json);
            $response->removeHeader('Content-Type');
            $response->addHeader('Content-Type', 'application/json');

            return $response;
        }

        return 'false';
    }
}

1			<?php
2
3			class DonationProduct extends ProductPage
4			{
5			/**
6			* @var string
7			*/
8			private static $singular_name = 'Donation';
9
10			/**
11			* @var string
12			*/
13			private static $plural_name = 'Donations';
14
15			/**
16			* @var array
17			*/
18			private static $allowed_children = [];
			0 ignored issues – show Unused Code introduced 2017-01-04 05:32 UTC by Report Bug Copy Issue Report The property `$allowed_children` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19
20			/**
21			* @return FieldList
22			*/
23			public function getCMSFields()
24			{
25			$fields = parent::getCMSFields();
26
27			$fields->removeByName([
28			'Weight',
29			'Price',
30			]);
31
32			return $fields;
33			}
34			}
35
36			class DonationProduct_Controller extends ProductPage_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-04 05:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
37			{
38
39			/**
40			* @var array
41			*/
42			private static $allowed_actions = [
43			'PurchaseForm',
44			'updatevalue',
45			];
46
47			/**
48			*
49			*/
50			public function init()
51			{
52			parent::init();
53			Requirements::javascript("framework/thirdparty/jquery/jquery.js");
54			}
55
56			/**
57			* @return FoxyStripePurchaseForm
58			*/
59			public function PurchaseForm()
60			{
61			$form = parent::PurchaseForm();
62
63			$fields = $form->Fields();
64
65			$fields->replaceField(ProductPage::getGeneratedValue($this->Code, 'price',
66			$this->Price), $currencyField = CurrencyField::create('price', 'Amount'));
67
68			/*$fields->replaceField(ProductPage::getGeneratedValue($this->Code, 'code',
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-05 19:29 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
69			$this->Code), $code = HiddenField::create(ProductPage::getGeneratedValue($this->Code, 'code',
70			$this->Code))->setValue($this->Code));
71			$fields->replaceField(ProductPage::getGeneratedValue($this->Code, 'product_id',
72			$this->ID), $id = HiddenField::create(ProductPage::getGeneratedValue($this->Code, 'product_id',
73			$this->ID))->setValue($this->ID));*/
74
75			$id = $fields->dataFieldByName(ProductPage::getGeneratedValue($this->Code, 'product_id',
76			$this->ID));
77
78
79
80			$code = $fields->dataFieldByName(ProductPage::getGeneratedValue($this->Code, 'code',
81			$this->Code));
82
83			$codeName = $code->getName();
84			$code->setName("h:{$codeName}");
85
86			$idName = $id->getName();
87			$id->setName("h:{$idName}");
88
89			$fields->removeByName(array(
90			'quantity',
91			ProductPage::getGeneratedValue($this->Code, 'weight', $this->Weight),
92			));
93
94			if (SiteConfig::current_site_config()->CartValidation) {
95			Requirements::javascript("framework/thirdparty/jquery-validate/jquery.validate.js");
96			Requirements::javascriptTemplate("foxystripe/javascript/donationProduct.js", [
			0 ignored issues – show Documentation introduced 2017-01-05 00:31 UTC by Report Bug Copy Issue Report `array('Trigger' => (stri...->Link('updatevalue')))` is of type `array<string,string\|fals...teURL":"false\|string"}>`, but the function expects a `array<integer,string\|integer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
97			'Trigger' => (string)$currencyField->getAttribute('id'),
98			'UpdateURL' => Director::absoluteURL($this->Link('updatevalue')),
99			]);
100			}
101
102			return $form;
103			}
104
105			/**
106			* create new encrypted price value based on user input
107			*
108			* @param $request
109			*
110			* @return string\|SS_HTTPResponse
111			*/
112			public function updatevalue(SS_HTTPRequest $request)
113			{
114			if ($request->getVar('Price') && SiteConfig::current_site_config()->CartValidation) {
115			$vars = $request->getVars();
116			$signedPrice = FoxyCart_Helper::fc_hash_value($this->Code, 'price', $vars['Price'], 'name', false);
117			$json = json_encode(['Price' => $signedPrice]);
118			$response = new SS_HTTPResponse($json);
119			$response->removeHeader('Content-Type');
120			$response->addHeader('Content-Type', 'application/json');
121
122			return $response;
123			}
124
125			return 'false';
126			}
127			}

dynamic / foxystripe

Pull Request — master (#293)

DonationProduct_Controller::PurchaseForm() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like