DonationProduct_Controller::PurchaseForm() - Code Metrics - Inspection of "DonationProduct" - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#293)

by Nic

created 2017-01-05 00:24 UTC

DonationProduct_Controller::PurchaseForm() A

↳ Parent: DonationProduct_Controller

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	0
cts	15
cp	0
rs	9.2
c	0
b	0
f	0
cc	2
eloc	12
nc	2
nop	0
crap	6

<?php

class DonationProduct extends ProductPage
{
    /**
     * @var string
     */
    private static $singular_name = 'Donation';

    /**
     * @var string
     */
    private static $plural_name = 'Donations';

    /**
     * @var array
     */
    private static $allowed_children = [];


    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName([
            'Weight',
            'Price',
        ]);

        return $fields;
    }
}

class DonationProduct_Controller extends ProductPage_Controller

{

    /**
     * @var array
     */
    private static $allowed_actions = [
        'PurchaseForm',
        'updatevalue',
    ];

    /**
     *
     */
    public function init()
    {
        parent::init();
        Requirements::javascript("framework/thirdparty/jquery/jquery.js");
    }

    /**
     * @return FoxyStripePurchaseForm
     */
    public function PurchaseForm()
    {
        $form = parent::PurchaseForm();

        $fields = $form->Fields();

        $fields->insertBefore($currencyField = CurrencyField::create('price', 'Amount'), 'quantity');

        $fields->removeByName(array(
            'quantity',
        ));

        if (SiteConfig::current_site_config()->CartValidation) {
            Requirements::javascript("framework/thirdparty/jquery-validate/jquery.validate.js");
            Requirements::javascriptTemplate("foxystripe/javascript/donationProduct.js", [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'Trigger' => (string)$currencyField->getAttribute('id'),
                'UpdateURL' => Director::absoluteURL($this->Link('updatevalue')),
            ]);
        }

        return $form;
    }

    /**
     * create new encrypted price value based on user input
     *
     * @param $request
     * @return string|SS_HTTPResponse
     */
    public function updatevalue($request)
    {

        if ($price = $request->getVar('Price') && SiteConfig::current_site_config()->CartValidation) {

            $signedPrice = FoxyCart_Helper::fc_hash_value($this->Code, 'price', $price, 'name', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $json = json_encode(['Price' => $signedPrice]);
            $response = new SS_HTTPResponse($json);
            $response->removeHeader('Content-Type');
            $response->addHeader('Content-Type', 'application/json');
            return $response;
        }

        return 'false';
    }
}

1			<?php
2
3			class DonationProduct extends ProductPage
4			{
5			/**
6			* @var string
7			*/
8			private static $singular_name = 'Donation';
9
10			/**
11			* @var string
12			*/
13			private static $plural_name = 'Donations';
14
15			/**
16			* @var array
17			*/
18			private static $allowed_children = [];
			0 ignored issues – show Unused Code introduced 2017-01-04 05:32 UTC by Report Bug Copy Issue Report The property `$allowed_children` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19
20			/**
21			* @return FieldList
22			*/
23			public function getCMSFields()
24			{
25			$fields = parent::getCMSFields();
26
27			$fields->removeByName([
28			'Weight',
29			'Price',
30			]);
31
32			return $fields;
33			}
34			}
35
36			class DonationProduct_Controller extends ProductPage_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-04 05:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
37			{
38
39			/**
40			* @var array
41			*/
42			private static $allowed_actions = [
43			'PurchaseForm',
44			'updatevalue',
45			];
46
47			/**
48			*
49			*/
50			public function init()
51			{
52			parent::init();
53			Requirements::javascript("framework/thirdparty/jquery/jquery.js");
54			}
55
56			/**
57			* @return FoxyStripePurchaseForm
58			*/
59			public function PurchaseForm()
60			{
61			$form = parent::PurchaseForm();
62
63			$fields = $form->Fields();
64
65			$fields->insertBefore($currencyField = CurrencyField::create('price', 'Amount'), 'quantity');
66
67			$fields->removeByName(array(
68			'quantity',
69			));
70
71			if (SiteConfig::current_site_config()->CartValidation) {
72			Requirements::javascript("framework/thirdparty/jquery-validate/jquery.validate.js");
73			Requirements::javascriptTemplate("foxystripe/javascript/donationProduct.js", [
			0 ignored issues – show Documentation introduced 2017-01-05 00:31 UTC by Report Bug Copy Issue Report `array('Trigger' => (stri...->Link('updatevalue')))` is of type `array<string,string\|fals...teURL":"false\|string"}>`, but the function expects a `array<integer,string\|integer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			'Trigger' => (string)$currencyField->getAttribute('id'),
75			'UpdateURL' => Director::absoluteURL($this->Link('updatevalue')),
76			]);
77			}
78
79			return $form;
80			}
81
82			/**
83			* create new encrypted price value based on user input
84			*
85			* @param $request
86			* @return string\|SS_HTTPResponse
87			*/
88			public function updatevalue($request)
89			{
90
91			if ($price = $request->getVar('Price') && SiteConfig::current_site_config()->CartValidation) {
			0 ignored issues – show Comprehensibility introduced 2017-01-05 00:31 UTC by Report Bug Copy Issue Report Consider adding parentheses for clarity. Current Interpretation: `$price = ($request->getV...nfig()->CartValidation)`, Probably Intended Meaning: `($price = $request->getV...onfig()->CartValidation` Loading history...
92			$signedPrice = FoxyCart_Helper::fc_hash_value($this->Code, 'price', $price, 'name', false);
			0 ignored issues – show Documentation introduced 2017-01-05 00:31 UTC by Report Bug Copy Issue Report `$price` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
93			$json = json_encode(['Price' => $signedPrice]);
94			$response = new SS_HTTPResponse($json);
95			$response->removeHeader('Content-Type');
96			$response->addHeader('Content-Type', 'application/json');
97			return $response;
98			}
99
100			return 'false';
101			}
102			}

dynamic / foxystripe

Pull Request — master (#293)

DonationProduct_Controller::PurchaseForm() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like