OrderAdmin::getEditForm() - Code Metrics - dynamic/foxystripe - Measure and Improve Code Quality continuously with Scrutinizer

OrderAdmin::getEditForm() A
last analyzed 2023-04-10 15:27 UTC

↳ Parent: OrderAdmin

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	16
ccs	0
cts	7
cp	0
rs	10
cc	1
nc	1
nop	2
crap	2

<?php

namespace Dynamic\FoxyStripe\Admin;

use Dynamic\FoxyStripe\Model\Order;
use SilverStripe\Admin\ModelAdmin;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldConfig;
use SilverStripe\Forms\GridField\GridFieldEditButton;

class OrderAdmin extends ModelAdmin
{
    /**
     * @var array
     */
    private static $managed_models = array(

        Order::class,
    );

    /**
     * @var string
     */
    private static $url_segment = 'orders';


    /**
     * @var string
     */
    private static $menu_title = 'Orders';


    /**
     * @var int
     */
    private static $menu_priority = 4;


    /**
     * @param null $id

     * @param null $fields

     *
     * @return \SilverStripe\Forms\Form
     */
    public function getEditForm($id = null, $fields = null)
    {
        $form = parent::getEditForm($id, $fields);

        $gridFieldName = $this->sanitiseClassName($this->modelClass);
        /** @var GridField $gridField */
        $gridField = $form->Fields()->fieldByName($gridFieldName);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        // GridField configuration
        /** @var GridFieldConfig $config */
        $config = $gridField->getConfig();

        // remove edit icon
        $config->removeComponentsByType(GridFieldEditButton::class);

        return $form;
    }
}


1			<?php
2
3			namespace Dynamic\FoxyStripe\Admin;
4
5			use Dynamic\FoxyStripe\Model\Order;
6			use SilverStripe\Admin\ModelAdmin;
7			use SilverStripe\Forms\GridField\GridField;
8			use SilverStripe\Forms\GridField\GridFieldConfig;
9			use SilverStripe\Forms\GridField\GridFieldEditButton;
10
11			class OrderAdmin extends ModelAdmin
12			{
13			/**
14			* @var array
15			*/
16			private static $managed_models = array(
			0 ignored issues – show introduced 2018-03-03 21:50 UTC by Report Bug Copy Issue Report The private property `$managed_models` is not used, and could be removed. Loading history...
17			Order::class,
18			);
19
20			/**
21			* @var string
22			*/
23			private static $url_segment = 'orders';
			0 ignored issues – show introduced 2018-03-03 21:50 UTC by Report Bug Copy Issue Report The private property `$url_segment` is not used, and could be removed. Loading history...
24
25			/**
26			* @var string
27			*/
28			private static $menu_title = 'Orders';
			0 ignored issues – show introduced 2018-03-03 21:50 UTC by Report Bug Copy Issue Report The private property `$menu_title` is not used, and could be removed. Loading history...
29
30			/**
31			* @var int
32			*/
33			private static $menu_priority = 4;
			0 ignored issues – show introduced 2018-03-06 06:24 UTC by Report Bug Copy Issue Report The private property `$menu_priority` is not used, and could be removed. Loading history...
34
35			/**
36			* @param null $id
			0 ignored issues – show Documentation Bug introduced 2018-03-06 06:24 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$id` is correct as it would always require `null` to be passed? Loading history...
37			* @param null $fields
			0 ignored issues – show Documentation Bug introduced 2018-09-17 22:06 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$fields` is correct as it would always require `null` to be passed? Loading history...
38			*
39			* @return \SilverStripe\Forms\Form
40			*/
41			public function getEditForm($id = null, $fields = null)
42			{
43			$form = parent::getEditForm($id, $fields);
44
45			$gridFieldName = $this->sanitiseClassName($this->modelClass);
46			/** @var GridField $gridField */
47			$gridField = $form->Fields()->fieldByName($gridFieldName);
			0 ignored issues – show Bug introduced 2023-04-05 15:12 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$gridField` is correct as `$form->Fields()->fieldByName($gridFieldName)` targeting `SilverStripe\Forms\FieldList::fieldByName()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
48
49			// GridField configuration
50			/** @var GridFieldConfig $config */
51			$config = $gridField->getConfig();
52
53			// remove edit icon
54			$config->removeComponentsByType(GridFieldEditButton::class);
55
56			return $form;
57			}
58			}
59

dynamic / foxystripe

OrderAdmin::getEditForm() A last analyzed 2023-04-10 15:27 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

OrderAdmin::getEditForm() A
last analyzed 2023-04-10 15:27 UTC