Issues in PromoObject.php (master) - Issues in master - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (196)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/objects/PromoObject.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class PromoObject extends DataObject
{
    /**
     * @return string
     */
    private static $singular_name = 'Promo';

    /**
     * @return string
     */
    private static $plural_name = 'Promos';

    /**
     * @var array
     */
    private static $db = array(
        'Name' => 'Varchar(255)',
        'Title' => 'Varchar(255)',
        'Content' => 'HTMLText',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Image' => 'Image',
        'BlockLink' => 'Link',
    );

    /**
     * @var array
     */
    private static $belongs_many_many = array(
        'PromoBlocks' => 'PromoBlock'
    );

    /**
     * @var string
     */
    private static $default_sort = 'Name ASC';


    /**
     * @var array
     */
    private static $summary_fields = array(
        'Image.CMSThumbnail' => 'Image',
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @var array
     */
    private static $searchable_fields = array(
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @var array
     */
    private static $extensions = [
        'VersionedDataObject',
    ];

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function ($fields) {
            $fields->addFieldToTab(
                'Root.Main',
                LinkField::create('BlockLinkID', 'Link'),
                'Content'
            );
        });

        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'PromoBlocks',
        ));

        $fields->dataFieldByName('Name')->setDescription('For internal reference only');

        $image = $fields->dataFieldByName('Image');
        $image->setFolderName('Uploads/Promos');
        $fields->insertBefore($image, 'Content');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $config = GridFieldConfig_RecordViewer::create();
        $fields->addFieldToTab('Root.Blocks', GridField::create('PromoBlocks', 'Blocks', $this->PromoBlocks(), $config));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        return $fields;
    }

    /**
     * @return ValidationResult
     */
    public function validate()
    {
        $result = parent::validate();

        if (!$this->Name) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $result->error('Name is requied before you can save');
        }

        return $result;
    }

    /**
     * Set permissions, allow all users to access by default.
     * Override in descendant classes, or use PermissionProvider.
     */

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        return true;
    }
}

1		<?php
2
3		class PromoObject extends DataObject
4		{
5		/**
6		* @return string
7		*/
8		private static $singular_name = 'Promo';
9
10		/**
11		* @return string
12		*/
13		private static $plural_name = 'Promos';
14
15		/**
16		* @var array
17		*/
18		private static $db = array(
19		'Name' => 'Varchar(255)',
20		'Title' => 'Varchar(255)',
21		'Content' => 'HTMLText',
22		);
23
24		/**
25		* @var array
26		*/
27		private static $has_one = array(
28		'Image' => 'Image',
29		'BlockLink' => 'Link',
30		);
31
32		/**
33		* @var array
34		*/
35		private static $belongs_many_many = array(
36		'PromoBlocks' => 'PromoBlock'
37		);
38
39		/**
40		* @var string
41		*/
42		private static $default_sort = 'Name ASC';
		0 ignored issues – show Unused Code introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
43
44		/**
45		* @var array
46		*/
47		private static $summary_fields = array(
48		'Image.CMSThumbnail' => 'Image',
49		'Name' => 'Name',
50		'Title' => 'Title',
51		);
52
53		/**
54		* @var array
55		*/
56		private static $searchable_fields = array(
57		'Name' => 'Name',
58		'Title' => 'Title',
59		);
60
61		/**
62		* @var array
63		*/
64		private static $extensions = [
65		'VersionedDataObject',
66		];
67
68		/**
69		* @return FieldList
70		*/
71	1	public function getCMSFields()
72		{
73	1	$this->beforeUpdateCMSFields(function ($fields) {
74	1	$fields->addFieldToTab(
75	1	'Root.Main',
76	1	LinkField::create('BlockLinkID', 'Link'),
77		'Content'
78	1	);
79	1	});
80
81	1	$fields = parent::getCMSFields();
82
83	1	$fields->removeByName(array(
84	1	'PromoBlocks',
85	1	));
86
87	1	$fields->dataFieldByName('Name')->setDescription('For internal reference only');
88
89	1	$image = $fields->dataFieldByName('Image');
90	1	$image->setFolderName('Uploads/Promos');
91	1	$fields->insertBefore($image, 'Content');
		0 ignored issues – show Documentation introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'Content'` is of type `string`, but the function expects a `object<FormField>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
92
93	1	$config = GridFieldConfig_RecordViewer::create();
94	1	$fields->addFieldToTab('Root.Blocks', GridField::create('PromoBlocks', 'Blocks', $this->PromoBlocks(), $config));
		0 ignored issues – show Documentation Bug introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PromoBlocks` does not exist on `object<PromoObject>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
95
96	1	return $fields;
97		}
98
99		/**
100		* @return ValidationResult
101		*/
102	1	public function validate()
103		{
104	1	$result = parent::validate();
105
106	1	if (!$this->Name) {
		0 ignored issues – show Documentation introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<PromoObject>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
107	1	$result->error('Name is requied before you can save');
108	1	}
109
110	1	return $result;
111		}
112
113		/**
114		* Set permissions, allow all users to access by default.
115		* Override in descendant classes, or use PermissionProvider.
116		*/
117
118		/**
119		* @param null $member
120		*
121		* @return bool
122		*/
123	1	public function canCreate($member = null)
124		{
125	1	return true;
126		}
127
128		/**
129		* @param null $member
130		*
131		* @return bool
132		*/
133	1	public function canView($member = null)
134		{
135	1	return true;
136		}
137
138		/**
139		* @param null $member
140		*
141		* @return bool
142		*/
143	1	public function canEdit($member = null)
144		{
145	1	return true;
146		}
147
148		/**
149		* @param null $member
150		*
151		* @return bool
152		*/
153	1	public function canDelete($member = null)
154		{
155	1	return true;
156		}
157		}

dynamic / dynamic-blocks

Issues (196)

Security Analysis no request data

code/objects/PromoObject.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like