PageSectionObject::getCMSFields() - Code Metrics - Inspection of "Merge pull request #39 from jsirish/tests/increase..." - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d2fd9...fbfc98 )

by Jason

created 2017-02-05 20:11 UTC

PageSectionObject::getCMSFields() B

↳ Parent: PageSectionObject

Complexity

Conditions	1
Paths	1

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	17
cts	17
cp	1
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	15
nc	1
nop	0
crap	1

<?php

/**
 * Class PageSectionObject
 *
 * @property string $Name
 * @property string $Title
 * @property HTMLText $Content
 * @property int $SortOrder
 * @property int $ImageID
 * @property int $PageSectionBlockID
 */
class PageSectionObject extends DataObject
{
    /**
     * @return string
     */
    private static $singular_name = 'Page Section';

    /**
     * @return string
     */
    private static $plural_name = 'Page Sections';

    /**
     * @var array
     */
    private static $db = array(
        'Name' => 'Varchar(255)',
        'Title' => 'Varchar(255)',
        'Content' => 'HTMLText',
        'SortOrder' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Image' => 'Image',
        'PageSectionBlock' => 'PageSectionBlock',
        'BlockLink' => 'Link',
    );

    /**
     * @var string
     */
    private static $default_sort = 'Name ASC';


    /**
     * @var array
     */
    private static $summary_fields = array(
        'Image.CMSThumbnail' => 'Image',
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @var array
     */
    private static $searchable_fields = array(
        'Name' => 'Name',
        'Title' => 'Title',
    );

    private static $extensions = [
        'VersionedDataObject'
    ];

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function ($fields) {
            $fields->addFieldToTab(
                'Root.Main',
                LinkField::create('BlockLinkID', 'Link'),
                'Content'
            );
        });

        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'PageSectionBlockID',
            'SortOrder',
        ));

        $fields->dataFieldByName('Name')->setDescription('For internal reference only');

        $image = $fields->dataFieldByName('Image');
        $image->setFolderName('Uploads/PageSections');
        $fields->insertBefore($image, 'Content');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $fields;
    }

    /**
     * @return ValidationResult
     */
    public function validate()
    {
        $result = parent::validate();

        if (!$this->Name) {
            $result->error('Name is requied before you can save');
        }

        return $result;
    }

    /**
     * Set permissions, allow all users to access by default.
     * Override in descendant classes, or use PermissionProvider.
     */

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        return true;
    }
}

1		<?php
2
3		/**
4		* Class PageSectionObject
5		*
6		* @property string $Name
7		* @property string $Title
8		* @property HTMLText $Content
9		* @property int $SortOrder
10		* @property int $ImageID
11		* @property int $PageSectionBlockID
12		*/
13		class PageSectionObject extends DataObject
14		{
15		/**
16		* @return string
17		*/
18		private static $singular_name = 'Page Section';
19
20		/**
21		* @return string
22		*/
23		private static $plural_name = 'Page Sections';
24
25		/**
26		* @var array
27		*/
28		private static $db = array(
29		'Name' => 'Varchar(255)',
30		'Title' => 'Varchar(255)',
31		'Content' => 'HTMLText',
32		'SortOrder' => 'Int',
33		);
34
35		/**
36		* @var array
37		*/
38		private static $has_one = array(
39		'Image' => 'Image',
40		'PageSectionBlock' => 'PageSectionBlock',
41		'BlockLink' => 'Link',
42		);
43
44		/**
45		* @var string
46		*/
47		private static $default_sort = 'Name ASC';
		0 ignored issues – show Unused Code introduced 2016-12-07 16:43 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
48
49		/**
50		* @var array
51		*/
52		private static $summary_fields = array(
53		'Image.CMSThumbnail' => 'Image',
54		'Name' => 'Name',
55		'Title' => 'Title',
56		);
57
58		/**
59		* @var array
60		*/
61		private static $searchable_fields = array(
62		'Name' => 'Name',
63		'Title' => 'Title',
64		);
65
66		private static $extensions = [
67		'VersionedDataObject'
68		];
69
70		/**
71		* @return FieldList
72		*/
73	1	public function getCMSFields()
74		{
75	1	$this->beforeUpdateCMSFields(function ($fields) {
76	1	$fields->addFieldToTab(
77	1	'Root.Main',
78	1	LinkField::create('BlockLinkID', 'Link'),
79		'Content'
80	1	);
81	1	});
82
83	1	$fields = parent::getCMSFields();
84
85	1	$fields->removeByName(array(
86	1	'PageSectionBlockID',
87	1	'SortOrder',
88	1	));
89
90	1	$fields->dataFieldByName('Name')->setDescription('For internal reference only');
91
92	1	$image = $fields->dataFieldByName('Image');
93	1	$image->setFolderName('Uploads/PageSections');
94	1	$fields->insertBefore($image, 'Content');
		0 ignored issues – show Documentation introduced 2016-12-07 16:43 UTC by Report Bug Copy Issue Report `'Content'` is of type `string`, but the function expects a `object<FormField>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
95
96	1	return $fields;
97		}
98
99		/**
100		* @return ValidationResult
101		*/
102	1	public function validate()
103		{
104	1	$result = parent::validate();
105
106	1	if (!$this->Name) {
107	1	$result->error('Name is requied before you can save');
108	1	}
109
110	1	return $result;
111		}
112
113		/**
114		* Set permissions, allow all users to access by default.
115		* Override in descendant classes, or use PermissionProvider.
116		*/
117
118		/**
119		* @param null $member
120		*
121		* @return bool
122		*/
123	1	public function canCreate($member = null)
124		{
125	1	return true;
126		}
127
128		/**
129		* @param null $member
130		*
131		* @return bool
132		*/
133	1	public function canView($member = null)
134		{
135	1	return true;
136		}
137
138		/**
139		* @param null $member
140		*
141		* @return bool
142		*/
143	1	public function canEdit($member = null)
144		{
145	1	return true;
146		}
147
148		/**
149		* @param null $member
150		*
151		* @return bool
152		*/
153	1	public function canDelete($member = null)
154		{
155	1	return true;
156		}
157		}

dynamic / dynamic-blocks

Push — master ( 1d2fd9...fbfc98 )

PageSectionObject::getCMSFields() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like