Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class PageSectionBlock extends Block |
||
9 | { |
||
10 | /** |
||
11 | * @return string |
||
12 | */ |
||
13 | 9 | public function singular_name() |
|
17 | |||
18 | /** |
||
19 | * @return string |
||
20 | */ |
||
21 | 1 | public function plural_name() |
|
22 | { |
||
23 | 1 | return _t('PageSectionBlock.PLURALNAME', 'Page Sections Blocks'); |
|
24 | } |
||
25 | |||
26 | /** |
||
27 | * @var array |
||
28 | */ |
||
29 | private static $has_many = [ |
||
30 | 'Sections' => 'PageSectionObject', |
||
31 | ]; |
||
32 | |||
33 | /** |
||
34 | * @return FieldList |
||
35 | */ |
||
36 | 1 | View Code Duplication | public function getCMSFields() |
55 | |||
56 | /** |
||
57 | * @return mixed |
||
58 | */ |
||
59 | 1 | public function getPageSections() |
|
63 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.