RecentVideosBlock::getRecentVideos() - Code Metrics - Inspection of "Merge pull request #14 from muskie9/enhancement/yo..." - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 38ef72...9181f6 )

by Nic

created 2017-01-05 21:26 UTC

RecentVideosBlock::getRecentVideos() A

↳ Parent: RecentVideosBlock

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	5
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

/**
 * Class RecentVideosBlock
 *
 * @property int $Limit
 * @property int $VideoPageID
 * @method YouTubeIntegrationVideosPage $VideoPage
 */
class RecentVideosBlock extends Block
{
    /**
     * @var string
     */
    private static $singular_name = 'Recent Videos Block';

    /**
     * @var string
     */
    private static $plural_name = 'Recent Videos Blocks';

    /**
     * @var array
     */
    private static $db = array(
        'Limit' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'VideoPage' => 'YouTubeIntegrationVideosPage',
    );

    /**
     * @var array
     */
    private static $defaults = array(
        'Limit' => 3,
    );

    /**
     * @var
     */
    private $recent_videos;

    /**
     * @return FieldList
     */
    public function getCMSFields()

    {
        $fields = singleton('Block')->getCMSFields();

        $fields->addFieldsToTab('Root.Main', array(
            NumericField::create('Limit'),
        ));

        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create('VideoPageID', 'Featured Video Page', YouTubeIntegrationVideosPage::get()->map())
                ->setEmptyString('')
        );

        return $fields;
    }

    /**
     * @param null $member
     * @return bool
     */
    public function canCreate($member = null)
    {
        return parent::canCreate($member);
    }

    /**
     * @param null $member
     * @return bool
     */
    public function canView($member = null)
    {
        return parent::canView($member);
    }

    /**
     * @return mixed
     */
    public function getRecentVideos()
    {
        if (!$this->recent_videos) {
            $this->setRecentVideos();
        }
        return $this->recent_videos;
    }

    /**
     * @return $this
     */
    public function setRecentVideos()
    {
        $this->recent_videos = ($this->VideoPageID != 0)
            ? $this->VideoPage()->getVideosList()->limit($this->Limit)
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            : SilverStripeYouTubeVideo::get()->limit($this->Limit);
        return $this;
    }

}

1		<?php
2
3		/**
4		* Class RecentVideosBlock
5		*
6		* @property int $Limit
7		* @property int $VideoPageID
8		* @method YouTubeIntegrationVideosPage $VideoPage
9		*/
10		class RecentVideosBlock extends Block
11		{
12		/**
13		* @var string
14		*/
15		private static $singular_name = 'Recent Videos Block';
16
17		/**
18		* @var string
19		*/
20		private static $plural_name = 'Recent Videos Blocks';
21
22		/**
23		* @var array
24		*/
25		private static $db = array(
26		'Limit' => 'Int',
27		);
28
29		/**
30		* @var array
31		*/
32		private static $has_one = array(
33		'VideoPage' => 'YouTubeIntegrationVideosPage',
34		);
35
36		/**
37		* @var array
38		*/
39		private static $defaults = array(
40		'Limit' => 3,
41		);
42
43		/**
44		* @var
45		*/
46		private $recent_videos;
47
48		/**
49		* @return FieldList
50		*/
51	View Code Duplication	public function getCMSFields()
		0 ignored issues – show Duplication introduced 2017-01-05 21:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		$fields = singleton('Block')->getCMSFields();
54
55		$fields->addFieldsToTab('Root.Main', array(
56		NumericField::create('Limit'),
57		));
58
59		$fields->addFieldToTab(
60		'Root.Main',
61		DropdownField::create('VideoPageID', 'Featured Video Page', YouTubeIntegrationVideosPage::get()->map())
62		->setEmptyString('')
63		);
64
65		return $fields;
66		}
67
68		/**
69		* @param null $member
70		* @return bool
71		*/
72		public function canCreate($member = null)
73		{
74		return parent::canCreate($member);
75		}
76
77		/**
78		* @param null $member
79		* @return bool
80		*/
81		public function canView($member = null)
82		{
83		return parent::canView($member);
84		}
85
86		/**
87		* @return mixed
88		*/
89		public function getRecentVideos()
90		{
91		if (!$this->recent_videos) {
92		$this->setRecentVideos();
93		}
94		return $this->recent_videos;
95		}
96
97		/**
98		* @return $this
99		*/
100		public function setRecentVideos()
101		{
102		$this->recent_videos = ($this->VideoPageID != 0)
103		? $this->VideoPage()->getVideosList()->limit($this->Limit)
		0 ignored issues – show Documentation Bug introduced 2017-01-05 21:36 UTC by Report Bug Copy Issue Report The method `VideoPage` does not exist on `object<RecentVideosBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
104		: SilverStripeYouTubeVideo::get()->limit($this->Limit);
105		return $this;
106		}
107
108		}

dynamic / dynamic-blocks

Push — master ( 38ef72...9181f6 )

RecentVideosBlock::getRecentVideos() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like