PhotoGalleryBlockImageTest::testGetCMSFields() - Code Metrics - Inspection of "SilverStripe 4 upgrade" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

by Jason

created 2017-07-06 04:57 UTC

PhotoGalleryBlockImageTest::testGetCMSFields() A

↳ Parent: PhotoGalleryBlockImageTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Dynamic\DynamicBlocks\Test;

use Dynamic\DynamicBlocks\Model\PhotoGalleryBlockImage;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Security\Member;

class PhotoGalleryBlockImageTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'dynamic-blocks/tests/Fixtures.yml';

    /**
     *
     */
    public function testGetCMSFields()

    {
        $object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
        $fields = $object->getCMSFields();
        $this->assertInstanceOf('FieldList', $fields);
        $this->assertNull($fields->dataFieldByName('PhotoGalleryID'));
    }

    /**
     *
     */
    public function testCanView()
    {
        $object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canView($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertTrue($object->canView($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanEdit()
    {
        $object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canEdit($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertTrue($object->canEdit($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanDelete()
    {
        $object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canDelete($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertTrue($object->canDelete($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanCreate()
    {
        $object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canCreate($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertTrue($object->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1		<?php
2
3		namespace Dynamic\DynamicBlocks\Test;
4
5		use Dynamic\DynamicBlocks\Model\PhotoGalleryBlockImage;
6		use SilverStripe\Dev\SapphireTest;
7		use SilverStripe\Security\Member;
8
9		class PhotoGalleryBlockImageTest extends SapphireTest
10		{
11		/**
12		* @var string
13		*/
14		protected static $fixture_file = 'dynamic-blocks/tests/Fixtures.yml';
15
16		/**
17		*
18		*/
19	View Code Duplication	public function testGetCMSFields()
		0 ignored issues – show Duplication introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		$object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
22		$fields = $object->getCMSFields();
23		$this->assertInstanceOf('FieldList', $fields);
24		$this->assertNull($fields->dataFieldByName('PhotoGalleryID'));
25		}
26
27		/**
28		*
29		*/
30		public function testCanView()
31		{
32		$object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
33		$admin = $this->objFromFixture(Member::class, 'admin');
34		$this->assertTrue($object->canView($admin));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `33` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canView()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35		$member = $this->objFromFixture(Member::class, 'default');
36		$this->assertTrue($object->canView($member));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `35` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canView()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
37		}
38
39		/**
40		*
41		*/
42		public function testCanEdit()
43		{
44		$object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
45		$admin = $this->objFromFixture(Member::class, 'admin');
46		$this->assertTrue($object->canEdit($admin));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `45` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canEdit()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
47		$member = $this->objFromFixture(Member::class, 'default');
48		$this->assertTrue($object->canEdit($member));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `47` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canEdit()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
49		}
50
51		/**
52		*
53		*/
54		public function testCanDelete()
55		{
56		$object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
57		$admin = $this->objFromFixture(Member::class, 'admin');
58		$this->assertTrue($object->canDelete($admin));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `57` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canDelete()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
59		$member = $this->objFromFixture(Member::class, 'default');
60		$this->assertTrue($object->canDelete($member));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `59` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canDelete()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
61		}
62
63		/**
64		*
65		*/
66		public function testCanCreate()
67		{
68		$object = $this->objFromFixture(PhotoGalleryBlockImage::class, 'one');
69		$admin = $this->objFromFixture(Member::class, 'admin');
70		$this->assertTrue($object->canCreate($admin));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `69` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canCreate()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
71		$member = $this->objFromFixture(Member::class, 'default');
72		$this->assertTrue($object->canCreate($member));
		0 ignored issues – show Bug introduced 2017-07-06 05:00 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `71` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canCreate()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
73		}
74		}
75

dynamic / dynamic-blocks

Pull Request — master (#62)

PhotoGalleryBlockImageTest::testGetCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like