PromoBlock - Code Metrics - Inspection of "Revert Custom Blocks - permission updates" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6214aa...daa834 )

by Jason

created 2016-11-11 16:43 UTC

PromoBlock A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

83.33%

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	5
dl	0
loc	69
ccs	20
cts	24
cp	0.8333
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	plural_name()	4	1
A	singular_name()	4	1
B	getCMSFields()	23	4
A	getPromoList()	4	1

<?php

class PromoBlock extends Block
{
    /**
     * @return string
     */
    public function singular_name()
    {
        return _t('PromoBlock.SINGULARNAME', 'Promo Block');
    }

    /**
     * @return string
     */
    public function plural_name()
    {
        return _t('PromoBlock.PLURALNAME', 'Promo Blocks');
    }

    /**
     * @var array
     */
    private static $many_many = array(
        'Promos' => 'PromoObject',
    );

    /**
     * @var array
     */
    private static $many_many_extraFields = array(
        'Promos' => array(
            'SortOrder' => 'Int',
        ),
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        if ($this->ID) {
            $config = GridFieldConfig_RelationEditor::create();
            if (class_exists('GridFieldSortableRows')) {
                $config->addComponent(new GridFieldSortableRows('SortOrder'));
            }
            if (class_exists('GridFieldAddExistingSearchButton')) {
                $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
                $config->addComponent(new GridFieldAddExistingSearchButton());
            }
            $promos = $this->Promos()->sort('SortOrder');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $promoField = GridField::create('Promos', 'Promos', $promos, $config);

            $fields->addFieldsToTab('Root.Main', array(
                $promoField,
            ));
        }

        return $fields;
    }

    /**
     * @return mixed
     */
    public function getPromoList()
    {
        return $this->Promos()->sort('SortOrder');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}

1		<?php
2
3		class PromoBlock extends Block
4		{
5		/**
6		* @return string
7		*/
8	6	public function singular_name()
9		{
10	6	return _t('PromoBlock.SINGULARNAME', 'Promo Block');
11		}
12
13		/**
14		* @return string
15		*/
16		public function plural_name()
17		{
18		return _t('PromoBlock.PLURALNAME', 'Promo Blocks');
19		}
20
21		/**
22		* @var array
23		*/
24		private static $many_many = array(
25		'Promos' => 'PromoObject',
26		);
27
28		/**
29		* @var array
30		*/
31		private static $many_many_extraFields = array(
32		'Promos' => array(
33		'SortOrder' => 'Int',
34		),
35		);
36
37		/**
38		* @return FieldList
39		*/
40	1	public function getCMSFields()
41		{
42	1	$fields = parent::getCMSFields();
43
44	1	if ($this->ID) {
45	1	$config = GridFieldConfig_RelationEditor::create();
46	1	if (class_exists('GridFieldSortableRows')) {
47		$config->addComponent(new GridFieldSortableRows('SortOrder'));
48		}
49	1	if (class_exists('GridFieldAddExistingSearchButton')) {
50	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
51	1	$config->addComponent(new GridFieldAddExistingSearchButton());
52	1	}
53	1	$promos = $this->Promos()->sort('SortOrder');
		0 ignored issues – show Documentation Bug introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report The method `Promos` does not exist on `object<PromoBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
54	1	$promoField = GridField::create('Promos', 'Promos', $promos, $config);
55
56	1	$fields->addFieldsToTab('Root.Main', array(
57	1	$promoField,
58	1	));
59	1	}
60
61	1	return $fields;
62		}
63
64		/**
65		* @return mixed
66		*/
67	1	public function getPromoList()
68		{
69	1	return $this->Promos()->sort('SortOrder');
		0 ignored issues – show Documentation Bug introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report The method `Promos` does not exist on `object<PromoBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
70		}
71		}

dynamic / dynamic-blocks

Push — master ( 6214aa...daa834 )

PromoBlock A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like