AccordionBlock - Code Metrics - Inspection of "Merge pull request #25 from jsirish/refactor/accor..." - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0470fe...7a7bdf )

by Jason

created 2017-02-05 02:55 UTC

AccordionBlock A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	67
Duplicated Lines	37.31 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

95.83%

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	6
dl	25
loc	67
ccs	23
cts	24
cp	0.9583
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	25	25	3
A	getPanelList()	0	7	2

How to fix Duplicated Code

<?php

class AccordionBlock extends Block
{
    /**
     * @var string
     */
    private static $singular_name = 'Accordion Block';

    /**
     * @var string
     */
    private static $plural_name = 'Accordion Blocks';

    /**
     * @var array
     */
    private static $db = array(
        'Content' => 'HTMLText',
        'SortOrder' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_many = array(
        'Panels' => 'AccordionPanel',
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()

    {
        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'SortOrder',
            'Panels',
        ));

        $config = GridFieldConfig_RecordEditor::create();
        if (class_exists('GridFieldOrderableRows')) {
            $config->addComponent(new GridFieldOrderableRows());
        }
        $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
        $config->removeComponentsByType('GridFieldDeleteAction');
        $config->addComponent(new GridFieldDeleteAction(false));

        if ($this->ID) {
            $fields->addFieldsToTab('Root.Panels', array(
                GridField::create('Panels', 'Accordion Panels', $this->Panels()->sort('Sort'), $config),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ));
        }

        return $fields;
    }

    /**
     * @return DataList
     */
    public function getPanelList()
    {
        if ($this->Panels()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->Panels()->sort('Sort');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        return $this->Panels();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}

class AccordionBlock_Controller extends Block_Controller

{
    /**
     * @var string
     */
    private static $accordion_class = 'accordion-block';


    /**
     *
     */
    public function init()
    {
        $class = $this->AccordionClass();
        Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
        Requirements::customScript('
            $(function() {
                $( ".' . $class . '" ).accordion({
                    header: ".accord-header",
                    collapsible: true, heightStyle: "content"
                });
            });
        ');
    }

    /**
     * @return array
     */
    public function AccordionClass()
    {
        return Config::inst()->get('AccordionBlock_Controller', 'accordion_class');
    }
}

1			<?php
2
3			class AccordionBlock extends Block
4			{
5			/**
6			* @var string
7			*/
8			private static $singular_name = 'Accordion Block';
9
10			/**
11			* @var string
12			*/
13			private static $plural_name = 'Accordion Blocks';
14
15			/**
16			* @var array
17			*/
18			private static $db = array(
19			'Content' => 'HTMLText',
20			'SortOrder' => 'Int',
21			);
22
23			/**
24			* @var array
25			*/
26			private static $has_many = array(
27			'Panels' => 'AccordionPanel',
28			);
29
30			/**
31			* @return FieldList
32			*/
33	1	View Code Duplication	public function getCMSFields()
			0 ignored issues – show Duplication introduced 2016-12-07 16:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34			{
35	1		$fields = parent::getCMSFields();
36
37	1		$fields->removeByName(array(
38	1		'SortOrder',
39	1		'Panels',
40	1		));
41
42	1		$config = GridFieldConfig_RecordEditor::create();
43	1		if (class_exists('GridFieldOrderableRows')) {
44	1		$config->addComponent(new GridFieldOrderableRows());
45	1		}
46	1		$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
47	1		$config->removeComponentsByType('GridFieldDeleteAction');
48	1		$config->addComponent(new GridFieldDeleteAction(false));
49
50	1		if ($this->ID) {
51	1		$fields->addFieldsToTab('Root.Panels', array(
52	1		GridField::create('Panels', 'Accordion Panels', $this->Panels()->sort('Sort'), $config),
			0 ignored issues – show Documentation Bug introduced 2016-09-27 04:58 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
53	1		));
54	1		}
55
56	1		return $fields;
57			}
58
59			/**
60			* @return DataList
61			*/
62	1		public function getPanelList()
63			{
64	1		if ($this->Panels()->exists()) {
			0 ignored issues – show Documentation Bug introduced 2017-02-05 01:47 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
65	1		return $this->Panels()->sort('Sort');
			0 ignored issues – show Documentation Bug introduced 2017-02-05 01:47 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
66	1		}
67			return $this->Panels();
			0 ignored issues – show Documentation Bug introduced 2017-02-05 01:47 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
68			}
69			}
70
71			class AccordionBlock_Controller extends Block_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-04 21:43 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
72			{
73			/**
74			* @var string
75			*/
76			private static $accordion_class = 'accordion-block';
			0 ignored issues – show Unused Code introduced 2017-02-05 02:03 UTC by Report Bug Copy Issue Report The property `$accordion_class` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
77
78			/**
79			*
80			*/
81	1		public function init()
82			{
83			$class = $this->AccordionClass();
84			Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
85	1		Requirements::customScript('
86			$(function() {
87			$( ".' . $class . '" ).accordion({
88			header: ".accord-header",
89			collapsible: true, heightStyle: "content"
90			});
91			});
92			');
93			}
94
95			/**
96			* @return array
97			*/
98			public function AccordionClass()
99			{
100			return Config::inst()->get('AccordionBlock_Controller', 'accordion_class');
101			}
102			}

dynamic / dynamic-blocks

Push — master ( 0470fe...7a7bdf )

AccordionBlock A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like