SlideshowBlock::canView() - Code Metrics - Inspection of "Merge pull request #10 from jsirish/feature/permis..." - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f85faa...6214aa )

by Jason

created 2016-11-03 01:36 UTC

SlideshowBlock::canView() B

↳ Parent: SlideshowBlock

Complexity

Conditions	5
Paths	4

Size

Total Lines	14
Code Lines	7

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	14
loc	14
ccs	0
cts	8
cp	0
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	7
nc	4
nop	1
crap	30

<?php

class SlideshowBlock extends Block

{
    /**
     * @var string
     */
    private static $singular_name = 'Slideshow Block';

    /**
     * @var string
     */
    private static $plural_name = 'Slideshow Blocks';

    /**
     * @param null $member
     * @return bool|null
     */
    public function canCreate($member = null)
    {
        if (!$member || !(is_a($member, 'Member')) || is_numeric($member)) {
            $member = Member::currentUserID();
        }

        // Standard mechanism for accepting permission changes from extensions
        $extended = $this->extendedCan('canCreate', $member);
        if ($extended !== null) {
            return $extended;
        }

        return parent::canCreate($member);
    }

    /**
     * @param null $member
     * @return bool|null
     */
    public function canView($member = null)
    {
        if (!$member || !(is_a($member, 'Member')) || is_numeric($member)) {
            $member = Member::currentUserID();
        }

        // Standard mechanism for accepting permission changes from extensions
        $extended = $this->extendedCan('canView', $member);
        if ($extended !== null) {
            return $extended;
        }

        return parent::canView($member);
    }
}

1		<?php
2
3	View Code Duplication	class SlideshowBlock extends Block
		0 ignored issues – show Duplication introduced 2016-11-03 01:36 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
4		{
5		/**
6		* @var string
7		*/
8		private static $singular_name = 'Slideshow Block';
9
10		/**
11		* @var string
12		*/
13		private static $plural_name = 'Slideshow Blocks';
14
15		/**
16		* @param null $member
17		* @return bool\|null
18		*/
19		public function canCreate($member = null)
20		{
21		if (!$member \|\| !(is_a($member, 'Member')) \|\| is_numeric($member)) {
22		$member = Member::currentUserID();
23		}
24
25		// Standard mechanism for accepting permission changes from extensions
26		$extended = $this->extendedCan('canCreate', $member);
27		if ($extended !== null) {
28		return $extended;
29		}
30
31		return parent::canCreate($member);
32		}
33
34		/**
35		* @param null $member
36		* @return bool\|null
37		*/
38		public function canView($member = null)
39		{
40		if (!$member \|\| !(is_a($member, 'Member')) \|\| is_numeric($member)) {
41		$member = Member::currentUserID();
42		}
43
44		// Standard mechanism for accepting permission changes from extensions
45		$extended = $this->extendedCan('canView', $member);
46		if ($extended !== null) {
47		return $extended;
48		}
49
50		return parent::canView($member);
51		}
52		}

dynamic / dynamic-blocks

Push — master ( f85faa...6214aa )

SlideshowBlock::canView() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like