Dynamic\DynamicBlocks\Block\RecentBlogPostsBlock

Complexity

Total Complexity

6

Size/Duplication

Total Lines	81
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

61.9%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	18	18	2
A	canCreate()	0	7	2
A	canView()	0	7	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 16 and the first side effect is on line 10.

namespace Dynamic\DynamicBlocks\Block;

use SheaDawson\Blocks\Model\Block;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\NumericField;

if (!class_exists('Blog')) {
    return;
}

/**
 * Class RecentBlogPostsBlock
 */
class RecentBlogPostsBlock extends Block
{
    /**
     * @var string
     */
    private static $singular_name = 'Recent Blog Posts Block';

    /**
     * @var string
     */
    private static $plural_name = 'Recent Blog Posts Blocks';

    /**
     * @var array
     */
    private static $db = array(
        'Limit' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Blog' => 'Blog',
    );

    /**
     * @var array
     */
    private static $defaults = array(
        'Limit' => 3,
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()

This method seems to be duplicated in your project.

    {
        $fields = singleton('Block')->getCMSFields();

        $fields->addFieldsToTab('Root.Main', array(
            NumericField::create('Limit'),
        ));

        if (class_exists('Blog')) {
            $fields->addFieldToTab(
                'Root.Main',
                DropdownField::create('BlogID', 'Featured Blog', Blog::get()->map())
                    ->setEmptyString('')
            );
        }

        return $fields;
    }

    /**
     * @param null $member
     * @param array $context
     * @return bool
     */
    public function canCreate($member = NULL, $context = [])
    {
        if (!class_exists('Blog')) {
            return false;
        }
        return parent::canCreate();
    }

    /**
     * @param null $member
     * @param array $context
     * @return bool
     */
    public function canView($member = NULL, $context = [])

The parameter $context is not used and could be removed.

    {
        if (!class_exists('Blog')) {
            return false;
        }
        return parent::canView();
    }
}