PromoObject

Complexity

Total Complexity

7

Size/Duplication

Total Lines	155
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	30	1
A	validate()	0	10	2
A	canCreate()	0	4	1
A	canView()	0	4	1
A	canEdit()	0	4	1

<?php

namespace Dynamic\DynamicBlocks\Model;

use Dynamic\DynamicBlocks\Block\PromoBlock;
use SilverStripe\Assets\Image;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldConfig_RecordViewer;
use SilverStripe\ORM\DataObject;

class PromoObject extends DataObject
{
    /**
     * @return string
     */
    private static $singular_name = 'Promo';

    /**
     * @return string
     */
    private static $plural_name = 'Promos';

    /**
     * @var array
     */
    private static $db = array(
        'Name' => 'Varchar(255)',
        'Title' => 'Varchar(255)',
        'Content' => 'HTMLText',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Image' => Image::class,
        //'BlockLink' => 'Link', // todo readd once Linkable is SS4 compatible

58% of this comment could be valid code. Did you maybe forget this after debugging?

    );

    /**
     * @var array
     */
    private static $belongs_many_many = array(
        'PromoBlocks' => PromoBlock::class,
    );

    /**
     * @var string
     */
    private static $default_sort = 'Name ASC';

The property $default_sort is not used and could be removed.

    /**
     * @var array
     */
    private static $summary_fields = array(
        'Image.CMSThumbnail' => 'Image',
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @var array
     */
    private static $searchable_fields = array(
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @return \SilverStripe\Forms\FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function ($fields) {

The parameter $fields is not used and could be removed.

            /* // todo readd once Linkable is SS4 compatible

60% of this comment could be valid code. Did you maybe forget this after debugging?

            $fields->addFieldToTab(
                'Root.Main',
                LinkField::create('BlockLinkID', 'Link'),
                'Content'
            );
            */
        });

        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'PromoBlocks',
        ));

        $fields->dataFieldByName('Name')->setDescription('For internal reference only');

        $image = $fields->dataFieldByName('Image');
        $image->setFolderName('Uploads/Promos');
        $fields->insertBefore($image, 'Content');

$image is of type object<SilverStripe\Forms\FormField>|null, but the function expects a string.

'Content' is of type string, but the function expects a object<SilverStripe\Forms\FormField>.

        $config = GridFieldConfig_RecordViewer::create();
        $fields->addFieldToTab('Root.Blocks', GridField::create('PromoBlocks', 'Blocks', $this->PromoBlocks(), $config));

The method PromoBlocks does not exist on object<Dynamic\DynamicBlocks\Model\PromoObject>? Since you implemented __call, maybe consider adding a @method annotation.

        return $fields;
    }

    /**
     * @return \SilverStripe\ORM\ValidationResult
     */
    public function validate()
    {
        $result = parent::validate();

        if (!$this->Name) {

The property Name does not exist on object<Dynamic\DynamicBlocks\Model\PromoObject>. Since you implemented __get, maybe consider adding a @property annotation.

            $result->error('Name is requied before you can save');

The method error() does not seem to exist on object<SilverStripe\ORM\ValidationResult>.

        }

        return $result;
    }

    /**
     * Set permissions, allow all users to access by default.
     * Override in descendant classes, or use PermissionProvider.
     */

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canCreate($member = null, $context = [])
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canView($member = null, $context = [])

The parameter $context is not used and could be removed.

    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canEdit($member = null, $context = [])

The parameter $context is not used and could be removed.

    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canDelete($member = null, $context = [])

The parameter $context is not used and could be removed.

    {
        return true;
    }
}