RecentBlogPostsBlockTest - Code Metrics - Inspection of "RecentBlogPostsBlock - check if Blog exists" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Jason

created 2016-09-30 16:32 UTC

RecentBlogPostsBlockTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	38.1 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	16
loc	42
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetCMSFields()	0	7	1
A	testCanView()	8	8	1
A	testCanCreate()	8	8	1

How to fix Duplicated Code

<?php

class RecentBlogPostsBlockTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'dynamic-blocks/tests/Fixtures.yml';

    /**
     *
     */
    public function testGetCMSFields()
    {
        $object = $this->objFromFixture('RecentBlogPostsBlock', 'one');
        $fields = $object->getCMSFields();
        $this->assertInstanceOf('FieldList', $fields);
        $this->assertNull($fields->dataFieldByName('SortOrder'));

    }

    /**
     *
     */
    public function testCanView()

    {
        $object = $this->objFromFixture('RecentBlogPostsBlock', 'one');
        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canView($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture('Member', 'default');
        $this->assertTrue($object->canView($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanCreate()

    {
        $object = $this->objFromFixture('RecentBlogPostsBlock', 'one');
        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canCreate($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture('Member', 'default');
        $this->assertTrue($object->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}

1		<?php
2
3		class RecentBlogPostsBlockTest extends SapphireTest
4		{
5		/**
6		* @var string
7		*/
8		protected static $fixture_file = 'dynamic-blocks/tests/Fixtures.yml';
9
10		/**
11		*
12		*/
13		public function testGetCMSFields()
14		{
15		$object = $this->objFromFixture('RecentBlogPostsBlock', 'one');
16		$fields = $object->getCMSFields();
17		$this->assertInstanceOf('FieldList', $fields);
18		$this->assertNull($fields->dataFieldByName('SortOrder'));
		0 ignored issues – show Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report The method `assertNull()` does not seem to exist on `object<RecentBlogPostsBlockTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
19		}
20
21		/**
22		*
23		*/
24	View Code Duplication	public function testCanView()
		0 ignored issues – show Duplication introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		$object = $this->objFromFixture('RecentBlogPostsBlock', 'one');
27		$admin = $this->objFromFixture('Member', 'admin');
28		$this->assertTrue($object->canView($admin));
		0 ignored issues – show Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `27` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<RecentBlogPostsBlockTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29		$member = $this->objFromFixture('Member', 'default');
30		$this->assertTrue($object->canView($member));
		0 ignored issues – show Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `29` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<RecentBlogPostsBlockTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31		}
32
33		/**
34		*
35		*/
36	View Code Duplication	public function testCanCreate()
		0 ignored issues – show Duplication introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$object = $this->objFromFixture('RecentBlogPostsBlock', 'one');
39		$admin = $this->objFromFixture('Member', 'admin');
40		$this->assertTrue($object->canCreate($admin));
		0 ignored issues – show Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `39` can also be of type `object<DataObject>`; however, `DataObject::canCreate()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<RecentBlogPostsBlockTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41		$member = $this->objFromFixture('Member', 'default');
42		$this->assertTrue($object->canCreate($member));
		0 ignored issues – show Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `41` can also be of type `object<DataObject>`; however, `DataObject::canCreate()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-09-30 16:37 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<RecentBlogPostsBlockTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
43		}
44		}

dynamic / dynamic-blocks

Pull Request — master (#7)

RecentBlogPostsBlockTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like