PromoBlock::getCMSFields() - Code Metrics - Inspection of "Merge pull request #16 from muskie9/enhancement/pa..." - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Cancelled

Push — master ( b1ac67...38ef72 )

by Nic

created 2016-12-07 20:52 UTC

PromoBlock::getCMSFields() B

↳ Parent: PromoBlock

Complexity

Conditions	4
Paths	5

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	4.0138

Importance

Changes

Metric	Value
dl	0
loc	27
ccs	19
cts	21
cp	0.9048
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	5
nop	0
crap	4.0138

<?php

class PromoBlock extends Block
{
    /**
     * @return string
     */
    public function singular_name()
    {
        return _t('PromoBlock.SINGULARNAME', 'Promo Block');
    }

    /**
     * @return string
     */
    public function plural_name()
    {
        return _t('PromoBlock.PLURALNAME', 'Promo Blocks');
    }

    /**
     * @var array
     */
    private static $many_many = array(
        'Promos' => 'PromoObject',
    );

    /**
     * @var array
     */
    private static $many_many_extraFields = array(
        'Promos' => array(
            'SortOrder' => 'Int',
        ),
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'Promos',
        ));

        if ($this->ID) {
            $config = GridFieldConfig_RelationEditor::create();
            if (class_exists('GridFieldSortableRows')) {
                $config->addComponent(new GridFieldSortableRows('SortOrder'));
            }
            if (class_exists('GridFieldAddExistingSearchButton')) {
                $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
                $config->addComponent(new GridFieldAddExistingSearchButton());
            }
            $promos = $this->Promos()->sort('SortOrder');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $promoField = GridField::create('Promos', 'Promos', $promos, $config);

            $fields->addFieldsToTab('Root.Main', array(
                $promoField,
            ));
        }

        return $fields;
    }

    /**
     * @return mixed
     */
    public function getPromoList()
    {
        return $this->Promos()->sort('SortOrder');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}

1		<?php
2
3		class PromoBlock extends Block
4		{
5		/**
6		* @return string
7		*/
8	8	public function singular_name()
9		{
10	8	return _t('PromoBlock.SINGULARNAME', 'Promo Block');
11		}
12
13		/**
14		* @return string
15		*/
16		public function plural_name()
17		{
18		return _t('PromoBlock.PLURALNAME', 'Promo Blocks');
19		}
20
21		/**
22		* @var array
23		*/
24		private static $many_many = array(
25		'Promos' => 'PromoObject',
26		);
27
28		/**
29		* @var array
30		*/
31		private static $many_many_extraFields = array(
32		'Promos' => array(
33		'SortOrder' => 'Int',
34		),
35		);
36
37		/**
38		* @return FieldList
39		*/
40	1	public function getCMSFields()
41		{
42	1	$fields = parent::getCMSFields();
43
44	1	$fields->removeByName(array(
45	1	'Promos',
46	1	));
47
48	1	if ($this->ID) {
49	1	$config = GridFieldConfig_RelationEditor::create();
50	1	if (class_exists('GridFieldSortableRows')) {
51		$config->addComponent(new GridFieldSortableRows('SortOrder'));
52		}
53	1	if (class_exists('GridFieldAddExistingSearchButton')) {
54	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
55	1	$config->addComponent(new GridFieldAddExistingSearchButton());
56	1	}
57	1	$promos = $this->Promos()->sort('SortOrder');
		0 ignored issues – show Documentation Bug introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report The method `Promos` does not exist on `object<PromoBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
58	1	$promoField = GridField::create('Promos', 'Promos', $promos, $config);
59
60	1	$fields->addFieldsToTab('Root.Main', array(
61	1	$promoField,
62	1	));
63	1	}
64
65	1	return $fields;
66		}
67
68		/**
69		* @return mixed
70		*/
71	1	public function getPromoList()
72		{
73	1	return $this->Promos()->sort('SortOrder');
		0 ignored issues – show Documentation Bug introduced 2016-09-27 04:07 UTC by Report Bug Copy Issue Report The method `Promos` does not exist on `object<PromoBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
74		}
75		}

dynamic / dynamic-blocks

Push — master ( b1ac67...38ef72 )

PromoBlock::getCMSFields() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like