PageSectionObject::getCMSFields() - Code Metrics - Inspection of "Merge pull request #16 from muskie9/enhancement/pa..." - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Cancelled

Push — master ( b1ac67...38ef72 )

by Nic

created 2016-12-07 20:52 UTC

PageSectionObject::getCMSFields() A

↳ Parent: PageSectionObject

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	11
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0
crap	2

<?php

/**
 * Class PageSectionObject
 *
 * @property string $Name
 * @property string $Title
 * @property HTMLText $Content
 * @property int $SortOrder
 * @property int $ImageID
 * @property int $PageSectionBlockID
 */
class PageSectionObject extends DataObject
{
    /**
     * @return string
     */
    private static $singular_name = 'Page Section';

    /**
     * @return string
     */
    private static $plural_name = 'Page Sections';

    /**
     * @var array
     */
    private static $db = array(
        'Name' => 'Varchar(255)',
        'Title' => 'Varchar(255)',
        'Content' => 'HTMLText',
        'SortOrder' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Image' => 'Image',
        'PageSectionBlock' => 'PageSectionBlock',
    );

    /**
     * @var string
     */
    private static $default_sort = 'Name ASC';


    /**
     * @var array
     */
    private static $summary_fields = array(
        'Image.CMSThumbnail' => 'Image',
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @var array
     */
    private static $searchable_fields = array(
        'Name' => 'Name',
        'Title' => 'Title',
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'PageSectionBlockID',
            'SortOrder',
        ));

        $fields->dataFieldByName('Name')->setDescription('For internal reference only');

        $image = $fields->dataFieldByName('Image');
        $image->setFolderName('Uploads/PageSections');
        $fields->insertBefore($image, 'Content');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $fields;
    }

    /**
     * @return ValidationResult
     */
    public function validate()
    {
        $result = parent::validate();

        if (!$this->Name) {
            $result->error('Name is requied before you can save');
        }

        return $result;
    }

    /**
     * Set permissions, allow all users to access by default.
     * Override in descendant classes, or use PermissionProvider.
     */

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        return true;
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        return true;
    }
}

1			<?php
2
3			/**
4			* Class PageSectionObject
5			*
6			* @property string $Name
7			* @property string $Title
8			* @property HTMLText $Content
9			* @property int $SortOrder
10			* @property int $ImageID
11			* @property int $PageSectionBlockID
12			*/
13			class PageSectionObject extends DataObject
14			{
15			/**
16			* @return string
17			*/
18			private static $singular_name = 'Page Section';
19
20			/**
21			* @return string
22			*/
23			private static $plural_name = 'Page Sections';
24
25			/**
26			* @var array
27			*/
28			private static $db = array(
29			'Name' => 'Varchar(255)',
30			'Title' => 'Varchar(255)',
31			'Content' => 'HTMLText',
32			'SortOrder' => 'Int',
33			);
34
35			/**
36			* @var array
37			*/
38			private static $has_one = array(
39			'Image' => 'Image',
40			'PageSectionBlock' => 'PageSectionBlock',
41			);
42
43			/**
44			* @var string
45			*/
46			private static $default_sort = 'Name ASC';
			0 ignored issues – show Unused Code introduced 2016-12-07 16:43 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
47
48			/**
49			* @var array
50			*/
51			private static $summary_fields = array(
52			'Image.CMSThumbnail' => 'Image',
53			'Name' => 'Name',
54			'Title' => 'Title',
55			);
56
57			/**
58			* @var array
59			*/
60			private static $searchable_fields = array(
61			'Name' => 'Name',
62			'Title' => 'Title',
63			);
64
65			/**
66			* @return FieldList
67			*/
68			public function getCMSFields()
69			{
70			$fields = parent::getCMSFields();
71
72			$fields->removeByName(array(
73			'PageSectionBlockID',
74			'SortOrder',
75			));
76
77			$fields->dataFieldByName('Name')->setDescription('For internal reference only');
78
79			$image = $fields->dataFieldByName('Image');
80			$image->setFolderName('Uploads/PageSections');
81			$fields->insertBefore($image, 'Content');
			0 ignored issues – show Documentation introduced 2016-12-07 16:43 UTC by Report Bug Copy Issue Report `'Content'` is of type `string`, but the function expects a `object<FormField>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82
83			return $fields;
84			}
85
86			/**
87			* @return ValidationResult
88			*/
89			public function validate()
90			{
91			$result = parent::validate();
92
93			if (!$this->Name) {
94			$result->error('Name is requied before you can save');
95			}
96
97			return $result;
98			}
99
100			/**
101			* Set permissions, allow all users to access by default.
102			* Override in descendant classes, or use PermissionProvider.
103			*/
104
105			/**
106			* @param null $member
107			*
108			* @return bool
109			*/
110			public function canCreate($member = null)
111			{
112			return true;
113			}
114
115			/**
116			* @param null $member
117			*
118			* @return bool
119			*/
120			public function canView($member = null)
121			{
122			return true;
123			}
124
125			/**
126			* @param null $member
127			*
128			* @return bool
129			*/
130			public function canEdit($member = null)
131			{
132			return true;
133			}
134
135			/**
136			* @param null $member
137			*
138			* @return bool
139			*/
140			public function canDelete($member = null)
141			{
142			return true;
143			}
144			}

dynamic / dynamic-blocks

Push — master ( b1ac67...38ef72 )

PageSectionObject::getCMSFields() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like