AccordionBlock - Code Metrics - Inspection of "SilverStripe 4 upgrade" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

by Jason

created 2017-07-07 03:35 UTC

AccordionBlock A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

96.3%

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	6
dl	0
loc	73
ccs	26
cts	27
cp	0.963
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	singular_name()	4	1
A	plural_name()	4	1
B	getCMSFields()	25	3

<?php

namespace Dynamic\DynamicBlocks\Block;

use Dynamic\DynamicBlocks\Model\AccordionPanel;
use League\Flysystem\Config;
use SheaDawson\Blocks\Controllers\BlockController;
use SheaDawson\Blocks\Model\Block;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldConfig_RecordEditor;
use SilverStripe\Forms\GridField\GridFieldDeleteAction;
use SilverStripe\View\Requirements;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;

class AccordionBlock extends Block
{
    /**
     * @return string
     */
    public function singular_name()
    {
        return _t('AccordionBlock.SINGULARNAME', 'Accordion Block');
    }

    /**
     * @return string
     */
    public function plural_name()
    {
        return _t('AccordionBlock.PLURALNAME', 'Accordion Blocks');
    }

    /**
     * @var array
     */
    private static $db = array(
        'Content' => 'HTMLText',
        'SortOrder' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_many = array(
        'Panels' => AccordionPanel::class,
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'SortOrder',
            'Panels',
        ));

        $config = GridFieldConfig_RecordEditor::create();
        if (class_exists(GridFieldOrderableRows::class)) {
            $config->addComponent(new GridFieldOrderableRows());
        }
        $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
        $config->removeComponentsByType(GridFieldDeleteAction::class);
        $config->addComponent(new GridFieldDeleteAction(false));

        if ($this->ID) {
            $fields->addFieldsToTab('Root.Panels', array(
                GridField::create('Panels', 'Accordion Panels', $this->Panels()->sort('Sort'), $config),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ));
        }

        return $fields;
    }

    /**
     * @return DataList
     */
    public function getPanelList()
    {
        if ($this->Panels()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->Panels()->sort('Sort');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        return $this->Panels();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}

class AccordionBlockController extends BlockController

{
    /**
     * @var string
     */
    private static $accordion_class = 'accordion-block';


    /**
     *
     */
    public function init()
    {
        $class = $this->AccordionClass();
        Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
        Requirements::customScript('
            $(function() {
                $( ".' . $class . '" ).accordion({
                    header: ".accord-header",
                    collapsible: true, heightStyle: "content"
                });
            });
        ');
    }

    /**
     * @return array
     */
    public function AccordionClass()
    {
        return Config::inst()->get('AccordionBlockController', 'accordion_class');

    }
}

1		<?php
2
3		namespace Dynamic\DynamicBlocks\Block;
4
5		use Dynamic\DynamicBlocks\Model\AccordionPanel;
6		use League\Flysystem\Config;
7		use SheaDawson\Blocks\Controllers\BlockController;
8	12	use SheaDawson\Blocks\Model\Block;
9		use SilverStripe\Forms\GridField\GridField;
10	12	use SilverStripe\Forms\GridField\GridFieldConfig_RecordEditor;
11		use SilverStripe\Forms\GridField\GridFieldDeleteAction;
12		use SilverStripe\View\Requirements;
13		use Symbiote\GridFieldExtensions\GridFieldOrderableRows;
14
15		class AccordionBlock extends Block
16	1	{
17		/**
18	1	* @return string
19		*/
20		public function singular_name()
21		{
22		return _t('AccordionBlock.SINGULARNAME', 'Accordion Block');
23		}
24
25		/**
26		* @return string
27		*/
28		public function plural_name()
29		{
30		return _t('AccordionBlock.PLURALNAME', 'Accordion Blocks');
31		}
32
33		/**
34		* @var array
35		*/
36		private static $db = array(
37		'Content' => 'HTMLText',
38		'SortOrder' => 'Int',
39	1	);
40
41	1	/**
42		* @var array
43	1	*/
44	1	private static $has_many = array(
45	1	'Panels' => AccordionPanel::class,
46	1	);
47
48	1	/**
49	1	* @return FieldList
50	1	*/
51	1	public function getCMSFields()
52	1	{
53	1	$fields = parent::getCMSFields();
54	1
55		$fields->removeByName(array(
56	1	'SortOrder',
57	1	'Panels',
58	1	));
59	1
60	1	$config = GridFieldConfig_RecordEditor::create();
61		if (class_exists(GridFieldOrderableRows::class)) {
62	1	$config->addComponent(new GridFieldOrderableRows());
63		}
64		$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
65		$config->removeComponentsByType(GridFieldDeleteAction::class);
66		$config->addComponent(new GridFieldDeleteAction(false));
67
68	1	if ($this->ID) {
69		$fields->addFieldsToTab('Root.Panels', array(
70	1	GridField::create('Panels', 'Accordion Panels', $this->Panels()->sort('Sort'), $config),
		0 ignored issues – show Documentation Bug introduced 2017-07-06 04:36 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<Dynamic\DynamicBl...s\Block\AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
71	1	));
72		}
73
74		return $fields;
75		}
76
77		/**
78		* @return DataList
79		*/
80		public function getPanelList()
81		{
82		if ($this->Panels()->exists()) {
		0 ignored issues – show Documentation Bug introduced 2017-07-06 04:36 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<Dynamic\DynamicBl...s\Block\AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
83		return $this->Panels()->sort('Sort');
		0 ignored issues – show Documentation Bug introduced 2017-07-06 04:36 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<Dynamic\DynamicBl...s\Block\AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
84		}
85		return $this->Panels();
		0 ignored issues – show Documentation Bug introduced 2017-07-06 04:36 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<Dynamic\DynamicBl...s\Block\AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
86		}
87		}
88
89		class AccordionBlockController extends BlockController
		0 ignored issues – show Coding Style Compatibility introduced 2017-02-04 21:43 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
90		{
91		/**
92		* @var string
93		*/
94		private static $accordion_class = 'accordion-block';
		0 ignored issues – show Unused Code introduced 2017-02-05 02:03 UTC by Report Bug Copy Issue Report The property `$accordion_class` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
95
96		/**
97		*
98		*/
99		public function init()
100		{
101		$class = $this->AccordionClass();
102		Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
103		Requirements::customScript('
104		$(function() {
105		$( ".' . $class . '" ).accordion({
106		header: ".accord-header",
107		collapsible: true, heightStyle: "content"
108		});
109		});
110		');
111		}
112
113		/**
114		* @return array
115		*/
116		public function AccordionClass()
117		{
118		return Config::inst()->get('AccordionBlockController', 'accordion_class');
		0 ignored issues – show Bug introduced 2017-07-06 04:36 UTC by Report Bug Copy Issue Report The method `inst()` does not seem to exist on `object<League\Flysystem\Config>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
119		}
120		}

dynamic / dynamic-blocks

Pull Request — master (#62)

AccordionBlock A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like